Need NoView Plugin Support

[Dastgir]

Hello,

I have today released new plugin, namely NoView.

It adds command @noview to disable the headgear views for users (Upper/Mid/Lower headgear views)

Link: https://github.com/dastgirp/HPM-Plugins/blob/master/src/plugins/noview.c

 

[Kuroyama]

First to thank you with this sir dast. This is what I've been looking for months. Great work!  :lv:

 

[Zero Human]

At first, thanks for the plugin release,
but It's just me who get the const error?

 

noview.c: In function ‘clif_send_helper’:
noview.c:168:49: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_idle_unit *p = (CONST_PARAMETER struct packet_idle_unit *)RBUFP(buf, 0);
                                                 ^
noview.c:169:50: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_idle_unit *p2 = (CONST_PARAMETER struct packet_idle_unit *)RBUFP(buf_new, 0);
                                                  ^
noview.c:175:50: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_spawn_unit *p = (CONST_PARAMETER struct packet_spawn_unit *)RBUFP(buf, 0);
                                                  ^
noview.c:176:51: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_spawn_unit *p2 = (CONST_PARAMETER struct packet_spawn_unit*)RBUFP(buf_new, 0);
                                                   ^
noview.c:182:52: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_unit_walking *p = (CONST_PARAMETER struct packet_unit_walking *)RBUFP(buf, 0);
                                                    ^
noview.c:183:53: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_unit_walking *p2 = (CONST_PARAMETER struct packet_unit_walking *)RBUFP(buf_new, 0);
                                                     ^
noview.c:189:53: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_viewequip_ack *p = (CONST_PARAMETER struct packet_viewequip_ack *)RBUFP(buf, 0);
                                                     ^
noview.c:190:54: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_viewequip_ack *p2 = (CONST_PARAMETER struct packet_viewequip_ack *)RBUFP(buf_new, 0);
                                                      ^
noview.c: In function ‘clif_send_sub_hook’:
noview.c:269:6: warning: variable ‘bool_’ set but not used [-Wunused-but-set-variable]
  int bool_;
 

 

[Zero Human]

It adds command @noview to disable the headgear views for users

Aaand the next stuff. Don't know if this just me, but the command works for the whole server.
So... if anyone use the command, the whole server can't see headgears. xD

 

[Kuroyama]

At first, thanks for the plugin release,
but It's just me who get the const error?

noview.c: In function ‘clif_send_helper’:
noview.c:168:49: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_idle_unit *p = (CONST_PARAMETER struct packet_idle_unit *)RBUFP(buf, 0);
                                                 ^
noview.c:169:50: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_idle_unit *p2 = (CONST_PARAMETER struct packet_idle_unit *)RBUFP(buf_new, 0);
                                                  ^
noview.c:175:50: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_spawn_unit *p = (CONST_PARAMETER struct packet_spawn_unit *)RBUFP(buf, 0);
                                                  ^
noview.c:176:51: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_spawn_unit *p2 = (CONST_PARAMETER struct packet_spawn_unit*)RBUFP(buf_new, 0);
                                                   ^
noview.c:182:52: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_unit_walking *p = (CONST_PARAMETER struct packet_unit_walking *)RBUFP(buf, 0);
                                                    ^
noview.c:183:53: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_unit_walking *p2 = (CONST_PARAMETER struct packet_unit_walking *)RBUFP(buf_new, 0);
                                                     ^
noview.c:189:53: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_viewequip_ack *p = (CONST_PARAMETER struct packet_viewequip_ack *)RBUFP(buf, 0);
                                                     ^
noview.c:190:54: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_viewequip_ack *p2 = (CONST_PARAMETER struct packet_viewequip_ack *)RBUFP(buf_new, 0);
                                                      ^
noview.c: In function ‘clif_send_sub_hook’:
noview.c:269:6: warning: variable ‘bool_’ set but not used [-Wunused-but-set-variable]
  int bool_;

I notice this error too (but in centos/linux only. On windows, its fine), but somehow I didn't experience that whole server noview. I'll try to test that very soon.

 

[xJhay]

noview.c: In function ‘clif_send_helper’:
noview.c:168:49: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_idle_unit *p = (CONST_PARAMETER struct packet_idle_unit *)RBUFP(buf, 0);
                                                 ^
noview.c:169:50: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_idle_unit *p2 = (CONST_PARAMETER struct packet_idle_unit *)RBUFP(buf_new, 0);
                                                  ^
noview.c:175:50: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_spawn_unit *p = (CONST_PARAMETER struct packet_spawn_unit *)RBUFP(buf, 0);
                                                  ^
noview.c:176:51: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_spawn_unit *p2 = (CONST_PARAMETER struct packet_spawn_unit*)RBUFP(buf_new, 0);
                                                   ^
noview.c:182:52: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_unit_walking *p = (CONST_PARAMETER struct packet_unit_walking *)RBUFP(buf, 0);
                                                    ^
noview.c:183:53: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_unit_walking *p2 = (CONST_PARAMETER struct packet_unit_walking *)RBUFP(buf_new, 0);
                                                     ^
noview.c:189:53: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_viewequip_ack *p = (CONST_PARAMETER struct packet_viewequip_ack *)RBUFP(buf, 0);
                                                     ^
noview.c:190:54: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
    CONST_PARAMETER struct packet_viewequip_ack *p2 = (CONST_PARAMETER struct packet_viewequip_ack *)RBUFP(buf_new, 0);
                                                      ^
noview.c: In function ‘clif_send_sub_hook’:
noview.c:269:6: warning: variable ‘bool_’ set but not used [-Wunused-but-set-variable]
  int bool_;

Is this normal to receive this warning? And is there any way to get rid of this?

 

[AnnieRuru]

hmm ........ already 2 people getting the same error message

I just tested on my test server, compile with visual studio 2019, no problem everything green though

if you get this error does it means you also get disable view for whole server instead of individual player ?

 

[xJhay]

hmm ........ already 2 people getting the same error message

I just tested on my test server, compile with visual studio 2019, no problem everything green though



if you get this error does it means you also get disable view for whole server instead of individual player ?

Hi mam annie. Sometimes, its happening and I'm not sure of that kind of behavior but the main thing is I kinda worried of those warning because it's too many and might cause of more exploits or something.

 

[Dastgir]

Hi mam annie. Sometimes, its happening and I'm not sure of that kind of behavior but the main thing is I kinda worried of those warning because it's too many and might cause of more exploits or something.

The error can ignore for now, but I will get it fixed soon.

If you could tell me the steps to reproduce, I will fix it, but without the steps to reproduce, it's hard for me to test as well.

 

[xJhay]

The error can ignore for now, but I will get it fixed soon.

If you could tell me the steps to reproduce, I will fix it, but without the steps to reproduce, it's hard for me to test as well.

Hello sir dastgir. I do nothing but to put the plugin and recompile it, then the warning shows up.

Edit: When I compile it to windows, its okay and it has no error shows. Only in CentOS.

 

[Dastgir]

Hello sir dastgir. I do nothing but to put the plugin and recompile it, then the warning shows up.

Edit: When I compile it to windows, its okay and it has no error shows. Only in CentOS.

View attachment 6317

I am aware of this warning, for now it's safe to ignore, I was talking about the bug wherein whole server couldn't see hg, I want to know the steps to reproduce that bug

 

[raymedium]

how would I disable character own hat too, not just only other player

 

[Daraen]

I am aware of this warning, for now it's safe to ignore, I was talking about the bug wherein whole server couldn't see hg, I want to know the steps to reproduce that bug

 

same error as @Zero Human etc etc
I just recompile my server after dragging the files for the plugin.

 

[brunosc]

Here got same warning when compile first time.

if  compile again without (make clean) dont show this warnings.