getmemberaid checkmes

[AnnieRuru]

Download: 1.3

plugin

--------------------------------

everything is inside this sample

http://upaste.me/10bb21957e0971185

its meant to attachrid online players

checkmes ...

is just like addrid with type 1 ... means only attachrid on players that doesn't have a npc dialog

- script test dialog -1,{Onaaa: mes "hi"; close;OnInit: while (1) { getmemberaid ALL_CLIENT; for ( .@i = 0; .@i < $@onlinecount; .@i++ ) { if ( !checkmes( $@onlineaid[.@i] ) ) { // if don't have a npc dialog attachrid $@onlineaid[.@i]; addtimer 1, strnpcinfo(0)+"::Onaaa"; } } sleep 1000; }}

Spoiler

1.0

plugin

patch

1.1

-- fixed uint16 into int16 for map index

plugin

patch

1.2

-- fixed battleground team listing bug

plugin

patch

outdated sample

http://upaste.me/0b2010783212b7248

1.3

-- reorganize format thanks to haru

-- fix player and guild type using wrong $@onlineaid index ( should be j, not i )

plugin

 

[evilpuncker]

very nice

 

[quesoph]

Thank you annie..

 

[AnnieRuru]

have to add another script command *checkmes to check the player is having a npc dialog or not

 

[Hadeszeus]

have to add another script command *checkmes to check the player is having a npc dialog or not

Hi Annie, I just want to ask if this is okay? I'm getting this warning in compiling. Thank you!

script.c: In function 'buildin_getmemberaid':script.c:18555: warning: comparison is always false due to limited range of data typescript.c:18577: warning: comparison is always false due to limited range of data type

 

[AnnieRuru]

I think not, might be a bug ... I not sure, though it works in my test server

what's the line on 18555 and 18577 ?

btw, if it falls on line uint16 m;

I've fixed it int16 m; ages ago

 

[Hadeszeus]

Sorry here's the code on that line.

Line 18555

BUILDIN(getmemberaid) { uint16 i = 0; switch ( script_getnum(st,2) ) { // type case ALL_CLIENT: map->foreachpc( buildin_getmemberaid_ALL_pc, &i ); mapreg->setreg( script->add_str("$@onlinecount"), i ); return true; case ALL_SAMEMAP: { uint16 m; if ( script_hasdata(st,3) ) { if ( ( m = map->mapname2mapid( script_getstr(st,3) ) ) < 0 ) {
Line 18577

case AREA:		if ( script_hasdata(st,3) ) {			if ( script_hasdata(st,4) && script_hasdata(st,5) && script_hasdata(st,6) && script_hasdata(st,7) ) {				uint16 m;				if ( ( m = map->mapname2mapid( script_getstr(st,3) ) ) < 0 ) {					mapreg->setreg( script->add_str("$@onlinecount"), 0 );					return false;				}

 

[Hadeszeus]

I think not, might be a bug ... I not sure, though it works in my test server

what's the line on 18555 and 18577 ?

btw, if it falls on line uint16 m;

I've fixed it int16 m; ages ago

ok got it.  ty

 

[evilpuncker]

have to add another script command *checkmes to check the player is having a npc dialog or not

due to your latest patch to hercules, it will not be necessary anymore, right?

Caution :due to CHAT_MAINCHAT removed in clif.h

remember to apply this patch to make type BG works

 

[javierlog08]

Can i diff this on Github Hercules?

 

[evilpuncker]

Can i diff this on Github Hercules?

sure

 

[javierlog08]

Im getting some erros trying to patch this.

A screen shot

http://prntscr.com/36om9j

 

[evilpuncker]

you should wait for annie for update it for latest revision, or use as plugin or apply it manually

 

[Hadeszeus]

you should wait for annie for update it for latest revision, or use as plugin or apply it manually

Should I expect error? I'm still using this in latest rev without problems..

 

[evilpuncker]

you should wait for annie for update it for latest revision, or use as plugin or apply it manually

Should I expect error? I'm still using this in latest rev without problems..

you shouldn't expect error since you have it working already

 

[evilpuncker]

I think not, might be a bug ... I not sure, though it works in my test server

what's the line on 18555 and 18577 ?

btw, if it falls on line uint16 m;

I've fixed it int16 m; ages ago

what was changed in 1.1? xD

 

[AnnieRuru]

LOL

check properly please

http://upaste.me/34ce110099fd24b02

Posted on the 7th March, 2014 at 10:57:59version 1.1 is fixed the 'uint16 m;' into 'int16 m;' for the map indexwhich was already fixed before post#5 (11 March) before he mentioned about that

 

[AnnieRuru]

version 1.2

just a minor fixed of type BG, which was found here

http://herc.ws/board/topic/4570-battleground-system-without-waitingroom/?p=42419

its minor because I'm sure everyone use getbgusers instead of getmemberaid to get the account ID of batttleground users =/

 

[AnnieRuru]

version 1.3

http://upaste.me/0e55219566e411b05

new plugin format

reorganize the code

and ... fix party and guild type using wrong index