@market clone

[Darkpurple]

Hi~Annie,I'd like to report an  issue:

if you kill clone via @killmonster command(still working) ,and then log out your Character , map server will get crashed

edit : I m using plugin v1.1

Confirming this.

Thanks Annie!

Confirmed too..

 

[Angelmelody]

Hi~Annie,I'd like to report an  issue:

if you kill clone via @killmonster command(still working) ,and then log out your Character , map server will get crashed

edit : I m using plugin v1.1

I try building a hooking function to prevent the market clone killed by @killmonster CMD

int atkillmonster_sub_pre(struct block_list *bl, va_list *ap){	struct mob_data *md;	struct monster_data *mmd;	md = (struct mob_data *)bl;		if ( ( mmd = getFromMOBDATA( md, 0 ) ) ) {		if(mmd->market_chat_id){			hookStop();			return 0;		}	}	return 1;}addHookPre( "atcommand->atkillmonster_sub", atkillmonster_sub_pre );

 

[AnnieRuru]

thx Angelmelody

up to version 1.2

@tlacson7

the plugin works but you have to patch this

atm, I didn't properly code the removeFromMOBDB, removeFromMOBDATA, removeFromITEMDATA stuff (I never use them =/)

so don't use these 3 commands yet

 

[kyeme]

@AnnieRuru,
I have a suggestion, can you disable @market while vending, based on my knowledge in official you cannot create chatroom while vending.
Thank you.

 

[vBrenth]

@AnnieRuru,

I have a suggestion, can you disable @market while vending, based on my knowledge in official you cannot create chatroom while vending.

Thank you.

Yeah when people vend, the clone must die

 

[AnnieRuru]

I just noticed somebody in rathena actually start converting my patch into rathena ... namely Napster

well kinda a competition then, as rathena does have more user base than hercules

version 1.3 released

plugin or patch

-- change back all status-damage into status-kill for readability

-- fix a bug that when a server enabled show_mob_info, the clone shouldn't has listed the hp nor level (credit: Napster)

-- fix a bug that player shouldn't create a market clone while chatting or vending

-- and for the patch, move all configuration into battle folder, makes more sense in this way (credit: Napster)

-- add zeny requirement

 

[vBrenth]

Crashed instantly when i used the 1.3 and @market with zeny requirements

 

[AnnieRuru]

omfg ... forgot to add pc-> symbol

EDIT- modify existing paste is very useful ...

 

[Angelmelody]

omfg ... forgot to add pc-> symbol

EDIT- modify existing paste is very useful ...

sscanf  now works for me 

find 

if ( sscanf( message, ""%[^"]" "%[^"]"", title, msg ) < 2 ) {

change to

if ( sscanf( message, ""%256[^"]" "%256[^"]"", title, msg ) < 2 )

 

[AnnieRuru]

http://herc.ws/board/topic/7127-maintenance-mode/?p=43750

ask Hadeszeus is his sscanf is really working fine or not

because that also works fine in my test server

I know I'm being sarcastic, and love to do string calculation hahaha

or actually I just simply hate people posting error ... error ... on my topic, kinda spoiled my reputation

in msvc2010, sscanf will throw error, saying need to use s_sscanf

then if you use s_sscanf, then other members who are not using mscv will get an error ...

very annoying

but when calculate the string, everybody happy

 

[Angelmelody]

http://herc.ws/board/topic/7127-maintenance-mode/?p=43750

ask Hadeszeus is his sscanf is really working fine or not

because that also works fine in my test server

I know I'm being sarcastic, and love to do string calculation hahaha

or actually I just simply hate people posting error ... error ... on my topic, kinda spoiled my reputation

in msvc2010, sscanf will throw error, saying need to use s_sscanf

then if you use s_sscanf, then other members who are not using mscv will get an error ...

very annoying

but when calculate the string, everybody happy

all those s_xxxx.. annoying warnings in my plugin projects were disabled  by me , coz I hate those

Spoiler

1.

right click your plugin project--> choose properties--> configuration properties--> Preprocessor-->Preprocessor Definition -->edit

2. input the below two lines

_CRT_SECURE_NO_DEPRECATE

_SCL_SECURE_NO_DEPRECATE

Spoiler

3 push ok and apply button

 

[glemor123]

I just noticed somebody in rathena actually start converting my patch into rathena ... namely Napster

well kinda a competition then, as rathena does have more user base than hercules

version 1.3 released

plugin or patch

-- change back all status-damage into status-kill for readability

-- fix a bug that when a server enabled show_mob_info, the clone shouldn't has listed the hp nor level (credit: Napster)

-- fix a bug that player shouldn't create a market clone while chatting or vending

-- and for the patch, move all configuration into battle folder, makes more sense in this way (credit: Napster)

-- add zeny requirement

I'll be trying the released version for rathena svn soon. 

 

[THPO]

http://herc.ws/board/topic/7127-maintenance-mode/?p=43750

ask Hadeszeus is his sscanf is really working fine or not

because that also works fine in my test server

I know I'm being sarcastic, and love to do string calculation hahaha

or actually I just simply hate people posting error ... error ... on my topic, kinda spoiled my reputation

in msvc2010, sscanf will throw error, saying need to use s_sscanf

then if you use s_sscanf, then other members who are not using mscv will get an error ...

very annoying

but when calculate the string, everybody happy

all thoes s_xxxx.. annoying warnings in my plugin projects were disabled  by me , coz I hate thoes

Spoiler

1.

right click your plugin project--> choose properties--> configuration properties--> Preprocessor-->Preprocessor Definition -->edit

2. input the below two lines

_CRT_SECURE_NO_DEPRECATE

_SCL_SECURE_NO_DEPRECATE

Spoiler

3 push ok and apply button

Thank you Angel finally got rid of that annoying warnings.

 

[AnnieRuru]

all thoes s_xxxx.. annoying warnings in my plugin projects were disabled by me , coz I hate those

hmmm ~ nice ~ learn some thing newnow tell the whole world to remove that warning like your did ... not gonna happen

actually the problem is not on msvc ... can remind them to ignore it

its 'Debian GNU/Linux 6.0.5' that Hadeszeus using that was giving me headache

if you have a method that it doesn't throw error for Hadeszeus, I'm willingly to know too

but I'll probably stick to calculate the string

.

I'll be trying the released version for rathena svn soon.

make sense actuallywhile nobody in hercules forum willingly to convert this patch into rathena format

but its logical to ask someone over rathena forum to convert hercules patch into rathena

after all, we already have so many stuffs there was taken from rathena forum anyway

.

.

I just noticed a minor bug that

while you can't create a clone having a chat room open

but still can open a chat room after having a market clone

I should fix this or not ?

logical thinking, people are creating this clone and left it in town, so the player would be off questing in other maps

so I think should allow them so a clone is in town, while allow them to open a chat room inside a dungeon or something

 

[kyeme]

all thoes s_xxxx.. annoying warnings in my plugin projects were disabled by me , coz I hate those

hmmm ~ nice ~ learn some thing newnow tell the whole world to remove that warning like your did ... not gonna happen

actually the problem is not on msvc ... can remind them to ignore it

its 'Debian GNU/Linux 6.0.5' that Hadeszeus using that was giving me headache

if you have a method that it doesn't throw error for Hadeszeus, I'm willingly to know too

but I'll probably stick to calculate the string

.

>I'll be trying the released version for rathena svn soon.

make sense actuallywhile nobody in hercules forum willingly to convert this patch into rathena format

but its logical to ask someone over rathena forum to convert hercules patch into rathena

after all, we already have so many stuffs there was taken from rathena forum anyway

.

.

I just noticed a minor bug that

while you can't create a clone having a chat room open

but still can open a chat room after having a market clone

I should fix this or not ?

logical thinking, people are creating this clone and left it in town, so the player would be off questing in other maps

so I think should allow them so a clone is in town, while allow them to open a chat room inside a dungeon or something

Maybe make an option in player.conf?

 

[vBrenth]

omfg ... forgot to add pc-> symbol

EDIT- modify existing paste is very useful ...

after trying so many things i can't see anything wrong/bug so far.

 

[AnnieRuru]

Maybe make an option in player.conf?

people aren't saying it is a bug, so leave it then xD

 

[Hadeszeus]

Hmm.. i patch without error. I can create a clone but I can't kill it. 

@marketkill nothing happens (Only message that my clone was killed, but its not)

I logged out my clone still alive.

I can create multiple clone.

 

[AnnieRuru]

between version 1.1 and 1.2

I removed the lines in status_percent_change and applied them in 5 different killmonster functions

 

[vBrenth]

Hmm.. i patch without error. I can create a clone but I can't kill it. 

@marketkill nothing happens (Only message that my clone was killed, but its not)

I logged out my clone still alive.

I can create multiple clone.

Cant reproduce, i really suggest you guys use plugins >.> less stress.