Feefty's FluxCP Addons Release
- Thread starter Feefty
- Start date
- Status
Dinze
New member
- Messages
- 42
- Points
- 0
To anyone having an Unable to vote for the server. Err no. 4 error try this fix.
/modules/voteforpoints/index.php
Change
case "cash": // insert or update cashpoints $cashpoints_var = "#CASHPOINTS"; $sql = "UPDATE $cp_tbl SET value = value + ? WHERE key = ? AND account_id = ?"; $sth = $server->connection->getStatement($sql); $sth->execute(array((int) $res->votepoints, $cashpoints_var, $account_id)); // account doesn't have a record for cashpoints // so we will add a row if ( ! $sth->rowCount()) { $sql = "INSERT INTO $cp_tbl VALUES (0, ?, ?, 2, ?)"; $sth = $server->connection->getStatement($sql); $bind = array($cashpoints_var, $res->votepoints, $account_id); $sth->execute($bind); if ( ! $sth->rowCount()) $errorMessage = sprintf(Flux::message("UnableToVote"), 4); }break;
to
/modules/voteforpoints/index.php
Change
case "cash": // insert or update cashpoints $cashpoints_var = "#CASHPOINTS"; $sql = "UPDATE $cp_tbl SET value = value + ? WHERE key = ? AND account_id = ?"; $sth = $server->connection->getStatement($sql); $sth->execute(array((int) $res->votepoints, $cashpoints_var, $account_id)); // account doesn't have a record for cashpoints // so we will add a row if ( ! $sth->rowCount()) { $sql = "INSERT INTO $cp_tbl VALUES (0, ?, ?, 2, ?)"; $sth = $server->connection->getStatement($sql); $bind = array($cashpoints_var, $res->votepoints, $account_id); $sth->execute($bind); if ( ! $sth->rowCount()) $errorMessage = sprintf(Flux::message("UnableToVote"), 4); }break;
to
Code:
case "cash": // insert or update cashpoints $cashpoints_var = "#CASHPOINTS"; $sql = "UPDATE {$server->loginDatabase}.$cp_tbl SET `value` = value + ? WHERE `key` = ? AND `account_id` = ?"; $sth = $server->connection->getStatement($sql); $sth->execute(array($res->votepoints, $cashpoints_var, $account_id)); // account doesn't have a record for cashpoints // so we will add a row if ( ! $sth->rowCount()) { $sql = "INSERT INTO {$server->loginDatabase}.$cp_tbl VALUES(?,?,0,?)"; $sth = $server->connection->getStatement($sql); $sth->execute(array($account_id, $cashpoints_var, $res->votepoints)); if ( ! $sth->rowCount()) $errorMessage = sprintf(Flux::message("UnableToVote"), 4); }break;
Last edited by a moderator:
evilpuncker
vai se tratar garota
- Messages
- 2,178
- Points
- 0
- Age
- 109
- Location
- bronzil
- Github
- EPuncker
- Emulator
- Client Version
- 2019-05-30a MAIN
seems like feefty is away from RO community, what if we move those addons to git and start to get community to fix erros?
I'm not sure if there's a problem but Vote for Points has no option to exchange it to Cash/Kafra points in-game directly from the site even if it's already set in addons.php
Do you have an NPC script that changes vote points to cash?
jTynne
High Council
- Messages
- 249
- Points
- 0
- Emulator
Unfortunately still getting the same error, however, the points are at least applying! Thank you!
Last edited by a moderator:
Dinze
New member
- Messages
- 42
- Points
- 0
still getting the error.
Dinze
New member
- Messages
- 42
- Points
- 0
Here is a rather disgusting, but quick fix for those having problems with the support tickets module. Don't forget to backup your files before applying the following fixes.
Fix department list items appearing twice :
addons/support/modules/support/department.php
change :
<?php if (count($all_dep_res)): ?> <?php foreach ($all_dep_res as $row): ?> <option value='<?= (int) $row->id ?>'><?= htmlspecialchars($row->name) ?></option> <?php endforeach ?> <?php foreach ($all_dep_res as $row): ?> <option value='<?php echo (int) $row->id ?>'><?php echo htmlspecialchars($row->name) ?></option> <?php endforeach ?><?php endif ?>
to :
<?php if (count($all_dep_res)): ?> <?php foreach ($all_dep_res as $row): ?> <option value='<?php echo (int) $row->id ?>'><?php echo htmlspecialchars($row->name) ?></option> <?php endforeach ?><?php endif ?>
Fix addons/support/themes/defalut/support/list.php and addons/support/themes/defalut/support/view.php (Quick and dirty workaround for Flux::Config("ThemeName") not working with add-ons.
lib/Flux.php
change :
public static function config($key, $value = null, $options = array()){ if (!is_null($value)) { return self::$appConfig->set($key, $value, $options); } else { return self::$appConfig->get($key); }}
to :
public static function config($key, $value = null, $options = array()){ if (!is_null($value)) { return self::$appConfig->set($key, $value, $options); } // Disgusting hardcoded fix for Flux::Config("ThemeName") in addons else if ($key == "ThemeName") { return Flux::$sessionData->theme; } else { return self::$appConfig->get($key); }}
This fix is far from being satsfying because it's hardcoded and the issue will repeat with every application parameter passed as an array like ThemeName. I am not that good with PHP and I have actually no idea how to fix this without diving into the core of FluxCP. I'll edit my post if I come up with a better solution though.
06.08.2015 Edit :
I found another error in the support module and a way to fix it in the addon code (even though I suspect the problem comes from FluxCP itself
). The error (Trying to get property of non-object in [...]function.php line 306) happens when you try to log in with a wrong username/password. I didn't realize the problem until I turned debug mode on when I started working on an addon.
addons/support/modules/support/functions.php
change :
$group_col = getGroupCol($server);
to :
$group_col = getGroupCol($session->loginAthenaGroup);
06.14.2015 Edit :
Yet another bug, yet another ugly fix for support addon. This fixes the query errors in the ticket list pages happening depending on the current user AccountLevel.
addons/support/modules/list.php
change:
if ($sth->rowCount()){ $i = 0; foreach ($group_res as $row) { if ($i != 0) $sql .=" AND"; $sqlpartial .= " department != ?"; $bind[] = $row->id; $i++; }}
to:
if ($sth->rowCount()){ $sqlpartial = "WHERE"; $i = 0; foreach ($group_res as $row) { if ($i != 0) { $sqlpartial .=" AND"; } $sqlpartial .= " department != ?"; $bind[] = $row->id; $i++; }}
06.16.2015 Edit : Another one. Fix the error when clicking on a ticket to see the detail :
addons/support/modules/support/view.php
change :
$mail = new Flux_Mailer();
to:
$mail = @new Flux_Mailer();
Same fix applies to any other page affected by the issue.
Hope this helps! Also don't hesitate to correct me if you find a more proper (I know there are some) way to fix those issues! ^^
Fix department list items appearing twice :
addons/support/modules/support/department.php
change :
<?php if (count($all_dep_res)): ?> <?php foreach ($all_dep_res as $row): ?> <option value='<?= (int) $row->id ?>'><?= htmlspecialchars($row->name) ?></option> <?php endforeach ?> <?php foreach ($all_dep_res as $row): ?> <option value='<?php echo (int) $row->id ?>'><?php echo htmlspecialchars($row->name) ?></option> <?php endforeach ?><?php endif ?>
to :
<?php if (count($all_dep_res)): ?> <?php foreach ($all_dep_res as $row): ?> <option value='<?php echo (int) $row->id ?>'><?php echo htmlspecialchars($row->name) ?></option> <?php endforeach ?><?php endif ?>
Fix addons/support/themes/defalut/support/list.php and addons/support/themes/defalut/support/view.php (Quick and dirty workaround for Flux::Config("ThemeName") not working with add-ons.
lib/Flux.php
change :
public static function config($key, $value = null, $options = array()){ if (!is_null($value)) { return self::$appConfig->set($key, $value, $options); } else { return self::$appConfig->get($key); }}
to :
public static function config($key, $value = null, $options = array()){ if (!is_null($value)) { return self::$appConfig->set($key, $value, $options); } // Disgusting hardcoded fix for Flux::Config("ThemeName") in addons else if ($key == "ThemeName") { return Flux::$sessionData->theme; } else { return self::$appConfig->get($key); }}
This fix is far from being satsfying because it's hardcoded and the issue will repeat with every application parameter passed as an array like ThemeName. I am not that good with PHP and I have actually no idea how to fix this without diving into the core of FluxCP. I'll edit my post if I come up with a better solution though.
06.08.2015 Edit :
I found another error in the support module and a way to fix it in the addon code (even though I suspect the problem comes from FluxCP itself
addons/support/modules/support/functions.php
change :
$group_col = getGroupCol($server);
to :
$group_col = getGroupCol($session->loginAthenaGroup);
06.14.2015 Edit :
Yet another bug, yet another ugly fix for support addon. This fixes the query errors in the ticket list pages happening depending on the current user AccountLevel.
addons/support/modules/list.php
change:
if ($sth->rowCount()){ $i = 0; foreach ($group_res as $row) { if ($i != 0) $sql .=" AND"; $sqlpartial .= " department != ?"; $bind[] = $row->id; $i++; }}
to:
if ($sth->rowCount()){ $sqlpartial = "WHERE"; $i = 0; foreach ($group_res as $row) { if ($i != 0) { $sqlpartial .=" AND"; } $sqlpartial .= " department != ?"; $bind[] = $row->id; $i++; }}
06.16.2015 Edit : Another one. Fix the error when clicking on a ticket to see the detail :
addons/support/modules/support/view.php
change :
$mail = new Flux_Mailer();
to:
$mail = @new Flux_Mailer();
Same fix applies to any other page affected by the issue.
Hope this helps! Also don't hesitate to correct me if you find a more proper (I know there are some) way to fix those issues! ^^
Last edited by a moderator:
Mystery
Community Contributors
Topic will be closed. The author has been away from the community for awhile and all this topic gets is "this isn't working..." posts. If you are requesting support for a particular add on, create a support topic in the right section.
- Status