Add *getguildmember script command

[AnnieRuru]

com'on ... rathena added this ages ago ... and we still don't have ? why ?

http://rathena.org/board/topic/78308-getguildmember/?p=244554

any guild based event definitely need this command

don't have to use *query_sql anymore

prontera,152,187,5 script dsasda2 100,{.@nb = query_sql( "select name, online from `char` where guild_id = "+ getcharid(2), .@name$, .@online );for ( .@i = 0; .@i < .@nb; .@i++ )dispbottom .@i +". "+ .@name$[.@i] +" -> "+( ( .@online[.@i] )? "online" : "offline" );end;}

should be change into

prontera,150,187,5 script dsasda 100,{getguildmember getcharid(2), 0;getguildmember getcharid(2), 1;getguildmember getcharid(2), 2;for ( .@i = 0; .@i < $@guildmembercount; .@i++ )dispbottom .@i +". "+ $@guildmembername$[.@i] +" -> "+( ( isloggedin( $@guildmemberaid[.@i] , $@guildmembercid[.@i] ) )? "online" : "offline" );end;}

pull request => https://github.com/HerculesWS/Hercules/pull/335

 

[sbk_]

possible to add a command to add a member to guild?

 

[GmOcean]

rAthena recently added a whole slew of guild commands.

Config Updates:

• Changes 'emblem_woe_change' to '

disable_change_emblem' & added some options
[*]Added 'create_guild' to enable/disable guild creation by player.
[*]Added 'break_guild' to enable/disable break a guild by player.
[*]Added 'disable_invite' to enable/disable guild invitation by player.
[*]Added 'disable_expel' to enable/disable guild expulsion by player.

Script Command Updates

• Added '

guild_info' to retrieve specified guild information from a given guild (name or ID). The available info by type are:

• 0: If guild_id used, returns "guild name" or "" if not found. If "guild name" used, returns guild_id or -1 if not found
• 1: Returns a guild level
• 2: Returns a number of connected members
• 3: Returns a number of max members
• 4: Returns a number of average member level
• 5: Returns a number of allies number. Also

$@guildallies_id[] & $@guildallies_name$[] array for Ally IDs & Names
[*]6: Returns a number of enemy number. Also $@guildenemies_id[] & $@guildenemies_name$[] array for Enemy IDs & Names
[*]7: Returns a number of castles owned. Also $@guildcastles_id[] & $@guildcastles_name$[] array for Castle IDs & Names
[*]Added 'guild_create' to create a new guild. (Ignore 'create_guild' config value)
[*]Added 'guild_addmember' to add new member to a guild. (Ignore 'disable_invite' config value)
[*]Added 'guild_delmember' to remove/kick/expel a guild member from a guild. (Ignore 'guild_expel' config value)
[*]Added 'guild_changegm' to change guild master from a guild.
[*]Added 'guild_break' to break a guild. Like @breakguild or /breakguild, guild must be empty first. (Ignore 'break_guild' config value)

I'd personally like to see these added in as well. Along with the party versions of them as well. Especially the party ones, as they are very useful for creating parties to combine with instance type scripts. No longer having to check to see if they are in a party, just simply force them into one. You could even combine it with waitingroom commands to make forming instance parties easier.

But that's just my 2cents...I know we have the plugin for the party version, but it seems odd to not add something that could be so widely used to the main revision.

 

[AnnieRuru]

@GmOcean

I couldn't find those commands in rathena repo, but you mean this ?

http://rathena.org/board/topic/97728-

hercules developers has already rejected the party script commands

http://herc.ws/board/topic/4186-

reason 1

if you want to script party vs party script, its better to use battleground script commands provided

reason 2

if you saying its meant to create a party for instance

no, that's because rathena are forcing the instance to attach to party ID

that's why they need it when creating an instance for a single player

but remember hercules already has IOT_CHAR to attach the instance to account ID

we don't need it

since party script commands are rejected, guild script commands are going to be rejected as well

but this might be a nice addition as a plugin ... though

that guild info command seems interesting ...

0 - rejected - we have getguildname

1 - this is grey ... getguildlevel or getgdskilllv ? I dunno

2 - rejected - getguildmember can do this

3 - rejected - getguildmember can do this

4 - rejected - for what ??

5 - hmm ... useful when writing certain kinds of guild based event ...

6 - hmm ... useful when writing certain kinds of guild based event ...

7 - rejected - I saw his code ... iterator ... bad idea, its better to loop with getcastledata

overall ... no ...


@SoulBlaker

Ima thinking of convert Cydh's code into hercules plugin

 

[GmOcean]

Ahh lol. Hadn't known that. I just figured since official instances run with parties it'd be a step in the right direction to add them but okay lol. I have no qualms with adding another plugin =P.

Also, yeah sorry lol. I forgot to mention it's not 100% official commands, but that they were already created and I highly doubt they'll reject them.

 

[sbk_]

rAthena recently added a whole slew of guild commands.

Config Updates:

[*]Changes 'emblem_woe_change' to 'disable_change_emblem' & added some options

[*]

[*]Added 'create_guild' to enable/disable guild creation by player.

[*]

[*]Added 'break_guild' to enable/disable break a guild by player.

[*]

[*]Added 'disable_invite' to enable/disable guild invitation by player.

[*]

[*]Added 'disable_expel' to enable/disable guild expulsion by player.

[*]

Script Command Updates

[*]Added 'guild_info' to retrieve specified guild information from a given guild (name or ID). The available info by type are:

[*]0: If guild_id used, returns "guild name" or "" if not found. If "guild name" used, returns guild_id or -1 if not found

[*]

[*]1: Returns a guild level

[*]

[*]2: Returns a number of connected members

[*]

[*]3: Returns a number of max members

[*]

[*]4: Returns a number of average member level

[*]

[*]5: Returns a number of allies number. Also $@guildallies_id[] & $@guildallies_name$[] array for Ally IDs & Names

[*]

[*]6: Returns a number of enemy number. Also $@guildenemies_id[] & $@guildenemies_name$[] array for Enemy IDs & Names

[*]

[*]7: Returns a number of castles owned. Also $@guildcastles_id[] & $@guildcastles_name$[] array for Castle IDs & Names

[*]

[*]

[*]Added 'guild_create' to create a new guild. (Ignore 'create_guild' config value)

[*]

[*]Added 'guild_addmember' to add new member to a guild. (Ignore 'disable_invite' config value)

[*]

[*]Added 'guild_delmember' to remove/kick/expel a guild member from a guild. (Ignore 'guild_expel' config value)

[*]

[*]Added 'guild_changegm' to change guild master from a guild.

[*]

[*]Added 'guild_break' to break a guild. Like @breakguild or /breakguild, guild must be empty first. (Ignore 'break_guild' config value)

[*]

I'd personally like to see these added in as well. Along with the party versions of them as well. Especially the party ones, as they are very useful for creating parties to combine with instance type scripts. No longer having to check to see if they are in a party, just simply force them into one. You could even combine it with waitingroom commands to make forming instance parties easier.

But that's just my 2cents...I know we have the plugin for the party version, but it seems odd to not add something that could be so widely used to the main revision.

Hmmm, tank' you

@GmOcean

I couldn't find those commands in rathena repo, but you mean this ?

http://rathena.org/board/topic/97728-

hercules developers has already rejected the party script commands

http://herc.ws/board/topic/4186-

reason 1

if you want to script party vs party script, its better to use battleground script commands provided

reason 2

if you saying its meant to create a party for instance

no, that's because rathena are forcing the instance to attach to party ID

that's why they need it when creating an instance for a single player

but remember hercules already has IOT_CHAR to attach the instance to account ID

we don't need it

since party script commands are rejected, guild script commands are going to be rejected as well

but this might be a nice addition as a plugin ... though

that guild info command seems interesting ...

0 - rejected - we have getguildname

1 - this is grey ... getguildlevel or getgdskilllv ? I dunno

2 - rejected - getguildmember can do this

3 - rejected - getguildmember can do this

4 - rejected - for what ??

5 - hmm ... useful when writing certain kinds of guild based event ...

6 - hmm ... useful when writing certain kinds of guild based event ...

7 - rejected - I saw his code ... iterator ... bad idea, its better to loop with getcastledata

overall ... no ...


@SoulBlaker

Ima thinking of convert Cydh's code into hercules plugin

I have one here that I made for service requirements, the version is to brAthena.