Charms [Item gift effect while in inventory]

Litro

New member
Messages
365
Points
0
Age
33
Location
Prontera
Github
Litro
Emulator
I got this patch from rathena (attached below), i have patched it in my server (using herc emulator), can some one help me to make it like just one item will be in effect if there is more than one in inventory ?

Charms.txt

eA_Charms.txt

 

Attachments

Dastgir gave me a Plugin for this one.

U can ask him about it though

 
Last edited by a moderator:
http://upaste.me/f8b42118100b0bab2
^ This is as it is version, made months ago, there's no compile warnings/errors, but dont' know if it works or not with new rev,

How it works?

Add Following to item:

Charm: true
in item_db.conf in whichever item you want.

 
Last edited by a moderator:
hi sir, how about the main question if there is item marked charm in inventory and later on he got one again other item with different id (so there is 2 charm marked item) is will just one that will giving effect either the first one or the latter?

http://upaste.me/f8b42118100b0bab2
^ This is as it is version, made months ago, there's no compile warnings/errors, but dont' know if it works or not with new rev,

How it works?

Add Following to item:

Charm: true
in item_db.conf in whichever item you want.
and Thanks for this, the patch used by me giving memory dump when im closing or restarting the map server, i will try this one after removing my patch

 
1>c:usersbanhb_000desktopnewherculespluginscharm_system.c(13): fatal error C1083: Cannot open include file: 'common/HPMi.h': No such file or directory
Help, complie with vc 2010

Fixed!

Another error:

HPM:Addhook: unkown Hooking point 'status->calc_pc_additional'!

@@Dastgir help!

 
Last edited by a moderator:
Look like this code based on still not merged pull request

 
yes, read it few minutes ago, just may crash or something
default_sad.png
@@Dastgir, what can i do now?

 
Last edited by a moderator:
Look like this code based on still not merged pull request
Hmm.. Yup, I think that's why I didn't released it.. And i forgot.I think I manually merged that PR in @@karazu server and then given this plugin.

 
@@Dastgir, so how about your pull request, did you test it? is it ok? if yes i will merge manually :3

Thank you!

 
Last edited by a moderator:
Tested!

It work but bonus appear only when character log out and log in, change map

drop item from inventory effect do not disappear, @@Dastgir

 
Using @Dastgir's updated charms.c plugin found in his Github (Apr 29 2017), I was able to test it and it seems to be working fine on my build.

Dropping the item from my inventory results to the effects (+1 STR in my case) to disappear. Picking the item up returns the effect. The command @itemreset removes the effect as well.

I do however, experience a warning when I build on a unix-based (Ubuntu) system. The warnings showed up when I executed the command:

make clean && make all


Warnings

dastgir.PNG

Despite the warning, the effects seem to be fine and I am currently having no problems whatsoever.

 
Back
Top