Double Attack critic damage

[fakezinhu666]

On official servers, DA and other skills can inflict critical damage, will it ever be fixed in Hercules? in rAthena it already works this way.

 

[X-EcutiOnner]

if you need to testing can see my pr
https://github.com/HerculesWS/Hercules/pull/2609

 

[fakezinhu666]

thanks, i'm going to test.

 

[fakezinhu666]

thanks, i'm going to test and give you feedback

if you need to testing can see my pr
https://github.com/HerculesWS/Hercules/pull/2609

Edit:

So, those are the problems I found:

1: Can only trigger a double attack if proc a crit first. as shown by the video below, if you have low / no critical rate, you won't activate a double attack. the expected behavior is that crit rate doesn't influence the chance of trigger a double attack, but whenever activating a DA, it should be a critical hit.

To view this content we will need your consent to set third party cookies.
For more detailed information, see our cookies page.

Accept third party cookies

 

[X-EcutiOnner]

This is initial release not complete yet and i'm not continue for it. Sorry Bro.