Hercules Battlegrounds

astralprojection said:
im getting this error on latest Herc
 

hBG.c: In function ‘hBG_addflooritem_area’:
hBG.c:1950:3: error: too few arguments to function ‘map->addflooritem’
count += (map->addflooritem(bl, &item_tmp, 1, m, mx, my, 0, 0, 0, 4) != 0) ? 1 : 0;
Click to expand...

same here, look like another emulator update cause this problem.

 
i figure it out, just change to

count += (map->addflooritem(bl, &item_tmp, 1, m, mx, my, 0, 0, 0, 4, false) != 0) ? 1 : 0;

Asheraf committed 26 days ago  Add support for new drop packet 0xadd for zero clients 

 
@Smoke

how can i fix this?

7H4WOXU.jpg


in the end the message does not show in proper language.

 
@Myriad i tested this, but not work

btw on GM char i can see message clearly

Also it seem ip check function not working

hBG_ip_check: 1

 
@Smoke @LucasBrito can u revert BG emblem update?

because in newer client guild emblem does not show in BG map or require EnbleBGEmblem patch which has alignment problems.

better show battleground emblem at top of players head than show nothing. User can easily remove BG sword emblem by making them transparent.

Also if possible please check IP_check function, because it is not working.

 
caspe said:
@Smoke @LucasBrito can u revert BG emblem update?

because in newer client guild emblem does not show in BG map or require EnbleBGEmblem patch which has alignment problems.

better show battleground emblem at top of players head than show nothing. User can easily remove BG sword emblem by making them transparent.

Also if possible please check IP_check function, because it is not working.
Click to expand...
Just installed this plugin, wanted to try it out. I'm unsure what it was like before, but seems the BG Guild Emblems are not displaying correctly.
https://github.com/Smokexyz/HerculesBG/issues/39

@caspe it would be better to include #if PACKETVER <= clientver, replacing clientver with the last known compatible one. I'm not familiar with this plugin, but I guess it would be this part?
 

/* Display emblem on head of char [lucaslsb] */
#if PACKETVER <= 20141022
if (hBG_enabled && sd->state.changemap && map->list[sd->bl.m].flag.battleground)
clif->map_type(sd, MAPTYPE_BATTLEFIELD);
if (hBG_enabled && map->list[sd->bl.m].flag.battleground)
clif->map_property(sd, MAPPROPERTY_AGITZONE);
#endif


and then,

// clif interface overloading [lucaslsb]
#if PACKETVER <= 20141022
clif->sendbgemblem_area = clif_sendbgemblem_area_overloading;
clif->sendbgemblem_single = clif_sendbgemblem_single_overloading;
#endif


but after testing, it seems this is pointless, as the newer clients show the emblems just fine (read below). Better to add a config for whether you'd rather show the sword or not.

 ALSO your alignment issue is not exclusive to guild emblems. It's to do with the zoom in/out of your client. It can happen with some headgears to, such as ugly ass wings.

Exhibit A, zoomed in.
mElvGh5.png


Exhibit B, zoomed to an appropriate amount.
HWLLYMY.png


 
Last edited by a moderator:
Is this plugin stable?

The BG emblem is show properly in what client versions? 

Thanks in Advance .

 
@Myriad Thanks for reply

Tested with 2015-10-29aRagexe client and emblem show property with enablebgemblem patch, no need to revert BG emblem changes.

Need to check other problem's.  :blush:

@Stupidity Use 2015-10-29aRagexe or 2012 client

 
IP_check function function working but it still allow 2 same ip user's to connect

it block 3rd user from joining BG

 
compile warning on Ubuntu

hBG.c: In function ‘atcommand_reportafk’:
hBG.c:2040:31: warning: unused variable ‘hBGsd’ [-Wunused-variable]
  struct hBG_map_session_data *hBGsd = NULL;
                               ^
hBG.c: In function ‘atcommand_leader’:
hBG.c:2084:31: warning: unused variable ‘hBGsd’ [-Wunused-variable]
  struct hBG_map_session_data *hBGsd = NULL;
                               ^
hBG.c: In function ‘status_get_guild_id_pre’:
hBG.c:3776:31: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
   && (bg_id = bg->team_get_id((struct block_list *)*bl)) > 0
                               ^
hBG.c: In function ‘status_get_emblem_id_pre’:
hBG.c:3797:31: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
   && (bg_id = bg->team_get_id((struct block_list *)(*bl))) > 0
                               ^
hBG.c: In function ‘char_bgstats_tosql’:
hBG.c:4242:4: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘unsigned int’ [-Wformat=]
    "REPLACE INTO `char_bg_stats` ("
    ^
hBG.c: In function ‘hBG_build_guild_data’:
hBG.c:1719:4: warning: ignoring return value of ‘fread’, declared with attribute warn_unused_result [-Wunused-result]
    fread(&bg_guild[j].emblem_data, 1, bg_guild[j].emblem_len, fp);
 

 
@Smoke this plugin having lot's of issue on ubuntu,

@Myriad i'm getting emblem problem, which u have mentioned

Also players need to use Shift to hit players.

I was testing this plugin on windows 7 & using visual studio to compile, now after adding it to the server which is hosted on Ubuntu.

many problem's start occurring.

OR can anyone tell me how should i build this plugin on Ubuntu? i'm using make plugins command

 
BG guild data not updating properly, if player was already in guild it shows position list of it's own guild, if player is not on any guild it shows blank.

Look like Guild skills also having same issue conflicting with previous guild skills and crashing server.  

Also some times BG mode's get conflicted with each other (like running 2-3 Mode at once).

This is a best & useful plugin but still not ready for live server, it need lot's of improvements and fixes.

 
Some serious Bugs

1. BG mode automatically changing, like running CTF Mode then for some reason Triple Inferno also start but CTF Mode was not ended also player stay on CTF map & BG start announcing Inferno statistics.

Ue3c88n.jpg


(look like it is happening because of Battle Recruiter NPC)

2. hBG_balanced_queue not working, when 6 players join BG, many time it recall only 3-4 player's.

VJlBj3d.jpg


3. Guild Skill not working properly, many time Emergency Call crash server.

@Smoke @Myriad @LucasBrito

 
Last edited by a moderator:
7j92OXl.jpg


Sometimes when some one join BG, it announce many time.

using 2015-10-29aRagexe client

 
You must log in or register to reply here.
Back
Top