Items Serial Number

[hemagx]

Hello,

Why not Hercules implement items serial number it's really important for lot things and officail ( exist in Aegis ) ?

:3

 

[Angelmelody]

src/config/core.h

/// Uncomment to enable Non Stackable items unique ID
/// By enabling it, the system will create an unique id for each new non stackable item created
//#define NSI_UNIQUE_ID

 

[jaBote]

If it's on official servers, it should be enabled by default in my opinion...

 

[quesoph]

^ I agree.

@ot

Why does that awesome feature disabled anyway?

 

[hemagx]

src/config/core.h

/// Uncomment to enable Non Stackable items unique ID

/// By enabling it, the system will create an unique id for each new non stackable item created

//#define NSI_UNIQUE_ID

if you check it's from rAthena and it status Started so seems like that code not totally finished + i think it's not give serial number for old items aleardy server have ?

If it's on official servers, it should be enabled by default in my opinion...

yea , and finished XD

^ I agree.

@ot

Why does that awesome feature disabled anyway?

maybe coz it status started not finished and this code from rA

 

[hemagx]

Bump

 

[Ind]

The implementation present in hercules doesn't match the official as Yommy, Beret and hemagx have demonstrated in previous occasions. For example the current implementation does so only to non-stackable items, officially there is the option to do so to stackable items e.g. potions (would create a new stack for the serialised ones) besides the ability to disable or enable the feature on specific items.

 

[Beret]

When you add support for all items, could add the item log as the aegis.

CREATE TABLE [dbo].[itemLog](	[index] [int] IDENTITY(1,1) NOT NULL,	[Ver] [int] NULL,	[SID] [int] NULL,	[Action] [int] NULL,	[logtime] [datetime] NULL,	[ip] [varchar](20) NULL,	[eventx] [int] NULL,	[eventy] [int] NULL,	[srcAccountID] [int] NULL,	[srcAccountName] [varchar](24) NULL,	[srcCharID] [int] NULL,	[srcCharName] [varchar](24) NULL,	[srcJobType] [int] NULL,	[srcLevel] [int] NULL,	[desAccountID] [int] NULL,	[desAccountName] [varchar](24) NULL,	[desCharID] [int] NULL,	[desCharName] [varchar](24) NULL,	[Serialcode] [bigint] NULL,	[ItemName] [varchar](24) NULL,	[ItemID] [int] NULL,	[ItemCount] [int] NULL,	[MapName] [varchar](24) NULL,	[price] [int] NULL,	[slot1] [int] NULL,	[slot2] [int] NULL,	[slot3] [int] NULL,	[slot4] [int] NULL,	[refiningLevel] [int] NULL,	[AuctionID] [int] NULL,	[ItemBuyCash] [int] NULL,	[Zeny] [int] NULL,	[DestZeny] [int] NULL,	[ItemHireExpireDate] [datetime] NULL,	[bizType] [int] NULL,	[identity] [bigint] NOT NULL, CONSTRAINT [PK_itemLog] PRIMARY KEY CLUSTERED

 

[hemagx]

When you add support for all items, could add the item log as the aegis.

CREATE TABLE [dbo].[itemLog]( [index] [int] IDENTITY(1,1) NOT NULL, [Ver] [int] NULL, [SID] [int] NULL, [Action] [int] NULL, [logtime] [datetime] NULL, [ip] [varchar](20) NULL, [eventx] [int] NULL, [eventy] [int] NULL, [srcAccountID] [int] NULL, [srcAccountName] [varchar](24) NULL, [srcCharID] [int] NULL, [srcCharName] [varchar](24) NULL, [srcJobType] [int] NULL, [srcLevel] [int] NULL, [desAccountID] [int] NULL, [desAccountName] [varchar](24) NULL, [desCharID] [int] NULL, [desCharName] [varchar](24) NULL, [Serialcode] [bigint] NULL, [ItemName] [varchar](24) NULL, [ItemID] [int] NULL, [ItemCount] [int] NULL, [MapName] [varchar](24) NULL, [price] [int] NULL, [slot1] [int] NULL, [slot2] [int] NULL, [slot3] [int] NULL, [slot4] [int] NULL, [refiningLevel] [int] NULL, [AuctionID] [int] NULL, [ItemBuyCash] [int] NULL, [Zeny] [int] NULL, [DestZeny] [int] NULL, [ItemHireExpireDate] [datetime] NULL, [bizType] [int] NULL, [identity] [bigint] NOT NULL, CONSTRAINT [PK_itemLog] PRIMARY KEY CLUSTERED

+1

it's more useful than Hercules one.

 

[Dramosith]

When you add support for all items, could add the item log as the aegis.

CREATE TABLE [dbo].[itemLog]( [index] [int] IDENTITY(1,1) NOT NULL, [Ver] [int] NULL, [SID] [int] NULL, [Action] [int] NULL, [logtime] [datetime] NULL, [ip] [varchar](20) NULL, [eventx] [int] NULL, [eventy] [int] NULL, [srcAccountID] [int] NULL, [srcAccountName] [varchar](24) NULL, [srcCharID] [int] NULL, [srcCharName] [varchar](24) NULL, [srcJobType] [int] NULL, [srcLevel] [int] NULL, [desAccountID] [int] NULL, [desAccountName] [varchar](24) NULL, [desCharID] [int] NULL, [desCharName] [varchar](24) NULL, [Serialcode] [bigint] NULL, [ItemName] [varchar](24) NULL, [ItemID] [int] NULL, [ItemCount] [int] NULL, [MapName] [varchar](24) NULL, [price] [int] NULL, [slot1] [int] NULL, [slot2] [int] NULL, [slot3] [int] NULL, [slot4] [int] NULL, [refiningLevel] [int] NULL, [AuctionID] [int] NULL, [ItemBuyCash] [int] NULL, [Zeny] [int] NULL, [DestZeny] [int] NULL, [ItemHireExpireDate] [datetime] NULL, [bizType] [int] NULL, [identity] [bigint] NOT NULL, CONSTRAINT [PK_itemLog] PRIMARY KEY CLUSTERED

+1!!!!!