Mercenary_Rent

[Darius Trevor]

Hello everybody.

I am having this error in the mercenary_rent.txt script is something strange for me that I have never had this error.
I would like to ask for this help so I can solve it and if someone else also has the same error, solve it too.
Thanks in advance.
The error is below.


[Error]: script:getd: `SPEAR_MERC_GUILD` is already used by something that is not a variable.
[Debug]: Source (NPC): Mercenary Manager#Spear at prontera (41,337)

It happens with the three variables


setarray .@faith$,     "SPEAR_MERC_GUILD",    "SWORD_MERC_GUILD",    "ARCH_MERC_GUILD";

 

[Dastgir]

@meko

 

[meko]

ARCH_MERC_GUILD, SPEAR_MERC_GUILD and SWORD_MERC_GUILD are hardcoded constants, so you cannot use them as variable

Instead of doing something like this to get their values:

setarray(.@faith$, "SPEAR_MERC_GUILD", "SWORD_MERC_GUILD", "ARCH_MERC_GUILD");

...

getd(.@faith$[1])


Just use the plain constants:

setarray(.@faith, SPEAR_MERC_GUILD, SWORD_MERC_GUILD, ARCH_MERC_GUILD);

...

.@faith[1]

 

[4144]

hm, but getd should not return errors for constants too

 

[meko]

@Darius Trevor This is fixed in https://github.com/HerculesWS/Hercules/pull/2240

but please use constants directly instead of using getd

 

[Darius Trevor]

@Darius Trevor This is fixed in https://github.com/HerculesWS/Hercules/pull/2240

but please use constants directly instead of using getd

Right.

But I did not use anything, the script in question is native to the emulator, thank you anyway.

 

[meko]

wow that's quite awkward then; we should definitely get rid of it

I'll open a PR to remove useless usages of getd