Special Shop[Implement it in Hercules.]

[Dastgir]

Reference topic : http://rathena.org/board/topic/84169-specialty-shops/

Pull Request : https://github.com/HerculesWS/Hercules/pull/232 (Tested it out, and its working.) 

Diff File: SpecialShop_v1.2.diff (In case someone want to use it early/dev rejected it.)

I have tested this source, and it works fine, anyone who wants to try can test it.

Spoiler

I wold like to suggest 2 new shop types (similar to cashshop)
 
1st being itemshop
Example:

<map name>,<x>,<y>,<facing> itemshop <NPC Name> <sprite id>,<costitem>,<itemid>:<price>{,<itemid>:<price>...}this would work just like a shop but would of course check for item defined in script
 
 
 
2nd would be more of a replacement to cashshop
Example:
 

<map name>,<x>,<y>,<facing>    pointshop	<NPC Name>	<sprite id>,<"points">,<itemid>:<price>{,<itemid>:<price>...} 

 
this could use any player or account bound point types such as #CashPoints or PvpPoints, as defined in script
 
 
 
Now i know how to add these without any source changes I've done it a thousand times, I'm suggesting we eliminate alot of the complexity of those script types.
 
Thoughts?

Although in cashshop rearrangement, we would like if format is this

<map name>,<x>,<y>,<facing>   pointshop <NPC Name> <sprite id>,<"points">,<"description">,<itemid>:<price>{,<itemid>:<price>...} 
Where description is the name of point put, like if variable if PkP and description is PvP Points.
Then when we open shop it will show in chat box (not npc dialog box), that "This shop uses PvP Points for purchasing items. Current PvP Points:123"
 

 

[Thunderbolt]

+1

 

[Dastgir]

I am done with testing the shops.

Updated : http://herc.ws/board/files/file/6-special-shop/ (Will have to wait till moderator approve it)

Diff File: SpecialShop_v1.2.diff

 

[Jedzkie]

+1, hope it will add to the repo.

 

[Lanz]

+1 for this...

 

[Mhalicot]

@offtopic

You guys don't know the meaning of +1 don't  you?

That means you will give +1 Reputation on the post/topic. as I can see that 3 of you gave a +1 to Mr DP but you ddnt gave him reputation.

@TS

Real +1 for this

I want to suggest. Can you make it like cashshop interface? see attachment.

 

[Jezu]

Try to buy without cash points on your character and test if this will work. I just have this long time ago by request and made by dastgir.. it gives me error when buying without cash points on account.

 

[Dastgir]

Try to buy without cash points on your character and test if this will work. I just have this long time ago by request and made by dastgir.. it gives me error when buying without cash points on account.

@Jezu:

It already works, (sevenzz meant to tell that if I can make this shop work with cashshop interface instead of normal shop interface)

This is new source, and doesn't give error(well I tested it personally many times),

It cannot be pulled to repo(Since Hercules is already working in something like this), so I will just make a patch of this in download section.

Thanks.

 

[evilpuncker]

+1 for a patch at download section

nice code but I don't think it suits the emulator to come by default

 

[Dastgir]

Ind reply to pull request (https://github.com/HerculesWS/Hercules/pull/232)

Hello. We thank you for your wish to contribute and support, however such a feature has already been prepared in 438aec4 (its just waiting for the remainder of the branch to be complete)
 (438aec4)

@Moderators, You can close this thread.

Download Link(if anyone want to use it):

http://herc.ws/board/topic/638-special-shop/