Official drop Announcement

[kyeme]

Please implement the rare_drop announcement like from official

// Make broadcast ** Player1 won Pupa's Pupa Card (chance 0.01%) ***// This can be set to any value between 0~10000.// Note: It also announces STEAL skill usage with rare items// 0 = don't show announces at all// 1 = show announces for 0.01% drop chance items// 333 = show announces for 3.33% or lower drop chance items// 10000 = show announces for all items
Remove:

messages.conf

541: '%s' got %s's %s (chance: %0.02f%%)
Implement:

msgtringtable at line 1629

pRO 

Citizens of Midgard, Lady Luck shines upon [%s] !! [%s] has awarded the player with '%s' !!#
or iRO:

[%s] has won [%s] from '%s'.#

 

[Mystery]

Isn't those announcements used for the package items? https://github.com/HerculesWS/Hercules/blob/master/db/re/item_packages.conf

By setting Announce: True you should get that similar broadcast from what I've seen in previous SS's of peoples

 

[kyeme]

Isn't those announcements used for the package items? https://github.com/HerculesWS/Hercules/blob/master/db/re/item_packages.conf

By setting Announce: True you should get that similar broadcast from what I've seen in previous SS's of peoples

The line 1629 of msgtringtable was used by item package (implemented) and rare_drop item (not yet implemented here @hercu)

 

[jaBote]

Well, message no 541 has always been difficult to translate maintaining all the placeholders in that order because of the saxon genitive, since it artificially changes the message order.

I'd highly prefer any of those messages you just proposed mainly because of that, letting aside the fact that they're official.

 

[Beret]

This is why the packet of hercules is not complete.

// packet: 0x7fd// Note: Wery Strange Packet, one of a kind with variable inner structstruct PACKET_ZC_BROADCASTING_SPECIAL_ITEM_OBTAIN {  /* this+0x0 */ short PacketType  /* this+0x2 */ short PacketLength  /* this+0x4 */ unsigned char type {    TYPE_BOXITEM =  0x0,    TYPE_MONSTER_ITEM =  0x1,  }  /* this+0x5 */ unsigned short ItemID  /* this+0x7 */ struct VarString Holder { // related to MSI_BROADCASTING_SPECIAL_ITEM_OBTAIN = 0x65c    /* this+0x0 */ char len    /* this+0x1 */ char Name[...]  }  if (packet.type == TYPE_BOXITEM) {    /* this+0x... */ unsigned short BoxItemID  } else if (packet.type == TYPE_MONSTER_ITEM) {    /* this+0x... */ struct VarString Monster {      /* this+0x0 */ char len      /* this+0x1 */ char Name[...]    }  }}

 

[evilpuncker]

we need this

 

[kyeme]

Up~

 

[Ind]

This was implemented some time ago (not sure when; would reference the commit otherwise)

/* heres the thing we got the feature set up however we're still discussing how to best define the ids, * so while we discuss, for a small period of time, the list is hardcoded (yes officially only those 2 use it, * thus why we're unsure on how to best place the setting) */ /* temp, will not be hardcoded for long thudu. */ if( it->nameid == 7782 || it->nameid == 7783 ) /* for when not hardcoded: add a check on mvp bonus drop as well */ clif->item_drop_announce(mvp_sd, it->nameid, md->name);its missing a criteria (or source/file) to determine what items are to be announced when dropped -- currently only those 2 are there because in the aegis file only those 2 are in it.I'll be moving it into the dev discussion forum

 

[tararais]

what happened with this?