check item before opening attach shop

[xienne15 5]

im using this dynamic shop by emistry, but i tried to use goto function after each cases so it will go to

if (countitem(26130) < 0) goto noring;noring:

but its giving me error

// Settings ://	-	Only required to edit the ShopSetting() Function//			Notes : You may also add / remove Menu ( If any ) //	-	Shop Currency can be either ItemID or Variable Name, but must write within Quotation Marks ( "" )//			Ex. of Variable.	->	Zeny , #CASHPOINTS , #KAFRAPOINTS , CustomVariable , #CustomVariable//	-	ERROR Message are used to show Invalid Settings in your NPC.// Leave this alone...-	shop	Emistry_Shop	-1,512:100bif_fild01,125,15,4	script	Training Trader	672,{function ShopSettings;function ValidateCost;function CurrencyInfo;function ClearData;function ValueConvert;function ErrorNotice;mes "[Training Trader]";mes "Hello~ I sell exclusive items using ^FF0000Training Points^000000.";next;mes "[Training Trader]";mes "Each shop use different training points acquired from your training";next;mes "[Training Trader]";mes "So use it well.~";mes "So,Which shop you would like to look at?";next;// Menu Selectionselect("Jump Training Shop","Other Training Shop");ClearData();ShopSettings( @menu );npcshopitem "Emistry_Shop",512,100;npcshopdelitem "Emistry_Shop",512;for(set .@i,0; .@i < getarraysize( @ItemLists ); set .@i,.@i+1)	npcshopadditem "Emistry_Shop",@ItemLists[.@i],@ItemCost[.@i];mes "Okay...wait awhile";mes "^00FF00____________________________^000000";CurrencyInfo( @Currency$ );mes "^00FF00____________________________^000000";callshop "Emistry_Shop",1;npcshopattach "Emistry_Shop";end;function	ShopSettings	{	switch( getarg(0) ){		Case 1:			if (countitem(26130) < 0) goto noring;			// Currency [ Item ID / Variable Name ]			set @Currency$,"JUMPPOINTS";			// Item ID Lists			setarray @ItemLists[0],12315,12303;			// Item Price			setarray @ItemCost[0],2500,1000;			break;		Case 2:			if (countitem(26131) < 0) { goto noring;			// Currency [ Item ID / Variable Name ]			set @Currency$,"OTHERPOINTS";			// Item ID Lists			setarray @ItemLists[0],12315,12303;			// Item Price			setarray @ItemCost[0],25,1;			break;		// Case 4,5,6.....etc...		default:			ErrorNotice( "Invalid Menu Selection for Menu "+@menu+"." );			close;}	if( @Currency$ == "" )	ErrorNotice( "Invalid Currency Setting in Menu "+@menu+" ." );if( getarraysize( @ItemCost ) != getarraysize( @ItemLists ) || getarraysize( @ItemLists ) != getarraysize( @ItemCost ) )	ErrorNotice( "Missing or Extra Value of Item or Cost Settings in Menu "+@menu+" ." );return;}function	ErrorNotice	{	mes "^FF0000ERROR^000000 - "+getarg(0);	mes "^00FF00____________________________^000000";	mes "Inform this Message to ^0000FFGame Staffs^000000 immediately !";	close;}function	CurrencyInfo	{	if( getitemname( atoi( getarg(0) ) ) != "null" ){		mes "Item Currency : ^FF0000"+getitemname( atoi( getarg(0) ) )+"^000000";		mes "Available Amount : ^0000FF"+ValueConvert( countitem( atoi( getarg(0) ) ) )+"^000000";	}else if( getitemname( atoi( getarg(0) ) ) == "null" ){		mes "Variable Currency : ^FF0000"+getarg(0)+"^000000";		mes "Available Amount : ^0000FF"+ValueConvert( getd( getarg(0) ) )+"^000000";	}return;}function	ValidateCost	{	if( getitemname( atoi( getarg(0) ) ) != "null" ){		if( countitem( atoi( getarg(0) ) ) < getarg(1) ) return 1;	}else{		if( getd( getarg(0) ) < getarg(1) ) return 1;	}return 0;}function ClearData	{	set @Currency$,"";	set @TotalCost,0;	deletearray @bought_nameid[0],getarraysize( @bought_nameid );	deletearray @bought_quantity[0],getarraysize( @bought_quantity );	deletearray @ItemLists[0],getarraysize( @ItemLists );	deletearray @ItemCost[0],getarraysize( @ItemCost );return;}function	ValueConvert	{	set .@num, atoi(""+getarg(0));	if ( .@num == 0 || .@num >= 2147483647 ) return getarg(0);	set .@l, getstrlen(""+.@num);	for ( set .@i,0; .@i < .@l; set .@i, .@i + 1 ) {		set .@num$, .@num % pow(10,.@i+1) / pow(10,.@i) + .@num$;			if ( (.@i+1) % 3 == 0 && .@i+1 != .@l ) set .@num$, ","+ .@num$;	}	return .@num$;}OnBuyItem:	ShopSettings( @menu );	for(set @i,0; @i < getarraysize( @bought_nameid ); set @i,@i+1)		for(set @j,0; @j < getarraysize( @ItemLists ); set @j,@j+1)			if( @ItemLists[@j] == @bought_nameid[@i] )			set @TotalCost,@TotalCost + ( @ItemCost[@j] * @bought_quantity[@i] );	mes "^FF0000       BILLING LIST^000000";	mes "^00FF00____________________________^000000";	for( set @i,0; @i < getarraysize( @bought_nameid ); set @i,@i+1 )			mes "^FF0000"+@bought_quantity[@i]+" x ^0000FF"+getitemname( @bought_nameid[@i] )+"^000000";	mes "^00FF00____________________________^000000";	if( getitemname( atoi( @Currency$ ) ) != "null" )		mes "Total Cost : ^0000FF"+ValueConvert( @TotalCost )+" x "+getitemname( atoi( @Currency$ ) )+"^000000";	else if( getitemname( atoi( @Currency$ ) ) == "null" ){		mes "Total Cost : ^0000FF"+ValueConvert( @TotalCost )+" "+@Currency$+"^000000";	}		mes "^00FF00____________________________^000000";	if( ValidateCost( @Currency$,@TotalCost ) ){		if( getitemname( atoi( @Currency$ ) ) != "null" )			mes "[ ^FF0000X^000000 ] Insufficient ^0000FF"+getitemname( atoi( @Currency$ ) )+"^000000";		else{			mes "[ ^FF0000X^000000 ] Insufficient ^0000FF"+@Currency$+"^000000";		}	}else{		if( select( "^0000FFPurchase^000000:Cancel" ) == 1 ){			if( getitemname( atoi( @Currency$ ) ) != "null" )				delitem atoi( @Currency$ ),@TotalCost;			else{				set getd( @Currency$ ),getd( @Currency$ ) - @TotalCost;			}			for(set @i,0; @i < getarraysize( @bought_nameid ); set @i,@i+1)				getitem @bought_nameid[@i],@bought_quantity[@i];			message strcharinfo(0),"Purchased "+getarraysize( @bought_nameid )+" Items.";			mes "Thank you for shopping.";		}	}ClearData();close;}noring:mes "[Training Trader]";mes "I'm so sorry but you need to finish the course and show me the ring from your mastered training,";mes "in order for you to open this shop.";emotion e_sry;close;	}

Edited August 3, 2013 by xienne15

[Mumbles 193]

Your left curly on line 61 is mismatched. It shouldn't even be there. Also, you're checking if the player has -1 of the item 26131; I think it's safe to assume you meant to check if the player had at least 1 of the item.

 

 

if (countitem(26131) < 0) { goto noring;

 

I could rant about why you shouldn't use goto, but to put it simply: it's just bad code - and wasn't used properly, at that. You can't (or shouldn't, if for some reason you can) use a goto within a function.

 

Instead, remove the checks from each case and place it outside of the function call. I added the check after line 26, before the player is given the shop menu selection. You can replace the contents of the check's script with what you had in your noring label.

 

 

mes "[Training Trader]";mes "Each shop use different training points acquired from your training";next;    // <- Line 26 [Via] .@coin = 26131;    // Coin item ID.@amount = 1;	  // Amount required // Check coinsif (countitem(.@coin) < .@amount) {    mes "[Training Trader]";    mes "You need at least "+ .@amount +" "+ getitemname(.@coin) +" to access these shops. Come back later.";    close;}

[xienne15 5]

Your left curly on line 61 is mismatched. It shouldn't even be there. Also, you're checking if the player has -1 of the item 26131; I think it's safe to assume you meant to check if the player had at least 1 of the item.

 

 

 

if (countitem(26131) < 0) { goto noring;

 

I could rant about why you shouldn't use goto, but to put it simply: it's just bad code - and wasn't used properly, at that. You can't (or shouldn't, if for some reason you can) use a goto within a function.

 

Instead, remove the checks from each case and place it outside of the function call. I added the check after line 26, before the player is given the shop menu selection. You can replace the contents of the check's script with what you had in your noring label.

 

 

mes "[Training Trader]";mes "Each shop use different training points acquired from your training";next;    // <- Line 26 [Via] .@coin = 26131;    // Coin item ID.@amount = 1;	  // Amount required // Check coinsif (countitem(.@coin) < .@amount) {    mes "[Training Trader]";    mes "You need at least "+ .@amount +" "+ getitemname(.@coin) +" to access these shops. Come back later.";    close;}

 

 

i will not use goto now LOL