Player bonus formula - Renewal

[dimensaoro 0]

Hello everybody, I'm new here.

My emulator is still Cronus, based in Hercules.

But if I can not resolve this issue I will use the Hercules, I'm avoiding because my server is already online.

 

According to my tests, all server bonuses are reduced 55.2 times (probably a mistake when configuring the formula for renewal, because in the same emulator, emulating in pre-renewal this error not happen).

 

Ex: General Turtle Card, +20% attack. Is giving at the time only +0,36% attack.

 

Ex: Fire elemental converter, attacking a plant monster. The bonus should be 100%, but being of +1.81%.

 

This error too happening with swords, spear, and all equipments, but only attacking monsters or players.

 

Please can someone help me ?!

 

[malufett 247]

 

Ex: General Turtle Card, +20% attack. Is giving at the time only +0,36% attack.

 

Ex: Fire elemental converter, attacking a plant monster. The bonus should be 100%, but being of +1.81%.

 

This error too happening with swords, spear, and all equipments, but only attacking monsters or players.

what emu does this happen?

 

[dimensaoro 0]

 

 

Ex: General Turtle Card, +20% attack. Is giving at the time only +0,36% attack.

 

Ex: Fire elemental converter, attacking a plant monster. The bonus should be 100%, but being of +1.81%.

 

This error too happening with swords, spear, and all equipments, but only attacking monsters or players.

what emu does this happen?

 

 

Hello malufett.

In The latest version of Cronus. But support them is horrible. And as Cronus is based on Hercules maybe someone can help me. =)

[malufett 247]

ow...I tried to peek on it...it seems they already have renewal system based on Hercules..but I'm not sure if its on the latest..

 

anyway I'll just show you why you got those results..

RE ATK FORMULA = BaseATK + WeaponATK + MASTERIES

 

 

 

Ex: General Turtle Card, +20% attack. Is giving at the time only +0,36% attack.

GTC boost only the WeaponATK part of the formula..

so..

ATK = BaseATK(150) + WeaponATK(100+20%) + MASTERIES(10)Therefore from 260 it boost up to 280 instead of 312 as you expected...This is also the same with elemental mods..

[dimensaoro 0]

Great, is just that. But unfortunately I did not find this formula in the source of Cronus.

This is in battle.c or in status.c ?

 

Here they are:

 

http://www.dimensaoro.com/battle.c

http://www.dimensaoro.com/status.c

[malufett 247]

battle.c

int64 battle_calc_base_damage(struct block_list *src ...

 

 

[dimensaoro 0]

The fame of Hercules is really worthy. Thank you for support. With less than 1 hour you helped me more than the Cronus in 8 days with no response. If my server was no longer online, I would use the Hercules no doubt.

 

@edit

 

Hi, I returned haha

I did several tests, sometimes some errors at compile time, another time error 'miss' attacking.

Finally, I copied the formula of Hercules and replaces the mine, but there was no change. Even the formulas are different, the bonus is the same.

 

Old formula - Cronus:

int64 battle_calc_base_damage(struct block_list *src, struct block_list *bl, uint16 skill_id, uint16 skill_lv, int nk, bool n_ele, short s_ele, short s_ele_, int type, int flag, int flag2) {	int64 damage, batk;	struct status_data *st = status->get_status_data(src);		batk = battle->calc_elefix(src, bl, skill_id, skill_lv, status->calc_batk(bl, status->get_sc(src), st->batk, false), nk, n_ele, ELE_NEUTRAL, ELE_NEUTRAL, false, flag);	if( type == EQI_HAND_L )		damage = batk + 3 * battle->calc_weapon_damage(src, bl, skill_id, skill_lv, &st->lhw, nk, n_ele, s_ele, s_ele_, status_get_size(bl), type, flag, flag2) / 4;	else		damage = (batk << 1) + battle->calc_weapon_damage(src, bl, skill_id, skill_lv, &st->rhw, nk, n_ele, s_ele, s_ele_, status_get_size(bl), type, flag, flag2);		return damage;}

 

New formula - Hercules:

int64 battle_calc_base_damage(struct block_list *src, struct block_list *bl, uint16 skill_id, uint16 skill_lv, int nk, bool n_ele, short s_ele, short s_ele_, int type, int flag, int flag2) {	int64 damage, batk;	struct status_data *st = status->get_status_data(src);	struct status_change *sc = status->get_sc(src);	if (src->type == BL_PC){		// Property from mild wind bypasses it		if (sc && sc->data[SC_TK_SEVENWIND])			batk = battle->calc_elefix(src, bl, skill_id, skill_lv, status->calc_batk(bl, sc, st->batk, false), nk, n_ele, s_ele, s_ele_, false, flag);		else			batk = battle->calc_elefix(src, bl, skill_id, skill_lv, status->calc_batk(bl, sc, st->batk, false), nk, n_ele, ELE_NEUTRAL, ELE_NEUTRAL, false, flag);		if (type == EQI_HAND_L)			damage = batk + 3 * battle->calc_weapon_damage(src, bl, skill_id, skill_lv, &st->lhw, nk, n_ele, s_ele, s_ele_, status_get_size(bl), type, flag, flag2) / 4;		else			damage = (batk << 1) + battle->calc_weapon_damage(src, bl, skill_id, skill_lv, &st->rhw, nk, n_ele, s_ele, s_ele_, status_get_size(bl), type, flag, flag2);	}	else{		damage = st->batk + battle->calc_weapon_damage(src, bl, skill_id, skill_lv, &st->rhw, nk, n_ele, s_ele, s_ele_, status_get_size(bl), type, flag, flag2);	}	return damage;}

 

Is there somewhere else that should be changed?

 

With the Abysmal Knight my damage on MvP Boitatá from 2001 to 2013 k.

 

OBS: The attack usually increases with the level of char, power weapon or attributes. Only the bonus that give damage to monsters or players that are in error.

Edited December 19, 2014 by dimensaoro

[dimensaoro 0]

Forget. Please, someone close the topic. Thankyou all.