koe give reward to all player when click exit npc

[minx123 2]

how to fix this script? it give reward to all player who click exit npc.

 

//===== eAthena Script ============================================//= King of Emperium Hill//===== By: =======================================================//= AnnieRuru//===== Current Version: ==========================================//= 1.0//===== Compatible With: ==========================================//= hercules 2014-02-18//===== Description: ==============================================//= defends the emperium in the middle of the map until times up//===== Topic =====================================================//= http://herc.ws/board/topic/4495-gvg-king-of-emperium-hill///===== Additional Comments: ======================================//= Finally there is a topic for this !//=================================================================-	script	KoE	-1,{OnInit:	disablenpc "The King#KoE";	disablenpc "Exit#KoE";	bindatcmd "koe", strnpcinfo(0)+"::OnCommand", 99,100;	end;OnCommand:	if ( compare( .@atcmd_parameters$, "on" ) ) goto L_Start;	else if ( compare( .@atcmd_parameters$, "off" ) ) goto L_End;	else {		dispbottom "type - '@koe on' to start the event";		dispbottom "type - '@koe off' to end the event";	}	end;OnClock2200: // everyday 10pm startsL_start:	if ( .start ) end;	gvgon "guild_vs1";	announce "The King of Emperium Hill has begun!", bc_all;	.start = 1;	enablenpc "The King#KoE";	disablenpc "Exit#KoE";	$koegid = 0;	donpcevent "::OnRevKoE";	maprespawnguildid "guild_vs1", $koegid, 7;	monster "guild_vs1",49,49,"EMPERIUM",1288,1,"KoE::OnEmpDead";	end;OnClock2300: // everyday 11.00pm endsL_end:	gvgoff "guild_vs1";	announce "The King of Emperium Hill is over!", bc_all;	.start = 0;	enablenpc "Exit#KoE";	disablenpc "The King#KoE";	killmonsterall "guild_vs1";//	maprespawnguildid "guild_vs1", $koegid, 6; // uncomment this line to kick non-owner off the map when event ends	end;OnEmpDead:	$koegid = getcharid(2);	announce "The current King of Emperium Hill is the ["+ strcharinfo(2) +"] guild.", bc_all;	donpcevent "::OnRevKoE";	maprespawnguildid "guild_vs1", $koegid, 6;	sleep 500;	if ( .start )		monster "guild_vs1",49,49,"EMPERIUM",1288,1,"KoE::OnEmpDead";	end;}// KoE Entranceinvek,157,161,4	script	The King#KoE	58,{    mes "[The King]";	if ( !getcharid(2) ) {		mes "You must have a guild to participate in the ^FF0000King of Emperium Hill Tournament^000000.";		close;	}    mes "Hello.";    mes "Would you like to participate in the ^FF0000King of Emperium Hill Tournament^000000?";	if ( select ( "Yes", "No" ) == 2 ) close;    switch( rand(1,4) ){        case 1:	warp "guild_vs1", 50, 88; end;        case 2:	warp "guild_vs1", 88, 50; end;        case 3:	warp "guild_vs1", 50, 11; end;        case 4:	warp "guild_vs1", 11, 50; end;	}}// KoE Exitguild_vs1,49,56,5	script	Exit#KoE	51,{	mes "[Exit]";	mes "See ya.";	close2;	warp "Save",0,0;	if ( getcharid(2) == $koegid )		getitem 7227, 10; // configure prize here		getitem 12903,1;		getitem 12905,1;		getitem 12904,1;		getitem 12907,1;		getitem 12906,1;		getitem 12186,1;		getitem 30225,3;	end;}// Flagsguild_vs1,49,38,4	script	King of Emperium Hill#1::koe_flag	722,{	if ( !$koegid ) end;	mes "[King of Emperium Hill]";	mes "The Current King of Emperium Hill is the ["+ getguildname($koegid) +"] guild.";	close;//OnInit: // Uncomment this line to make the emblem stay after @reloadscriptOnRevKoE:	flagemblem $koegid;	end;}guild_vs1,61,49,6	duplicate(koe_flag)	King of Emperium Hill#2	722guild_vs1,38,49,2	duplicate(koe_flag)	King of Emperium Hill#3	722guild_vs1,49,61,0	duplicate(koe_flag)	King of Emperium Hill#4	722invek,160,156,3	duplicate(koe_flag)	King of Emperium Hill#5	722guild_vs1	mapflag	nobranchguild_vs1	mapflag	nomemoguild_vs1	mapflag	nopenaltyguild_vs1	mapflag	noreturnguild_vs1	mapflag	nosave	SavePointguild_vs1	mapflag	noteleportguild_vs1	mapflag	gvg_nopartyguild_vs1	mapflag	nowarpguild_vs1	mapflag	nowarptoguild_vs1	mapflag	guildlock

 

[Winterfox 83]

@@minx123

 

I only found the issue that if the emp doesn't get killed and someone without a guild used that NPC he could get the rewards.

 

If you mean everyone in the guild that won though, that seems to be on purpose. But people from other guilds shouldn't, atleast i can't find a way how that should work currently.

 

This should fix the reward for non guild users if the emp wasn't killed:

//===== eAthena Script ============================================//= King of Emperium Hill//===== By: =======================================================//= AnnieRuru//===== Current Version: ==========================================//= 1.0//===== Compatible With: ==========================================//= hercules 2014-02-18//===== Description: ==============================================//= defends the emperium in the middle of the map until times up//===== Topic =====================================================//= http://herc.ws/board/topic/4495-gvg-king-of-emperium-hill///===== Additional Comments: ======================================//= Finally there is a topic for this !//=================================================================-	script	KoE	-1,{OnInit:	disablenpc "The King#KoE";	disablenpc "Exit#KoE";	bindatcmd "koe", strnpcinfo(0)+"::OnCommand", 99,100;	end;OnCommand:	if ( compare( .@atcmd_parameters$, "on" ) ) goto L_Start;	else if ( compare( .@atcmd_parameters$, "off" ) ) goto L_End;	else {		dispbottom "type - '@koe on' to start the event";		dispbottom "type - '@koe off' to end the event";	}	end;OnClock2200: // everyday 10pm startsL_start:	if ( .start ) end;	gvgon "guild_vs1";	announce "The King of Emperium Hill has begun!", bc_all;	.start = 1;	enablenpc "The King#KoE";	disablenpc "Exit#KoE";	$koegid = 0;	donpcevent "::OnRevKoE";	maprespawnguildid "guild_vs1", $koegid, 7;	monster "guild_vs1",49,49,"EMPERIUM",1288,1,"KoE::OnEmpDead";	end;OnClock2300: // everyday 11.00pm endsL_end:	gvgoff "guild_vs1";	announce "The King of Emperium Hill is over!", bc_all;	.start = 0;	enablenpc "Exit#KoE";	disablenpc "The King#KoE";	killmonsterall "guild_vs1";//	maprespawnguildid "guild_vs1", $koegid, 6; // uncomment this line to kick non-owner off the map when event ends	end;OnEmpDead:	$koegid = getcharid(2);	announce "The current King of Emperium Hill is the ["+ strcharinfo(2) +"] guild.", bc_all;	donpcevent "::OnRevKoE";	maprespawnguildid "guild_vs1", $koegid, 6;	sleep 500;	if ( .start )		monster "guild_vs1",49,49,"EMPERIUM",1288,1,"KoE::OnEmpDead";	end;}// KoE Entranceinvek,157,161,4	script	The King#KoE	58,{    mes "[The King]";	if ( !getcharid(2) ) {		mes "You must have a guild to participate in the ^FF0000King of Emperium Hill Tournament^000000.";		close;	}    mes "Hello.";    mes "Would you like to participate in the ^FF0000King of Emperium Hill Tournament^000000?";	if ( select ( "Yes", "No" ) == 2 ) close;    switch( rand(1,4) ){        case 1:	warp "guild_vs1", 50, 88; end;        case 2:	warp "guild_vs1", 88, 50; end;        case 3:	warp "guild_vs1", 50, 11; end;        case 4:	warp "guild_vs1", 11, 50; end;	}}// KoE Exitguild_vs1,49,56,5	script	Exit#KoE	51,{	mes "[Exit]";	mes "See ya.";	close2;	warp "Save",0,0;	if ( $koegid && getcharid(2) == $koegid )		getitem 7227, 10; // configure prize here		getitem 12903,1;		getitem 12905,1;		getitem 12904,1;		getitem 12907,1;		getitem 12906,1;		getitem 12186,1;		getitem 30225,3;	end;}// Flagsguild_vs1,49,38,4	script	King of Emperium Hill#1::koe_flag	722,{	if ( !$koegid ) end;	mes "[King of Emperium Hill]";	mes "The Current King of Emperium Hill is the ["+ getguildname($koegid) +"] guild.";	close;//OnInit: // Uncomment this line to make the emblem stay after @reloadscriptOnRevKoE:	flagemblem $koegid;	end;}guild_vs1,61,49,6	duplicate(koe_flag)	King of Emperium Hill#2	722guild_vs1,38,49,2	duplicate(koe_flag)	King of Emperium Hill#3	722guild_vs1,49,61,0	duplicate(koe_flag)	King of Emperium Hill#4	722invek,160,156,3	duplicate(koe_flag)	King of Emperium Hill#5	722guild_vs1	mapflag	nobranchguild_vs1	mapflag	nomemoguild_vs1	mapflag	nopenaltyguild_vs1	mapflag	noreturnguild_vs1	mapflag	nosave	SavePointguild_vs1	mapflag	noteleportguild_vs1	mapflag	gvg_nopartyguild_vs1	mapflag	nowarpguild_vs1	mapflag	nowarptoguild_vs1	mapflag	guildlock

Edited July 20, 2015 by Winterfox

[minx123 2]

 

@@minx123

 

I only found the issue that if the emp doesn't get killed and someone without a guild used that NPC he could get the rewards.

 

If you mean everyone in the guild that won though, that seems to be on purpose. But people from other guilds shouldn't, atleast i can't find a way how that should work currently.

 

This should fix the reward for non guild users if the emp wasn't killed:

//===== eAthena Script ============================================//= King of Emperium Hill//===== By: =======================================================//= AnnieRuru//===== Current Version: ==========================================//= 1.0//===== Compatible With: ==========================================//= hercules 2014-02-18//===== Description: ==============================================//= defends the emperium in the middle of the map until times up//===== Topic =====================================================//= http://herc.ws/board/topic/4495-gvg-king-of-emperium-hill///===== Additional Comments: ======================================//= Finally there is a topic for this !//=================================================================-	script	KoE	-1,{OnInit:	disablenpc "The King#KoE";	disablenpc "Exit#KoE";	bindatcmd "koe", strnpcinfo(0)+"::OnCommand", 99,100;	end;OnCommand:	if ( compare( .@atcmd_parameters$, "on" ) ) goto L_Start;	else if ( compare( .@atcmd_parameters$, "off" ) ) goto L_End;	else {		dispbottom "type - '@koe on' to start the event";		dispbottom "type - '@koe off' to end the event";	}	end;OnClock2200: // everyday 10pm startsL_start:	if ( .start ) end;	gvgon "guild_vs1";	announce "The King of Emperium Hill has begun!", bc_all;	.start = 1;	enablenpc "The King#KoE";	disablenpc "Exit#KoE";	$koegid = 0;	donpcevent "::OnRevKoE";	maprespawnguildid "guild_vs1", $koegid, 7;	monster "guild_vs1",49,49,"EMPERIUM",1288,1,"KoE::OnEmpDead";	end;OnClock2300: // everyday 11.00pm endsL_end:	gvgoff "guild_vs1";	announce "The King of Emperium Hill is over!", bc_all;	.start = 0;	enablenpc "Exit#KoE";	disablenpc "The King#KoE";	killmonsterall "guild_vs1";//	maprespawnguildid "guild_vs1", $koegid, 6; // uncomment this line to kick non-owner off the map when event ends	end;OnEmpDead:	$koegid = getcharid(2);	announce "The current King of Emperium Hill is the ["+ strcharinfo(2) +"] guild.", bc_all;	donpcevent "::OnRevKoE";	maprespawnguildid "guild_vs1", $koegid, 6;	sleep 500;	if ( .start )		monster "guild_vs1",49,49,"EMPERIUM",1288,1,"KoE::OnEmpDead";	end;}// KoE Entranceinvek,157,161,4	script	The King#KoE	58,{    mes "[The King]";	if ( !getcharid(2) ) {		mes "You must have a guild to participate in the ^FF0000King of Emperium Hill Tournament^000000.";		close;	}    mes "Hello.";    mes "Would you like to participate in the ^FF0000King of Emperium Hill Tournament^000000?";	if ( select ( "Yes", "No" ) == 2 ) close;    switch( rand(1,4) ){        case 1:	warp "guild_vs1", 50, 88; end;        case 2:	warp "guild_vs1", 88, 50; end;        case 3:	warp "guild_vs1", 50, 11; end;        case 4:	warp "guild_vs1", 11, 50; end;	}}// KoE Exitguild_vs1,49,56,5	script	Exit#KoE	51,{	mes "[Exit]";	mes "See ya.";	close2;	warp "Save",0,0;	if ( $koegid && getcharid(2) == $koegid )		getitem 7227, 10; // configure prize here		getitem 12903,1;		getitem 12905,1;		getitem 12904,1;		getitem 12907,1;		getitem 12906,1;		getitem 12186,1;		getitem 30225,3;	end;}// Flagsguild_vs1,49,38,4	script	King of Emperium Hill#1::koe_flag	722,{	if ( !$koegid ) end;	mes "[King of Emperium Hill]";	mes "The Current King of Emperium Hill is the ["+ getguildname($koegid) +"] guild.";	close;//OnInit: // Uncomment this line to make the emblem stay after @reloadscriptOnRevKoE:	flagemblem $koegid;	end;}guild_vs1,61,49,6	duplicate(koe_flag)	King of Emperium Hill#2	722guild_vs1,38,49,2	duplicate(koe_flag)	King of Emperium Hill#3	722guild_vs1,49,61,0	duplicate(koe_flag)	King of Emperium Hill#4	722invek,160,156,3	duplicate(koe_flag)	King of Emperium Hill#5	722guild_vs1	mapflag	nobranchguild_vs1	mapflag	nomemoguild_vs1	mapflag	nopenaltyguild_vs1	mapflag	noreturnguild_vs1	mapflag	nosave	SavePointguild_vs1	mapflag	noteleportguild_vs1	mapflag	gvg_nopartyguild_vs1	mapflag	nowarpguild_vs1	mapflag	nowarptoguild_vs1	mapflag	guildlock

i cant use @koe on or off

 

[Winterfox 83]

@@minx123

 

I checked it and the only error i got was that the labels in the goto were named different than the actual labels.

That seems to have slipped because it seems when i checked if the script still compiles, i copied a wrong one..

It is weird you didn't get that before since i didn't even touch the labels before.

 

Here is the fix i made, maybe it helps you to solve your error also.

 

//===== eAthena Script ============================================//= King of Emperium Hill//===== By: =======================================================//= AnnieRuru//===== Current Version: ==========================================//= 1.0//===== Compatible With: ==========================================//= hercules 2014-02-18//===== Description: ==============================================//= defends the emperium in the middle of the map until times up//===== Topic =====================================================//= http://herc.ws/board/topic/4495-gvg-king-of-emperium-hill///===== Additional Comments: ======================================//= Finally there is a topic for this !//=================================================================-	script	KoE	-1,{	OnInit:		disablenpc "The King#KoE";		disablenpc "Exit#KoE";		bindatcmd "koe", strnpcinfo(0)+"::OnCommand", 99,100;	end;		OnCommand:		if ( compare( .@atcmd_parameters$, "on" ) ) goto L_Start;		else if ( compare( .@atcmd_parameters$, "off" ) ) goto L_End;		else {			dispbottom "type - '@koe on' to start the event";			dispbottom "type - '@koe off' to end the event";		}	end;		OnClock2200: // everyday 10pm starts	L_Start:		if ( .start ) end;		gvgon "guild_vs1";		announce "The King of Emperium Hill has begun!", bc_all;		.start = 1;		enablenpc "The King#KoE";		disablenpc "Exit#KoE";		$koegid = 0;		donpcevent "::OnRevKoE";		maprespawnguildid "guild_vs1", $koegid, 7;		monster "guild_vs1",49,49,"EMPERIUM",1288,1,"KoE::OnEmpDead";	end;		OnClock2300: // everyday 11.00pm ends	L_End:		gvgoff "guild_vs1";		announce "The King of Emperium Hill is over!", bc_all;		.start = 0;		enablenpc "Exit#KoE";		disablenpc "The King#KoE";		killmonsterall "guild_vs1";	//	maprespawnguildid "guild_vs1", $koegid, 6; // uncomment this line to kick non-owner off the map when event ends	end;		OnEmpDead:		$koegid = getcharid(2);		announce "The current King of Emperium Hill is the ["+ strcharinfo(2) +"] guild.", bc_all;		donpcevent "::OnRevKoE";		maprespawnguildid "guild_vs1", $koegid, 6;		sleep 500;		if ( .start )			monster "guild_vs1",49,49,"EMPERIUM",1288,1,"KoE::OnEmpDead";	end;}// KoE Entranceinvek,157,161,4	script	The King#KoE	58,{    mes "[The King]";		if ( !getcharid(2) ) {		mes "You must have a guild to participate in the ^FF0000King of Emperium Hill Tournament^000000.";		close;	}    	mes "Hello.";    mes "Would you like to participate in the ^FF0000King of Emperium Hill Tournament^000000?";		if ( select ( "Yes", "No" ) == 2 ) close;    switch( rand(1,4) ){        case 1:	warp "guild_vs1", 50, 88; end;        case 2:	warp "guild_vs1", 88, 50; end;        case 3:	warp "guild_vs1", 50, 11; end;        case 4:	warp "guild_vs1", 11, 50; end;	}}// KoE Exitguild_vs1,49,56,5	script	Exit#KoE	51,{	mes "[Exit]";	mes "See ya.";	close2;		warp "Save",0,0;	if ( $koegid && getcharid(2) == $koegid )		getitem 7227, 10; // configure prize here		getitem 12903,1;		getitem 12905,1;		getitem 12904,1;		getitem 12907,1;		getitem 12906,1;		getitem 12186,1;		getitem 30225,3;	end;}// Flagsguild_vs1,49,38,4	script	King of Emperium Hill#1::koe_flag	722,{	if ( !$koegid ) end;		mes "[King of Emperium Hill]";	mes "The Current King of Emperium Hill is the ["+ getguildname($koegid) +"] guild.";	close;//OnInit: // Uncomment this line to make the emblem stay after @reloadscriptOnRevKoE:	flagemblem $koegid;	end;}guild_vs1,61,49,6	duplicate(koe_flag)	King of Emperium Hill#2	722guild_vs1,38,49,2	duplicate(koe_flag)	King of Emperium Hill#3	722guild_vs1,49,61,0	duplicate(koe_flag)	King of Emperium Hill#4	722invek,160,156,3	duplicate(koe_flag)	King of Emperium Hill#5	722guild_vs1	mapflag	nobranchguild_vs1	mapflag	nomemoguild_vs1	mapflag	nopenaltyguild_vs1	mapflag	noreturnguild_vs1	mapflag	nosave	SavePointguild_vs1	mapflag	noteleportguild_vs1	mapflag	gvg_nopartyguild_vs1	mapflag	nowarpguild_vs1	mapflag	nowarptoguild_vs1	mapflag	guildlock

Edited July 20, 2015 by Winterfox

[minx123 2]

 

@@minx123

 

I checked it and the only error i got was that the labels in the goto were named different than the actual labels.

That seems to have slipped because it seems when i checked if the script still compiles, i copied a wrong one..

It is weird you didn't get that before since i didn't even touch the labels before.

 

Here is the fix i made, maybe it helps you to solve your error also.

 

//===== eAthena Script ============================================//= King of Emperium Hill//===== By: =======================================================//= AnnieRuru//===== Current Version: ==========================================//= 1.0//===== Compatible With: ==========================================//= hercules 2014-02-18//===== Description: ==============================================//= defends the emperium in the middle of the map until times up//===== Topic =====================================================//= http://herc.ws/board/topic/4495-gvg-king-of-emperium-hill///===== Additional Comments: ======================================//= Finally there is a topic for this !//=================================================================-	script	KoE	-1,{	OnInit:		disablenpc "The King#KoE";		disablenpc "Exit#KoE";		bindatcmd "koe", strnpcinfo(0)+"::OnCommand", 99,100;	end;		OnCommand:		if ( compare( .@atcmd_parameters$, "on" ) ) goto L_Start;		else if ( compare( .@atcmd_parameters$, "off" ) ) goto L_End;		else {			dispbottom "type - '@koe on' to start the event";			dispbottom "type - '@koe off' to end the event";		}	end;		OnClock2200: // everyday 10pm starts	L_Start:		if ( .start ) end;		gvgon "guild_vs1";		announce "The King of Emperium Hill has begun!", bc_all;		.start = 1;		enablenpc "The King#KoE";		disablenpc "Exit#KoE";		$koegid = 0;		donpcevent "::OnRevKoE";		maprespawnguildid "guild_vs1", $koegid, 7;		monster "guild_vs1",49,49,"EMPERIUM",1288,1,"KoE::OnEmpDead";	end;		OnClock2300: // everyday 11.00pm ends	L_End:		gvgoff "guild_vs1";		announce "The King of Emperium Hill is over!", bc_all;		.start = 0;		enablenpc "Exit#KoE";		disablenpc "The King#KoE";		killmonsterall "guild_vs1";	//	maprespawnguildid "guild_vs1", $koegid, 6; // uncomment this line to kick non-owner off the map when event ends	end;		OnEmpDead:		$koegid = getcharid(2);		announce "The current King of Emperium Hill is the ["+ strcharinfo(2) +"] guild.", bc_all;		donpcevent "::OnRevKoE";		maprespawnguildid "guild_vs1", $koegid, 6;		sleep 500;		if ( .start )			monster "guild_vs1",49,49,"EMPERIUM",1288,1,"KoE::OnEmpDead";	end;}// KoE Entranceinvek,157,161,4	script	The King#KoE	58,{    mes "[The King]";		if ( !getcharid(2) ) {		mes "You must have a guild to participate in the ^FF0000King of Emperium Hill Tournament^000000.";		close;	}    	mes "Hello.";    mes "Would you like to participate in the ^FF0000King of Emperium Hill Tournament^000000?";		if ( select ( "Yes", "No" ) == 2 ) close;    switch( rand(1,4) ){        case 1:	warp "guild_vs1", 50, 88; end;        case 2:	warp "guild_vs1", 88, 50; end;        case 3:	warp "guild_vs1", 50, 11; end;        case 4:	warp "guild_vs1", 11, 50; end;	}}// KoE Exitguild_vs1,49,56,5	script	Exit#KoE	51,{	mes "[Exit]";	mes "See ya.";	close2;		warp "Save",0,0;	if ( $koegid && getcharid(2) == $koegid )		getitem 7227, 10; // configure prize here		getitem 12903,1;		getitem 12905,1;		getitem 12904,1;		getitem 12907,1;		getitem 12906,1;		getitem 12186,1;		getitem 30225,3;	end;}// Flagsguild_vs1,49,38,4	script	King of Emperium Hill#1::koe_flag	722,{	if ( !$koegid ) end;		mes "[King of Emperium Hill]";	mes "The Current King of Emperium Hill is the ["+ getguildname($koegid) +"] guild.";	close;//OnInit: // Uncomment this line to make the emblem stay after @reloadscriptOnRevKoE:	flagemblem $koegid;	end;}guild_vs1,61,49,6	duplicate(koe_flag)	King of Emperium Hill#2	722guild_vs1,38,49,2	duplicate(koe_flag)	King of Emperium Hill#3	722guild_vs1,49,61,0	duplicate(koe_flag)	King of Emperium Hill#4	722invek,160,156,3	duplicate(koe_flag)	King of Emperium Hill#5	722guild_vs1	mapflag	nobranchguild_vs1	mapflag	nomemoguild_vs1	mapflag	nopenaltyguild_vs1	mapflag	noreturnguild_vs1	mapflag	nosave	SavePointguild_vs1	mapflag	noteleportguild_vs1	mapflag	gvg_nopartyguild_vs1	mapflag	nowarpguild_vs1	mapflag	nowarptoguild_vs1	mapflag	guildlock

player still can get reward when press  npc exit.

problem still not solve..

last time there i work perfect.. but today player report still can get reward.

Edited July 26, 2015 by minx123

[minx123 2]

bump. help me solve this problem. what should i do?

[Z3R0 8]

It's quite simple actually

 

if ($koegid) && getcharid(2) == $koegid)

   getitem etc...

   getitem etc...

 

is your problem...

 

IF statements without wrapping { } will only trigger on the NEXT command and anything afterwards is just a normal command...

 

so players (non guildies) are getting every item EXCEPT the one directly below the IF statement... Wrap the entire getitem contents in { }

 

if ($koegid && getcharid(2) == $koegid) {

    getitem etc...  

    getitem etc...

    getitem etc...

}

[minx123 2]

 

It's quite simple actually

if ($koegid) && getcharid(2) == $koegid)
getitem etc...
getitem etc...

is your problem...

IF statements without wrapping { } will only trigger on the NEXT command and anything afterwards is just a normal command...

so players (non guildies) are getting every item EXCEPT the one directly below the IF statement... Wrap the entire getitem contents in { }

if ($koegid && getcharid(2) == $koegid) {
getitem etc...
getitem etc...
getitem etc...
}

Thank you.. I will try it later..

its work.. thank you.. Edited October 1, 2015 by minx123