[Help] Minstrel/Wanderer Skills

[Mikhail von Hohenheim 1]

well,,  just need someone to check this out also for me,,

 

I am actually checking out the skills from wanderer and minstrel,, im doing some changes at the skills,,

 

to give an expectation,, I'm redistributing between bard/ Dancers~~clown/gypsy~~minstrel/wanderers,, and i also disabled the ensemble requirement for the skills (so they can use skills alone)

 

I'm almost done w/ it there're just 2 skills that interests me,, BUT,, having hard time editing them,, (not that familiar w/ src code editing,, but yeah,, i'm just making changes base from the FIX values of the skills)

 

these 2 skills are the warcry from beyond,, and sinking melody,,

 

well,, i dont know if these skills are actually supportive to party skills or debuff to enemies but base from the description of the skills and from my tests here are the results:

 

FOR SINKING MELODY

 

		"Description: ^777777When sung by the caster and at",		"least one other Maestro/Wanderer, Sinking",		"Melody increases Matk and decreases ATK of",		"everyone around including the caster. Cannot",		"be used with the chorus skill Beyond of",		"Warcry. Each additional Maestro or Wanderer",		"in the party increases Matk by 3%.",

"^00BB00Requires instrument/whip class weapon^777777.^000000",

"[Lv 1]: ^777777Success rate 20%, Duration 20 sec.^000000",

"[Lv 2]: ^777777Success rate 30%, Duration 30 sec.^000000",

"[Lv 3]: ^777777Success rate 40%, Duration 40 sec.^000000",

"[Lv 4]: ^777777Success rate 50%, Duration 50 sec.^000000",

"[Lv 5]: ^777777Success rate 60%, Duration 60 sec.^000000"

 

BUT,, when using the skill,, what's happening is,, instead of increasing Matk and reducing attck,, it reduces the INT,, AND it eats up the SP,, like around 10% every 1 sec,, AND it affects only enemies,,

 

 

The Only thing I've changed in here is the success rate of the skill as the success rate sucks,, I've increase it,, under the skill.c

 

from:

 

		case WM_MELODYOFSINK:		case WM_BEYOND_OF_WARCRY:		{			int chorusbonus = battle->calc_chorusbonus(sd);			if( flag&1 )				sc_start2(src,bl,type,100,skill_lv,chorusbonus,skill->get_time(skill_id,skill_lv));			else if( sd ) {				if ( rnd()%100 < 15 + 5 * skill_lv + 5 * chorusbonus ) {					map->foreachinrange(skill->area_sub, src, skill->get_splash(skill_id,skill_lv),BL_PC, src, skill_id, skill_lv, tick, flag|BCT_ENEMY|1, skill->castend_nodamage_id);					clif->skill_nodamage(src,bl,skill_id,skill_lv,1);				}			}		}			break;

to:

		case WM_MELODYOFSINK:		case WM_BEYOND_OF_WARCRY:		{			int chorusbonus = battle->calc_chorusbonus(sd);			if( flag&1 )				sc_start2(src,bl,type,100,skill_lv,chorusbonus,skill->get_time(skill_id,skill_lv));			else if( sd ) {				if ( rnd()%100 < 15 + 15 * skill_lv + 5 * chorusbonus ) {					map->foreachinrange(skill->area_sub, src, skill->get_splash(skill_id,skill_lv),BL_PC, src, skill_id, skill_lv, tick, flag|BCT_ENEMY|1, skill->castend_nodamage_id);					clif->skill_nodamage(src,bl,skill_id,skill_lv,1);				}			}		}			break;

under status.c here are the codes:

 

	if(sc->data[SC_MELODYOFSINK])		int_ -= sc->data[SC_MELODYOFSINK]->val3;			case SC_MELODYOFSINK:				val3 = val1 * (2 + val2);//INT Reduction. Formula Includes Caster And 2nd Performer.				val4 = tick/1000;				tick_time = 1000;				break;		case SC_MELODYOFSINK:			if( --(sce->val4) >= 0 ) {				status->charge(bl, 0, st->max_sp * ( 2 * sce->val1 + 2 * sce->val2 ) / 100);				sc_timer_next(1000+tick, status->change_timer, bl->id, data);				return 0;			}			break;

well,, for me this effect it good as a debuff for the enemy,, and also i cannot change it as I'm not able to get anything from the codes,, except for the tick_time that it seems to me means that it would take effect for every 1second,,

 

 

 

NOW FOR the WARCRY FROM BEYOND

 

		"Description: ^777777When sung by the caster and at",		"least one other Maestro/Wanderer, increases",		"ATK and decreases Matk of everyone around",		"including the caster. Cannot be used with the",		"chorus skill Sinking Melody. Each additional",		"Maestro or Wanderer in the party increases",		"ATK by 3%.",		"^00BB00Requires instrument/whip class weapon^777777.^000000",		"[Lv 1]: ^777777Success rate 20%, Duration 20 sec.^000000",		"[Lv 2]: ^777777Success rate 25%, Duration 30 sec.^000000",		"[Lv 3]: ^777777Success rate 30%, Duration 40 sec.^000000",		"[Lv 4]: ^777777Success rate 35%, Duration 50 sec.^000000",		"[Lv 5]: ^777777Success rate 40%, Duration 60 sec.^000000"	},

Well this skills seems to me, base from the description, is somewhat related to sinking melody it just that it would benefit atk,, but base from my tests,, it gives around 10 str,, adds around 10 CRIT and reduces max HP to around 4k AND only affects Enemis, so i dont know if this would serve as a debuff or should be a buff,

 

again as you can see from above the only thing i've changed is the success rate of the skill as i increased it,,

 

and here are the codes for the warcry skill in status.c

 

	if(sc->data[SC_BEYOND_OF_WARCRY])		str += sc->data[SC_BEYOND_OF_WARCRY]->val3;	if(sc->data[SC_BEYOND_OF_WARCRY])		critical += 10 * sc->data[SC_BEYOND_OF_WARCRY]->val3;	if(sc->data[SC_BEYOND_OF_WARCRY])		maxhp -= maxhp * sc->data[SC_BEYOND_OF_WARCRY]->val4 / 100;			case SC_BEYOND_OF_WARCRY:				val3 = val1 * (2 + val2);//STR And Crit Reduction. Formula Includes Caster And 2nd Performer.				val4 = 4 * val1 + 4 * val2;//MaxHP Reduction				break;

well i cannot understand any of these( except for theCRIT effect) as it is full of variables,, so i cannot make any changes with it,, 

 

 

NOW

 

My question is,, except for the success rate,, are these effects the CORRECT one?? or it should be base from the description??

 

 

AND IF NOT,,

 

well I'm good with the effect of sinking melody,, it would serve as a good unique debuff skill for the enemies,,

 

but as for the warcry from beyond,, the HP reduction is good for the debuff,, BUT,, can someone help me w/ it giving the effect instead of the maxHP reduction,, would give a HP per second reduction,,