Help with @go 15 and @go 16

[monkeydlufy 0]

Hi! i need help regarding @go 15 novice grounds and @go 16 jail.

how can i change them to @go 15 mall, @go 16 vend and designate a map for those commands.

[Fizi 0]

You can refer here: Hercules Wiki

 

Hope it help.

[Samuel 83]

@@monkeydlufy

 

try using my bind @go script

 

http://herc.ws/board/topic/11136-samuels-script-collections/#entry69360

[monkeydlufy 0]

@@Fizi I will... Thanks!

@@Samuel thank you! i will try it!

@edit

@@Samuel how can i change the name of the town?

when i type @go 

it shows the name of warp

15=1@def01
16=@ge_st

how can i change the name?

Here >.>

Edited February 25, 2016 by monkeydlufy

[Samuel 83]

@@monkeydlufy for now it's configured to show map name, i'll update it to add an option for custom name

[monkeydlufy 0]

@@Samuel okay! i'll be waiting for your update sir

[Mystery 594]

@@Samuel okay! i'll be waiting for your update sir

Have you changed the name of your map in the help.txt file? https://github.com/HerculesWS/Hercules/blob/master/conf/help.txt So that it corresponds to the changes you did in your atcommand and mapindex files? If you're using the NPC script, ignore what I said.

[monkeydlufy 0]

@@Mysterious yes sir, i've changed the names on the help.txt file.

i didn't change anything on src atcommand and mapindex file..

 

atcommand

 

        { MAP_NOVICE,       53, 111, 3 }, // 15 = Training Grounds

        { MAP_JAIL,         23,  61, 3 }, // 16 = Prison

 

mapindex.h

 

#define MAP_JAIL "sec_pri"

#define MAP_NOVICE "new_1-1"


@@Mysterious Any other option you can suggest sir?

Edited February 25, 2016 by monkeydlufy

[Mystery 594]

@@monkeydlufy If you're doing it through the NPC, I suggest you just wait till @@Samuel helps you out. If you're going to do it VIA the source way, follow the guide on the wiki

[monkeydlufy 0]

okay.. i'll wait for Samuel's script

[monkeydlufy 0]

@@Samuel any Update on your script?

@@Mysterious can you give me the link guide on wiki?

[Mystery 594]

@@monkeydlufy you can see if this helps http://herc.ws/wiki/@go

[monkeydlufy 0]

@@Mysterious i got some error when recompiling idk which x.x

src/map/atcommand.c

/*==========================================
* @go [city_number or city_name] - Updated by Harbin
*------------------------------------------*/
ACMD(go) {
int town = INT_MAX; // Initialized to INT_MAX instead of -1 to avoid conflicts with those who map [-3:-1] to @memo locations.
char map_name[MAP_NAME_LENGTH];

const struct {
char map[MAP_NAME_LENGTH];
int x, y;
int min_match; ///< Minimum string length to match
} data[] = {
{ MAP_PRONTERA, 156, 191, 3 }, // 0 = Prontera
{ MAP_MORROC, 156, 93, 4 }, // 1 = Morroc
{ MAP_GEFFEN, 119, 59, 3 }, // 2 = Geffen
{ MAP_PAYON, 162, 233, 3 }, // 3 = Payon
{ MAP_ALBERTA, 192, 147, 3 }, // 4 = Alberta
#ifdef RENEWAL
{ MAP_IZLUDE, 128, 146, 3 }, // 5 = Izlude (Renewal)
#else
{ MAP_IZLUDE, 128, 114, 3 }, // 5 = Izlude
#endif
{ MAP_ALDEBARAN, 140, 131, 3 }, // 6 = Aldebaran
{ MAP_LUTIE, 147, 134, 3 }, // 7 = Lutie
{ MAP_COMODO, 209, 143, 3 }, // 8 = Comodo
{ MAP_YUNO, 157, 51, 3 }, // 9 = Juno
{ MAP_AMATSU, 198, 84, 3 }, // 10 = Amatsu
{ MAP_GONRYUN, 160, 120, 3 }, // 11 = Kunlun
{ MAP_UMBALA, 89, 157, 3 }, // 12 = Umbala
{ MAP_NIFLHEIM, 21, 153, 3 }, // 13 = Niflheim
{ MAP_LOUYANG, 217, 40, 3 }, // 14 = Luoyang
{ MAP_1@DEF01, 50, 28, 3 }, // 15 =Vend << I edit this line before ="Novice ground"
{ MAP_1@GE_ST, 109, 48, 3 }, // 16 = Mall<< i edit this line before ="Jail"
{ MAP_JAWAII, 249, 127, 3 }, // 17 = Jawaii
{ MAP_AYOTHAYA, 151, 117, 3 }, // 18 = Ayothaya
{ MAP_EINBROCH, 64, 200, 5 }, // 19 = Einbroch
{ MAP_LIGHTHALZEN, 158, 92, 3 }, // 20 = Lighthalzen
{ MAP_EINBECH, 70, 95, 5 }, // 21 = Einbech
{ MAP_HUGEL, 96, 145, 3 }, // 22 = Hugel
{ MAP_RACHEL, 130, 110, 3 }, // 23 = Rachel
{ MAP_VEINS, 216, 123, 3 }, // 24 = Veins
{ MAP_MOSCOVIA, 223, 184, 3 }, // 25 = Moscovia
{ MAP_MIDCAMP, 180, 240, 3 }, // 26 = Midgard Camp
{ MAP_MANUK, 282, 138, 3 }, // 27 = Manuk
{ MAP_SPLENDIDE, 197, 176, 3 }, // 28 = Splendide
{ MAP_BRASILIS, 182, 239, 3 }, // 29 = Brasilis
{ MAP_DICASTES, 198, 187, 3 }, // 30 = El Dicastes
{ MAP_MORA, 44, 151, 4 }, // 31 = Mora
{ MAP_DEWATA, 200, 180, 3 }, // 32 = Dewata
{ MAP_MALANGDO, 140, 114, 5 }, // 33 = Malangdo Island
{ MAP_MALAYA, 242, 211, 5 }, // 34 = Malaya Port
{ MAP_ECLAGE, 110, 39, 3 }, // 35 = Eclage
};

Also there are some lines that are not from the guide....

Hercules/src/map/atcommand.c

if (town < 0 || town >= ARRAYLENGTH(data)) {
// Alternate spellings
if (strncmpi(map_name, "morroc", 4) == 0) { // Correct town name for 'morocc'
town = 1;
} else if (strncmpi(map_name, "lutie", 3) == 0) { // Correct town name for 'xmas'
town = 7;
} else if (strncmpi(map_name, "juno", 3) == 0) { // Correct town name for 'yuno'
town = 9;
} else if (strncmpi(map_name, "kunlun", 3) == 0) { // Original town name for 'gonryun'
town = 11;
} else if (strncmpi(map_name, "luoyang", 3) == 0) { // Original town name for 'louyang'
town = 14;
} else if (strncmpi(map_name, "startpoint", 3) == 0 // Easy to remember alternatives to 'new_1-1'
|| strncmpi(map_name, "beginning", 3) == 0) {
town = 15;
} else if (strncmpi(map_name, "prison", 3) == 0 // Easy to remember alternatives to 'sec_pri'
|| strncmpi(map_name, "jail", 3) == 0) {
town = 16;
} else if (strncmpi(map_name, "rael", 3) == 0) { // Original town name for 'rachel'
town = 23;
}

Hercules wiki guide<------

// get possible name of the city
map_name[MAP_NAME_LENGTH-1] = '\0';
for (i = 0; map_name[i]; i++)
map_name[i] = TOLOWER(map_name[i]);
// try to identify the map name
if (strncmp(map_name, "prontera", 3) == 0) {
town = 0;
} else if (strncmp(map_name, "morocc", 3) == 0) {
town = 1;
} else if (strncmp(map_name, "geffen", 3) == 0) {
town = 2;
} else if (strncmp(map_name, "payon", 3) == 0 ||
strncmp(map_name, "paion", 3) == 0) {
town = 3;
} else if (strncmp(map_name, "alberta", 3) == 0) {
town = 4;
} else if (strncmp(map_name, "izlude", 3) == 0 ||
strncmp(map_name, "islude", 3) == 0) {
town = 5;
} else if (strncmp(map_name, "aldebaran", 3) == 0 ||
strcmp(map_name, "al") == 0) {
town = 6;
} else if (strncmp(map_name, "lutie", 3) == 0 ||
strcmp(map_name, "christmas") == 0 ||
strncmp(map_name, "xmas", 3) == 0 ||
strncmp(map_name, "x-mas", 3) == 0) {
town = 7;
} else if (strncmp(map_name, "comodo", 3) == 0) {
town = 8;
} else if (strncmp(map_name, "yuno", 3) == 0) {
town = 9;
} else if (strncmp(map_name, "amatsu", 3) == 0) {
town = 10;
} else if (strncmp(map_name, "gonryun", 3) == 0) {
town = 11;
} else if (strncmp(map_name, "umbala", 3) == 0) {
town = 12;
} else if (strncmp(map_name, "niflheim", 3) == 0) {
town = 13;
} else if (strncmp(map_name, "louyang", 3) == 0) {
town = 14;
} else if (strncmp(map_name, "new_1-1", 3) == 0 ||
strncmp(map_name, "startpoint", 3) == 0 ||
strncmp(map_name, "begining", 3) == 0) {
town = 15;
} else if (strncmp(map_name, "sec_pri", 3) == 0 ||
strncmp(map_name, "prison", 3) == 0 ||
strncmp(map_name, "jails", 3) == 0) {
town = 16;
} else if (strncmp(map_name, "jawaii", 3) == 0 ||
strncmp(map_name, "jawai", 3) == 0) {
town = 17;
} else if (strncmp(map_name, "ayothaya", 3) == 0 ||
strncmp(map_name, "ayotaya", 3) == 0) {
town = 18;
} else if (strncmp(map_name, "einbroch", 5) == 0 ||
strncmp(map_name, "ainbroch", 5) == 0) {
town = 19;
} else if (strncmp(map_name, "lighthalzen", 3) == 0) {
town = 20;
} else if (strncmp(map_name, "einbech", 3) == 0) {
town = 21;
} else if (strncmp(map_name, "hugel", 3) == 0) {
town = 22;
} else if (strncmp(map_name, "rachel", 3) == 0) {
town = 23;
} else if (strncmp(map_name, "veins", 3) == 0) {
town = 24;
} else if (strncmp(map_name, "moscovia", 3) == 0) {
town = 25;
} else if (strncmp(map_name, "mid_camp", 3) == 0) {
town = 26;
} else if (strncmp(map_name, "manuk", 3) == 0) {
town = 27;
} else if (strncmp(map_name, "splendide", 3) == 0) {
town = 28;
} else if (strncmp(map_name, "brasilis", 3) == 0) {
town = 29;
} else if (strncmp(map_name, "dicastes01", 3) == 0) {
town = 30;
} else if (strncmp(map_name, "mora", 3) == 0) {
town = 31;
} else if (strncmp(map_name, "dewata", 3) == 0) {
town = 32;
} else if (strncmp(map_name, "malangdo", 3) == 0) {
town = 33;
} else if (strncmp(map_name, "malaya", 3) == 0) {
town = 34;
} else if (strncmp(map_name, "eclage", 3) == 0) {
town = 35;
}

I tried editing the line

} else if (strncmpi(map_name, "startpoint", 3) == 0 // Easy to remember alternatives to 'new_1-1'
|| strncmpi(map_name, "beginning", 3) == 0) {
town = 15;
} else if (strncmpi(map_name, "prison", 3) == 0 // Easy to remember alternatives to 'sec_pri'
|| strncmpi(map_name, "jail", 3) == 0) {
town = 16;
to

} else if (strncmpi(map_name, "Vend", 3) == 0 // Easy to remember alternatives to 'new_1-1'
|| strncmpi(map_name, "vend", 3) == 0) {
town = 15;
} else if (strncmpi(map_name, "Mall", 3) == 0 // Easy to remember alternatives to 'sec_pri'
|| strncmpi(map_name, "mall", 3) == 0) {
town = 16;

and then on mapindex.h

//Some definitions for the mayor city maps.
#define MAP_PRONTERA "prontera"
#define MAP_GEFFEN "geffen"
#define MAP_MORROC "morocc"
#define MAP_ALBERTA "alberta"
#define MAP_PAYON "payon"
#define MAP_IZLUDE "izlude"
#define MAP_ALDEBARAN "aldebaran"
#define MAP_LUTIE "xmas"
#define MAP_COMODO "comodo"
#define MAP_YUNO "yuno"
#define MAP_AMATSU "amatsu"
#define MAP_GONRYUN "gonryun"
#define MAP_UMBALA "umbala"
#define MAP_NIFLHEIM "niflheim"
#define MAP_LOUYANG "louyang"
#define MAP_JAWAII "jawaii"
#define MAP_AYOTHAYA "ayothaya"
#define MAP_EINBROCH "einbroch"
#define MAP_LIGHTHALZEN "lighthalzen"
#define MAP_EINBECH "einbech"
#define MAP_HUGEL "hugel"
#define MAP_RACHEL "rachel"
#define MAP_VEINS "veins"
#define MAP_JAIL "sec_pri"
#define MAP_1@DEF01 "1@def01"
#define MAP_1@GE_ST "1@ge_st"
#define MAP_MIDCAMP "mid_camp"
#define MAP_MANUK "manuk"
#define MAP_SPLENDIDE "splendide"
#define MAP_BRASILIS "brasilis"
#define MAP_DICASTES "dicastes01"
#define MAP_MORA "mora"
#define MAP_DEWATA "dewata"
#define MAP_MALANGDO "malangdo"
#define MAP_MALAYA "malaya"
#define MAP_ECLAGE "eclage"
#define MAP_ECLAGE_IN "ecl_in01"

I recompiled server files then i got error :S

Edited March 17, 2016 by Mysterious
codebox