Help! with this Vending Control

[Zalbahis 0]

Hello Hercules!..

So I am having problems regarding with the vending control script of Emistry from rA. Can someone point out me what is the problem with the script.. Btw, I am using the latest Hercules SVN..

 

Map Server Image

 

Vend Control Script

-	script	Vend Control	-1,{OnInit:sleep 1000;// Map for vendingset .map$,"rachel";setcell .map$,0,0,284,365,cell_novending,1;// x and y horizone ..setarray .x_line,142,147,152,157;setarray .y_line,166,170,174,178,182,186,190;set .x_line_size,getarraysize( .x_line );set .y_line_size,getarraysize( .y_line );set .count,1;for( set .@x,0; .@x < .x_line_size; set .@x,.@x + 1 )	for( set .@y,0; .@y < .y_line_size; set .@y,.@y + 1 )		if( checkcell( .map$,.x_line[.@x],.y_line[.@y],cell_chkpass ) ){			movenpc "#vend_slot"+.count,.x_line[.@x],.y_line[.@y];			setcell .map$,.x_line[.@x],.y_line[.@y],.x_lin[.@x],.y_line[.@y],cell_novending,0;			set .count,.count + 1;		}npctalk "Vending Spot : "+.count;donpcevent "::OnSetup";end;}-	script	vend_slot	-1,{getmapxy( .@map$,.@x,.@y,1 );if( !getskilllv("MC_VENDING") ){	mes "You dont have ^0055FFVending Skill^000000.";}else if( getareausers( .@map$,.@x,.@y,.@x,.@y ) ){	mes "Someone already selected this spot.";}else{	mes "Spot : ^FF0000Available^000000";	mes "^0055FF[ Vending Area Rules ]^000000";	mes "^FF0000~ Use proper Shop Name.^000000";	mes "^FF0000~ Never sell Junk/Gifts.^000000";	mes " ";	mes "^777777Player will failed to follow these will be punished.^000000";	if( select( "Select this Spot","Cancel" ) == 1 ){		warp .@map$,.@x,.@y;		hideonnpc strnpcinfo(0);	}}close;OnSetup:getmapxy( .@map$,.@x,.@y,1 );set .@npcname$,strnpcinfo(0);while( 1 ){	if( getareausers( .@map$,.@x,.@y,.@x,.@y ) ){		hideonnpc .@npcname$;	}else{		hideoffnpc .@npcname$;		// specialeffect 313;	}	sleep 5000;}end;}// Add more if needed.rachel,1,1,4	duplicate(vend_slot)	#vend_slot1	858rachel,1,1,4	duplicate(vend_slot)	#vend_slot2	858rachel,1,1,4	duplicate(vend_slot)	#vend_slot3	858rachel,1,1,4	duplicate(vend_slot)	#vend_slot4	858rachel,1,1,4	duplicate(vend_slot)	#vend_slot5	858rachel,1,1,4	duplicate(vend_slot)	#vend_slot6	858rachel,1,1,4	duplicate(vend_slot)	#vend_slot7	858rachel,1,1,4	duplicate(vend_slot)	#vend_slot8	858rachel,1,1,4	duplicate(vend_slot)	#vend_slot9	858rachel,1,1,4	duplicate(vend_slot)	#vend_slot10	858rachel,1,1,4	duplicate(vend_slot)	#vend_slot11	858rachel,1,1,4	duplicate(vend_slot)	#vend_slot12	858rachel,1,1,4	duplicate(vend_slot)	#vend_slot13	858rachel,1,1,4	duplicate(vend_slot)	#vend_slot14	858rachel,1,1,4	duplicate(vend_slot)	#vend_slot15	858rachel,1,1,4	duplicate(vend_slot)	#vend_slot16	858rachel,1,1,4	duplicate(vend_slot)	#vend_slot17	858rachel,1,1,4	duplicate(vend_slot)	#vend_slot18	858rachel,1,1,4	duplicate(vend_slot)	#vend_slot19	858rachel,1,1,4	duplicate(vend_slot)	#vend_slot20	858rachel,1,1,4	duplicate(vend_slot)	#vend_slot21	858rachel,1,1,4	duplicate(vend_slot)	#vend_slot22	858rachel,1,1,4	duplicate(vend_slot)	#vend_slot23	858rachel,1,1,4	duplicate(vend_slot)	#vend_slot24	858rachel,1,1,4	duplicate(vend_slot)	#vend_slot25	858rachel,1,1,4	duplicate(vend_slot)	#vend_slot26	858rachel,1,1,4	duplicate(vend_slot)	#vend_slot27	858rachel,1,1,4	duplicate(vend_slot)	#vend_slot28	858

Thank you in advance and more power to Hercules !

[Yommy 265]

getmapxy( .@map$,.@x,.@y,1 );

that 1 at the end is to get the location on the npc (which yours does not have a location)

look at the documentation for this script function

http://ea.dj-yhn.com/index.php?c=getmapxy

[Zalbahis 0]

Haha! crap.. Thanks alot yommy .. Giving you a repu..

[Emistry 144]

use the latest version .....

 

else..change

while( 1 ){

to

while( .@map$ != "" ){

 

the error is caused by the floating npc which doesnt have a valid location.