Error in changer coin

[brunosc 2]

i got this error when i use @reloadscript 

 This command is deprecated and it will be removed in a future update. Please see the script documentation for an alternative.

    59:         if ( .@num == 0 || .@num >= 2147483647 ) return getarg(0);
    60:         set .@l, getstrlen(""+.@num);
    61:         for ( set .@i,0; .@i < .@l; set .@i, .@i + 1 ) {
*   62:                 set .@num$, .@num % pow(10,.@i+1) / pow(10,.@i) + .@num$;
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
    63:                         if ( (.@i+1) % 3 == 0 && .@i+1 != .@l ) set .@num$, ","+ .@num$;
    64:         }
    65:         return .@num$;
[Warning]: script error in file 'npc/custom/meus/tzeny.txt' line 62 column 39
    This command is deprecated and it will be removed in a future update. Please see the script documentation for an alternative.

    59:         if ( .@num == 0 || .@num >= 2147483647 ) return getarg(0);
    60:         set .@l, getstrlen(""+.@num);
    61:         for ( set .@i,0; .@i < .@l; set .@i, .@i + 1 ) {
*   62:                 set .@num$, .@num % pow(10,.@i+1) / pow(10,.@i) + .@num$;
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
    63:                         if ( (.@i+1) % 3 == 0 && .@i+1 != .@l ) set .@num$, ","+ .@num$;
    64:         }
    65:         return .@num$;

pow in the future not will be use, but if i change 

 

pow(10,.@i+1) / pow(10,.@i)    ->   (10**.@i+1) / (10**.@i)

 

i dont got error but not show correct zeny in script.

[4144 364]

try like this: (10**(.@i+1)) / (10**.@i)

[meko 170]

the exponentiation operator (**) has higher precedence than the addition operator (+) so this means A ** B+C is interpreted as (A ** B) + C because the exponentiation operation has priority over the addition operation

 

also worth noting that exponentiation has higher precedence than multiplication/division so a more complex formula like A + B * C ** D would be interpreted as A + (B * (C ** D)) so you have to manually reorder the operations with explicit parentheses if you want to change the precedence, like (A + (B * C)) ** D

[brunosc 2]

the code is :

function	int__	{
	set .@num, atoi(""+getarg(0));
	if ( .@num == 0 || .@num >= 2147483647 ) return getarg(0);
	set .@l, getstrlen(""+.@num);
	for ( set .@i,0; .@i < .@l; set .@i, .@i + 1 ) {
		set .@num$, .@num % pow(10,.@i+1) / (10**.@i) + .@num$;
			if ( (.@i+1) % 3 == 0 && .@i+1 != .@l ) set .@num$, ","+ .@num$;
	}
	return .@num$;
}

i got this warning: 

[Warning]: script error in file 'npc/custom/meus/tzeny.txt' line 62 column 23
    This command is deprecated and it will be removed in a future update. Please see the script documentation for an alternative.

    59:         if ( .@num == 0 || .@num >= 2147483647 ) return getarg(0);
    60:         set .@l, getstrlen(""+.@num);
    61:         for ( set .@i,0; .@i < .@l; set .@i, .@i + 1 ) {
*   62:                 set .@num$, .@num % pow(10,.@i+1) / (10**.@i) + .@num$;
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
    63:                         if ( (.@i+1) % 3 == 0 && .@i+1 != .@l ) set .@num$, ","+ .@num$;
    64:         }
    65:         return .@num$;

and in game  script ok.

 

when o remove POW and change to the new mode ( set .@num$, .@num % ((10**.@i)+1) / (10**.@i) + .@num$;)

i got this in NPC.

[4144 364]

If you not understand math, can you simply copy/paste fixed line?

 

[meko 170]

.@num$ = .@num % 10 ** (.@i + 1) / 10 ** .@i + .@num$;

 

[brunosc 2]

its work man, thank you!

but now i received warning.

[Warning]: script:op_2num: overflow detected op=C_POW i1=10 i2=10
[Debug]: Source (NPC): Mestre dos Ba�s at prontera (164,143)

 

Edited December 17, 2019 by brunosc

[meko 170]

10 to the power of 10 is 10,000,000,000 but the scripting engine uses signed 32-bit integers and the maximum value that can be held by such integers is 2,147,483,647 (2^31 − 1).

Any value above this will cause the integer to overflow so you have to be aware of this and manually check the boundaries. In your case this would mean checking that getarg(0) is shorter than 10 characters long so

if ( .@num == 0 || .@num >= 10 ** 9 ) return getarg(0);

instead of

if ( .@num == 0 || .@num >= 2147483647 ) return getarg(0);

to avoid the case where getstrlen is above 10

[brunosc 2]

You are the best! thank you!!!!!!!!!!!!!!!!!!