Double Attack critic damage

[fakezinhu666 0]

On official servers, DA and other skills can inflict critical damage, will it ever be fixed in Hercules? in rAthena it already works this way.

[X-EcutiOnner 6]

if you need to testing can see my pr
https://github.com/HerculesWS/Hercules/pull/2609

[fakezinhu666 0]

thanks, i'm going to test.

Edited March 21, 2020 by fakezinhu666

[fakezinhu666 0]

thanks, i'm going to test and give you feedback

On 3/20/2020 at 5:12 AM, X-EcutiOnner said:

if you need to testing can see my pr
https://github.com/HerculesWS/Hercules/pull/2609

Edit:

So, those are the problems I found:

 

1: Can only trigger a double attack if proc a crit first. as shown by the video below, if you have low / no critical rate, you won't activate a double attack. the expected behavior is that crit rate doesn't influence the chance of trigger a double attack, but whenever activating a DA, it should be a critical hit.

 

2: Being able to proc double attack with katar without sidewinder, it shouldn't be possible. Also when equipping a Sidewinder card, the double attack rate seems much lower than it should, probably because it reads as a level 1 skill.

 

[X-EcutiOnner 6]

This is initial release not complete yet and i'm not continue for it. Sorry Bro.