Request Convert this script

[Kuroyama 6]

Can anyone convert this very nice script to Hercules latest SVN version?

Reason: Getting a lots of sql errors and stuffs.

 

Source: https://rathena.org/board/files/file/3416-ragnarok-guild-package-npc/

Script :  guildpackage.txt

 

Advance thank you!

[AnnieRuru 957]

		query_sql("SELECT `last_ip` FROM `login` WHERE `account_id` = '"+.@acid+"'",.@c_ip$);
		query_sql("SELECT `last_mac` FROM `login` WHERE `account_id` = '"+.@acid+"'",.@c_mac$);
		query_sql("SELECT `last_cpu` FROM `login` WHERE `account_id` = '"+.@acid+"'",.@c_cpu$);
		query_sql("SELECT `last_motherboard` FROM `login` WHERE `account_id` = '"+.@acid+"'",.@c_mb$);

impossible, and this is against EU law to retrieve computer's data without customer's agreement

 

gepard ID is different, it just generate an ID for each client for that computer, this one is another story

this one ... require to hex a client or run a 3rd party program in the background to read client's computer data

maybe should have just use gepard ID check

[Kuroyama 6]

28 minutes ago, AnnieRuru said:

query_sql("SELECT `last_ip` FROM `login` WHERE `account_id` = '"+.@acid+"'",.@c_ip$); query_sql("SELECT `last_mac` FROM `login` WHERE `account_id` = '"+.@acid+"'",.@c_mac$); query_sql("SELECT `last_cpu` FROM `login` WHERE `account_id` = '"+.@acid+"'",.@c_cpu$); query_sql("SELECT `last_motherboard` FROM `login` WHERE `account_id` = '"+.@acid+"'",.@c_mb$);

		query_sql("SELECT `last_ip` FROM `login` WHERE `account_id` = '"+.@acid+"'",.@c_ip$);
		query_sql("SELECT `last_mac` FROM `login` WHERE `account_id` = '"+.@acid+"'",.@c_mac$);
		query_sql("SELECT `last_cpu` FROM `login` WHERE `account_id` = '"+.@acid+"'",.@c_cpu$);
		query_sql("SELECT `last_motherboard` FROM `login` WHERE `account_id` = '"+.@acid+"'",.@c_mb$);

impossible, and this is against EU law to retrieve computer's data without customer's agreement

 

gepard ID is different, it just generate an ID for each client for that computer, this one is another story

this one ... require to hex a client or run a 3rd party program in the background to read client's computer data

maybe should have just use gepard ID check

I have no idea that this script is against EU law, thanks for the heads up ms. @AnnieRuru.

I'm just amaze by the features that it gives different package from Guild Leader to Guild Members.

It's kinda neat that you can input guildname anytime you want and give them the package anytime you needed.

That's all.

 

or is it okay if I request something similar from this without those against the law?

just same features will do ms.annie.

[AnnieRuru 957]

well, nobody actually cares about laws ... since the players are mostly children anyway

the problem is just we don't want to get into trouble, so we (rathena/hercules) don't include any means to retrieve mac address or motherboard information etc

that part must be custom made ... they run a 3rd party program in the background to retrieve such information

 

IP proofing or something like that is just plain stupid, even mac address can be spoof
https://github.com/HerculesWS/Hercules/issues/1734#issuecomment-301363299

 

actually this can be a very simple script, just create a code and then guild master can claim it
and the item is getitembound IBT_GUILD or IBT_CHARACTER depends on how you like it