PROBLEM SKILL ABOVE LEVEL 10!

[Daraen 7]

I have been spamming Hercules Discord for an hour now for an important issue which is that skills above level 10 have no effect, only do one hit, one damage but no developer wants to. look into this topic.

It will seem that there is no case for WZ_JUPITEL and WZ_METEOR in battle.c but I don't think this is the cause of the problem.

In short, it doesn't matter if Mistress cast Jupitel THunder level 28 to me, I only get one hit, I'm not knockback and the skill effect is present on me but I only get one hit.

Same for Meteor Storm level 11, I suffer only one hit per ball.
It is not normal.

It looks like there is a problem with any skill above level 10.

How can you solve this big problem?
I am using a 2018 client

Some fix for rAthena : https://github.com/rathena/rathena/issues/4743
https://github.com/rathena/rathena/commit/b77ba3ae5bb765295df89151170ec4ccb9c5d3cf

Edited March 8, 2021 by Daraen

[botka4aet 5]

Quote

I have been spamming Hercules Discord for an hour

Oh god... do you create issue? Or what?

[Samuel 83]

16 hours ago, Daraen said:

I have been spamming Hercules Discord for an hour now for an important issue which is that skills above level 10 have no effect, only do one hit, one damage but no developer wants to. look into this topic.

It will seem that there is no case for WZ_JUPITEL and WZ_METEOR in battle.c but I don't think this is the cause of the problem.

In short, it doesn't matter if Mistress cast Jupitel THunder level 28 to me, I only get one hit, I'm not knockback and the skill effect is present on me but I only get one hit.

Same for Meteor Storm level 11, I suffer only one hit per ball.
It is not normal.

It looks like there is a problem with any skill above level 10.

How can you solve this big problem?
I am using a 2018 client

Some fix for rAthena : https://github.com/rathena/rathena/issues/4743
https://github.com/rathena/rathena/commit/b77ba3ae5bb765295df89151170ec4ccb9c5d3cf

 

Hmm this is confirmed...

 

As of now, as the skill db is read, if the level for knockback is not written, it doesn't work.

 

in skill_db.conf (either inside pre-re/re)

 

This is the pre-re WZ_JUPITEL

Quote

{
    Id: 84
    Name: "WZ_JUPITEL"
    Description: "Jupitel Thunder"
    MaxLevel: 10
    Range: 9
    Hit: "BDT_MULTIHIT"
    SkillType: {
        Enemy: true
    }
    SkillInfo: {
        AllowReproduce: true
    }
    AttackType: "Magic"
    Element: "Ele_Wind"
    NumberOfHits: {
        Lv1: 3
        Lv2: 4
        Lv3: 5
        Lv4: 6
        Lv5: 7
        Lv6: 8
        Lv7: 9
        Lv8: 10
        Lv9: 11
        Lv10: 12
    }
    InterruptCast: true
    KnockBackTiles: {
        Lv1: 2
        Lv2: 3
        Lv3: 3
        Lv4: 4
        Lv5: 4
        Lv6: 5
        Lv7: 5
        Lv8: 6
        Lv9: 6
        Lv10: 7
    }
    CastTime: {
        Lv1: 2500
        Lv2: 3000
        Lv3: 3500
        Lv4: 4000
        Lv5: 4500
        Lv6: 5000
        Lv7: 5500
        Lv8: 6000
        Lv9: 6500
        Lv10: 7000
    }
    CoolDown: 0
    Requirements: {
        SPCost: {
            Lv1: 20
            Lv2: 23
            Lv3: 26
            Lv4: 29
            Lv5: 32
            Lv6: 35
            Lv7: 38
            Lv8: 41
            Lv9: 44
            Lv10: 47
        }
    }
},

 

Mistress casting a level 28 Jupitel Thunder has no record of KnockBackTiles: which is for Level 28 = no record, no knockback

 

another thing in src/map/skill.h

 

Quote

#define MAX_SKILL_LEVEL           20

 

Max skill level is defaulted to 20 thus, a level 28 Jupitel Thunder will be defaulted to level 20, but since there is no record of Lv20: for KnockBackTiles: under WZ_JUPITELTHUNDER, no knockback will be made.

 

If you want to fix your problem (without compiling), simply add

Lv20: 7 - number of tiles to be knockback

 

Quote

{
    Id: 84
    Name: "WZ_JUPITEL"
    Description: "Jupitel Thunder"
    MaxLevel: 10
    Range: 9
    Hit: "BDT_MULTIHIT"
    SkillType: {
        Enemy: true
    }
    SkillInfo: {
        AllowReproduce: true
    }
    AttackType: "Magic"
    Element: "Ele_Wind"
    NumberOfHits: {
        Lv1: 3
        Lv2: 4
        Lv3: 5
        Lv4: 6
        Lv5: 7
        Lv6: 8
        Lv7: 9
        Lv8: 10
        Lv9: 11
        Lv10: 12
    }
    InterruptCast: true
    KnockBackTiles: {
        Lv1: 2
        Lv2: 3
        Lv3: 3
        Lv4: 4
        Lv5: 4
        Lv6: 5
        Lv7: 5
        Lv8: 6
        Lv9: 6
        Lv10: 7
        Lv20: 7
    }
    CastTime: {
        Lv1: 2500
        Lv2: 3000
        Lv3: 3500
        Lv4: 4000
        Lv5: 4500
        Lv6: 5000
        Lv7: 5500
        Lv8: 6000
        Lv9: 6500
        Lv10: 7000
    }
    CoolDown: 0
    Requirements: {
        SPCost: {
            Lv1: 20
            Lv2: 23
            Lv3: 26
            Lv4: 29
            Lv5: 32
            Lv6: 35
            Lv7: 38
            Lv8: 41
            Lv9: 44
            Lv10: 47
        }
    }
},

 

But you need to do that in every monster that you're having problem.

 

Make an issue in github so other developers see it.

 

Rathena made a way to make the last value entry in database to be the value for level that is not included

[Singe Horizontal 0]

Here are the overleveled skills

AL_DECAGI: 48
AL_HEAL: 11
BS_HAMMERFALL: 11
KN_BRANDISHSPEAR: 20
KN_TWOHANDQUICKEN: 20
MC_MAMMONITE: 20
MG_FIREBALL: 20
MG_THUNDERSTORM: 15
NPC_SUMMONSLAVE: 16
SM_MAGNUM: 20
WZ_FIREPILLAR: 11
WZ_JUPITEL: 28
WZ_METEOR: 11
WZ_SIGHTRASHER: 20
WZ_VERMILION: 20

[Daraen 7]

https://github.com/HerculesWS/Hercules/issues/2961