Item drop is bugged?

[Hyroshima 18]

Hi guys, maybe I'm doing something wrong that I haven't noticed yet.

the issue is that I didn't change the drop rates, I just went there on mob_db (mob_id 1101) and changed the item rate to 10000 (100%), so the item should drop whenever I kill mob 1101 correct? As I show in the video this does not happen.

I tested it in a review (19792) and in the current one and both present this result.

tested on renewal and pre-renewal both with same result.

https://streamable.com/r539vo

apparently it is correct as per this: https://github.com/HerculesWS/Hercules/pull/2970/commits/6f7680b47bcffaf6613f72b462f545e11d40957d

 

 

Edited March 22, 2022 by Hyroshima

[KeiKun 8]

 

Drops: {
	Scorpion_Card: 10000
}

Unable to reproduce the item not dropping twice, even though rates are maxed... 10000 = 100%

[Hyroshima 18]

1 hour ago, KeiKun said:

 

Drops: { Scorpion_Card: 10000 }

Unable to reproduce the item not dropping twice, even though rates are maxed... 10000 = 100%

apparently the problem is happening with rates at 1x (100) and the mob_db drop at 10000 (100%).

I found there on git in edits 2 related problem, a friend who has an older revision that doesn't have the current formula doesn't have this problem.

I did the same test in rA and it is normal without this problem.
my friend's is like this (because it's a previous review it's normal):

if (src) {
  //Drops affected by luk as a fixed increase [Valaris]
  if (battle_config.drops_by_luk)
    drop_rate += status_get_luk(src)*battle_config.drops_by_luk/100;
  //Drops affected by luk as a % increase [Skotlex]
  if (battle_config.drops_by_luk2)
    drop_rate += (int)(0.5+drop_rate*status_get_luk(src)*battle_config.drops_by_luk2/10000.);
}

and the current one is like this:

if (src != NULL) {
  //Drops affected by luk as a fixed increase [Valaris]
  if (battle_config.drops_by_luk)
    drop_rate += status_get_luk(src) * battle_config.drops_by_luk / 100;

  //Drops affected by luk as a % increase [Skotlex]
  if (battle_config.drops_by_luk2)
    drop_rate += (int)(0.5 + drop_rate * status_get_luk(src) * battle_config.drops_by_luk2 / 10000.);

 

and now it has this part:

if (sd != NULL) {
  int drop_rate_bonus = 100;

  // When PK Mode is enabled, increase item drop rate bonus of each items by 25% when there is a 20 level difference between the player and the monster.[KeiKun]
  if (battle_config.pk_mode && (md->level - sd->status.base_level >= 20))
    drop_rate_bonus += 25; // flat 25% bonus 

  drop_rate_bonus += sd->dropaddrace[md->status.race] + (is_boss(src) ? sd->dropaddrace[RC_BOSS] : sd->dropaddrace[RC_NONBOSS]); // bonus2 bDropAddRace[KeiKun]

  if (sd->sc.data[SC_CASH_RECEIVEITEM] != NULL) // Increase drop rate if user has SC_CASH_RECEIVEITEM
    drop_rate_bonus += sd->sc.data[SC_CASH_RECEIVEITEM]->val1;

  if (sd->sc.data[SC_OVERLAPEXPUP] != NULL)
    drop_rate_bonus += sd->sc.data[SC_OVERLAPEXPUP]->val2;

  drop_rate = (int)(0.5 + drop_rate * drop_rate_bonus / 100.);

  // Limit drop rate, default: 90%
  drop_rate = min(drop_rate, 9000);
}
}

 

I'm just reporting it and seeing if it's really a problem because I encountered this while doing a script and I wasn't getting the result I should have.

 

https://github.com/HerculesWS/Hercules/pull/3083

https://github.com/HerculesWS/Hercules/pull/2983
 

Edited March 12, 2022 by Hyroshima

[KeiKun 8]

It's not really a bug on current Hercules, even if i use a clean pre-re Hercules like here:

 

it looks fine, try to update your hercules.

 

EDIT:
just in case you're wondering... image shows me using @monster 1001 5 then proceed with @killmonster shows there that 5 monster dropped the cards as expected

Edited March 12, 2022 by KeiKun

[Hyroshima 18]

2 hours ago, KeiKun said:

It's not really a bug on current Hercules, even if i use a clean pre-re Hercules like here:

 

 

it looks fine, try to update your hercules.

 

EDIT:
just in case you're wondering... image shows me using @monster 1001 5 then proceed with @killmonster shows there that 5 monster dropped the cards as expected

I think you didn't see when I said that I tested both in an old and current revision and both present the same result.

the information is there, if anyone is willing to check the consistency or not, it doesn't matter.