my custom battleground *createbgid doesn't work on OnQuit when using battleground queue

[AnnieRuru 957]

http://upaste.me/43f410863b29f741e

 

that's weird

when I test on normal battleground script using waitingroom system, it works

[Debug]: script debug : 0 110000009 : Battleground Normal Start[Info]: Character 'EnnyRuru' logged off.[Debug]: script debug : 2000001 110000009 : Battleground Normal EnnyRuru quit battleground[Debug]: script debug : 0 110000009 : Battleground Normal Ends[Debug]: script debug : 2000001 110000008 : EnnyRuru has logout

.

.

but then I try again on the half-baked battleground queue, the OnQuit event doesn't work

[Debug]: script debug : 0 110000007 : Battleground Queue Start[Debug]: script debug : 2000000 110000007 : Battleground Queue AnnieRuru has dead[Debug]: script debug : 2000001 110000007 : Battleground Queue EnnyRuru has dead[Info]: Character 'AnnieRuru' logged off.[Debug]: script debug : 2000000 110000008 : AnnieRuru has logout

<OnDead> works, but <OnQuit> doesn't work ... funny ...

 

...

damn ... do I seriously need to learn how to use 12 script commands to make my queue battleground work ...

because hercules' flavious battleground OnQuit uses HQO_OnLogout and it doesn't bug on that script

Edited February 27, 2014 by AnnieRuru

[Dastgir 1246]

Queue is not specifically for bg, its an improved waitingroom, can be used with many events , etc.

 

Got the problem, its hercules bug(cant report/bug/pull request bcoz am on mobile) ,maybe its condition problem.

Map.c

if( sd->bg_id && !sd->bg_queue.arena ) /* TODO: dump this chunk after bg_queue is fully enabled */		bg->team_leave(sd,1);

As I think, that ! Should not be there, since if someone has bgid, it wont be null , this is causing the server to not execute the logoutevent of bg.(just done a quick analysis, it may be bigger problem, so bug report would be good, so dev can check in deep) or maybe that condition is correct, and its wip, bcoz theres an todo note over that line.

Edited March 1, 2014 by Dastgir Pojee

[sandbox 1]

Kinda of OT post.. But damn, the scripting Goddess is asking questions!?

[AnnieRuru 957]

Kinda of OT post.. But damn, the scripting Goddess is asking questions!?

scripting goddess is noob in source ... ok ?

in rathena forum I have scripting badge, but didn't get a source lvl1 badge ... because I'm noob in source coding

 

the question I'm asking is about my custom mod doesn't work on battleground queue system but works with waitingroom ...

so the problem is on the svn itself ...

[sandbox 1]

That's weird.. Script looks fine and should be working since you're the scripting Goddess! You shall smite the person who caused this problem once you've seen him! xD

[Dastgir 1246]

Cant find createbgid on source file, probably it is a custom scriptcommand?

So without its source, cannot point what is causing this problem.

Edited February 28, 2014 by Dastgir Pojee

[AnnieRuru 957]

Cant find createbgid on source file, probably it is a custom scriptcommand?

So without its source, cannot point what is causing this problem.

here

http://herc.ws/board/topic/4570-battleground-system-without-waitingroom/

.

.

.

That's weird.. Script looks fine and should be working since you're the scripting Goddess! You shall smite the person who caused this problem once you've seen him! xD

no, that person has been protected in "Admin" aura

my custom battleground script commands only needs 3, but official hercules battleground script commands has 12 !!

BUILDIN_DEF(queue,""),BUILDIN_DEF(queuesize,"i"),BUILDIN_DEF(queueadd,"ii"),BUILDIN_DEF(queueremove,"ii"),BUILDIN_DEF(queueopt,"ii?"),BUILDIN_DEF(queuedel,"i"),BUILDIN_DEF(queueiterator,"i"),BUILDIN_DEF(qicheck,"i"),BUILDIN_DEF(qiget,"i"),BUILDIN_DEF(qiclear,"i"),BUILDIN_DEF(bg_create_team,"sii"),BUILDIN_DEF(bg_join_team,"i?"),

.

.

why use so many script commands when I only need to use 3 ?

[AnnieRuru 957]

Got the problem, its hercules bug(cant report/bug/pull request bcoz am on mobile) ,maybe its condition problem.

Map.c

if( sd->bg_id && !sd->bg_queue.arena ) /* TODO: dump this chunk after bg_queue is fully enabled */		bg->team_leave(sd,1);

 

 

ahhh ! no wonder ...

I read battleground.c, but the culprit is at map.c

.

.

Queue is not specifically for bg, its an improved waitingroom, can be used with many events , etc.

currently its only meant for battleground because what I heard from Ind,

he says every party, guild and individual players will chunk together into 2 battleground team

so currently there is no way to set it into a guild vs guild or party vs party script yet,

until a battleground.conf setting can actually only enable the guild button, then only it can be use for guild vs guild script

.

.

As I think, that ! Should not be there, since if someone has bgid, it wont be null , this is causing the server to not execute the logoutevent of bg.(just done a quick analysis, it may be bigger problem, so bug report would be good, so dev can check in deep) or maybe that condition is correct, and its wip, bcoz theres an todo note over that line.

I rather think the whole "&& !sd->bg_queue.arena" should be remove

so it will become like

	if( sd->bg_id )		bg->team_leave(sd,1);

if that player is in any battleground team, they should leave when they log out

 

I think no need to report until they fully make this system functional ...

I also spotted a few bugs here and there ... this system is not yet finish anyways