Jump to content

malufett

Retired Staff
  • Content Count

    657
  • Joined

  • Last visited

  • Days Won

    29

Posts posted by malufett


  1. @status.c

     

    case SC_EDP: // [Celest]
    val2 = val1 + 2; //Chance to Poison enemies.
    val3 = 50*(val1+1); //Damage increase (+50 +50*lv%)
    #ifdef RENEWAL_EDP
    val4 = 100 * ((val1 + 1)/2 + 2);
    #endif
    if( sd )//[ind] - iROwiki says each level increases its duration by 3 seconds
      tick += pc->checkskill(sd,GC_RESEARCHNEWPOISON)*3000;
    break;

     

    :meow:


  2. use this :

        sc_start2(src, SC_CLOAKING, 100, 3, 1, skill->get_time(AS_CLOAKING, 3));

    then change this:

     

    case SC_CLOAKING:  //Avoid cloaking with no wall and low skill level. [Skotlex]  //Due to the cloaking card, we have to check the wall versus to known  //skill level rather than the used one. [Skotlex]  //if (sd && val1 < 3 && skill_check_cloaking(bl,NULL))  if( sd && pc->checkskill(sd, AS_CLOAKING) < 3 && !skill->check_cloaking(bl,NULL) )   return 0;  break;

    to

     

    case SC_CLOAKING:  if( val2 ) break;  //Avoid cloaking with no wall and low skill level. [Skotlex]  //Due to the cloaking card, we have to check the wall versus to known  //skill level rather than the used one. [Skotlex]  //if (sd && val1 < 3 && skill_check_cloaking(bl,NULL))  if( sd && pc->checkskill(sd, AS_CLOAKING) < 3 && !skill->check_cloaking(bl,NULL) )   return 0;  break;

     

    :meow:


  3. try this

    { if (getiteminfo(getequipid(EQI_ARMOR),5)==16 && @bgiven == 0) { bonus bAgi,5; set @bgiven,1;} if (getiteminfo(getequipid(EQI_GARMENT),5)==4 && @bgiven == 0) {bonus bVit,5; set @bgiven,1;}  },{},{set @bgiven,0;} 

    note: not yet tested...and the effect now is unstackable...

     

    :meow:


  4. more + refine weapon more dmg will get from EDP user ?

    yes..but there is a counter part min atk will get more lower..

     

    as you seen in your video your min atk turns hundred while in previous its thousands due to the increase of variance so ideally for sinx type suggested weapon for dual weilding is lvl1 or 2 weapon because of small amount of variance and doesn't increase much in EDP so you always(60~70%) deal max damage while in katar type suggested is a lvl 4 and crit build for a massive damage...so for an EDP type sinx its not recommended that you will be using SB or CI in PVP and take note sinx type is easy to have an aspd of 189+ if proper geared and buffed...

     

    :meow:


  5. some skills have to reduce their damage modifier to half such as sonic blow, counter slash & cross impact..

     

    if( sc && sc->data[SC_EDP] ){    skillratio -= addedratio;    if( skill_id == AS_SONICBLOW ||	 skill_id == GC_COUNTERSLASH ||	 skill_id == GC_CROSSIMPACT )	  skillratio >>= 1;    skillratio += addedratio; }

    and also damage variance become more wide/large when EDP is active since it only boost equip atk and weapon atk

    :meow:


  6. Thanks looks to works fine. Just a little more question? is it normal that item that give atk bonus like porcelio card, father white beard ect... don't increase dmg from spiral or from arrowstorm and many other skills? I have test with maximise power and nothing change.

    oh thanks...It seems that I deleted some lines about eatk..

    will fixed it shortly.. :D

     

    here you have it

     

    :meow:


  7. After testing last rev and compare with official.

    The varience looks different.

    And spiral pierce have wrong formula.

     

    But other things looks to works fine. Great job Malu you are the best =)

    I know now your problem.. it is related to this (Thanks to mofo)

    its not about the variance I already check it...its about the card increasing in skills where it was invoke twice..

     

    and I also updated Spiral Peirce it should now work 100% like official..:D

     

    :meow:


  8.  

    I'm using "giant cross bow" "id:18110" with no refine only the 160atk. Same with "elven bow" "id:1746" no refine.

     

    And with White wing suits I make more damage on iro than hercules.

    White wing ids: 2479, 2890, 2580, 15042

     

    Also have problem with spiral pierce. Damage are lower than iRo. Half damage with same spear. I'm using "hunting spear +10" "id: 1422"

    ah..ok..

     

    BTW spiral pierce is using iRo's suggested formula..anyway I'll update that into official ones..I just need to figure out something about it..:D

     

    :meow:


  9. Maximise power only show max dmg.

    The variation is to high. Just take any skill of any class on offi and try to atk lot of mob. Then do the same in hercules. You will see that you don't make big variation on offi but on hercules you make huge variation.

     

    And I retry the long range dmg and it's lower in hercules than in iRo. And I make less damage full stuff in hercules with long range bonus % than iRo. And spiral pierce not looks to be good too. really low dmg.

    well as I said its hard to determined min and max in official unless you will use level 1 weapon where the variances is low..I also do some debugging in aegis as sir Yommy taught me it gave me same result with weapon level 1 to 4 min and max..

     

    if still doubting I'll show you some code of aegis..

     

    if ( rhandpower )  {    v5 = 1;    v6 = CPC::GetITPEquipedWeapon(v4);    if ( v6 )	  v5 = v6->vfptr->GetItemLevel(v6);    if ( bRangeWeapon )// check if weapon is a ranged    {	  v8 = (double)rhandpower;	  v9 = (double)(5 * rhandpower * v5) / 100.0;	  v10 = (double)(rhandpower * (signed int)CPC::GetDexValue(v7));    }    else    {	  v8 = (double)rhandpower;	  v9 = (double)(5 * rhandpower * v5) / 100.0;	  v10 = (double)(rhandpower * (signed int)CPC::GetStrValue(v7));    }    v11 = v10 / 200.0; //str bonus    *(_DWORD *)(v1 + 8) = (signed int)(v8 - v9 + v11);//min damage    *(_DWORD *)(v1 + 12) = (signed int)(v8 + v9 + v11);//max damage  }

    same with Hercules

     

    if ( bl->type == BL_PC && watk->atk ){  if ( flag&2 )   dstr = status_get_dex(bl);  else   dstr = status_get_str(bl);   variance = 5.0f * watk->atk *  watk->wlv / 100.0f;  strdex_bonus = watk->atk * dstr / 200.0f;  min = (watk->atk - (int)(variance + strdex_bonus)) + watk->atk2;  max = (watk->atk + (int)(variance + strdex_bonus)) + watk->atk2;}else if( watk->atk ){ 

     

     

    :meow:


  10. variation?min and max?

    we have the exact formula in what official used..

     

    its just a matter of random number official uses a wide range number of random from 0 to 20000 whereas we uses 0 to 100 that is why its hard for you to determine max and min..if you  can just use Maximize Power to see result..hehe

     

    :meow:


  11. My test was using the last hercules git. And I see that in herc the damage are lower with long range atk than iro. The long range bonus looks to give more in iro too.

    oh..I forgot you used card(Desert Wolf Card)..and forgot to mention that along with the reduction also with the addition of damage currently is not yet perfect with skills...

     

    :meow:


  12. Hi,

    I have made some test with long range on iro. And if I use arrow storm with a gigantic bow with lvl 150 I make with stone arrow between 19500 and 22500 dmg but in herc I do 14200 - 21000 (it's aproximative) Can you give us a status on what missing please?

    I already fixed range attacks..we already have the same or exactly min and max atk from aegis, iRO or kRO...

     

    what we are missing right now is the damage reductions in skills where it invoke twice officially and I'm looking where it was located and its other factor..

     

    :meow:


  13. possibilities:

    function is not define in .h files

    function has a return type but no possible return value

    function is not define in the .c file if its an static function

    function has a return type that is not compatible to the function data type

    function's parameter doesn't match with the definition 

     

    IMO..:D

     

    :meow:


  14. windows 8? hehehe..pero taka lang ako iba kasi yung nasa console log mo eh...

     

    In file included from core.c:5:../common/mmo.h:51: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'PACKETVER'make[1]: *** [obj_all/core.o] Error 1make[1]: Leaving directory `/home/impulse/eathena/src/common'make: *** [common_sql] Error 2

     

    :meow:

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.