Jump to content

Yommy

Community Contributors
  • Content Count

    290
  • Joined

  • Last visited

  • Days Won

    29

Posts posted by Yommy


  1. i guess its something to do with extra data in equips, that bindonequip collumn was added, and other changes, etc

     

    anyway the whole plugin is coded crappy, and using the new plugin hooks it could be made much more efficiently

    currently it loops every vender every few minutes and empties the vend sql and refills it..every few minutes O_O

     

    it should be rebuilt with hooks of the create_vend, close_vend, sell_vend functions, (not sure of actual function names from my head)

    and update the vend table from these hooks, so there is only a small sql update when something happens, instead of flooding every minutes..

     

    however i lack the time to do this :(


  2. bUnbreakableShoes,0;

     

    this should be like

    bonus bUnbreakableShoes,0;

     

     

     

    also, the one with missing ;

    bonus bSubRace,RC_Demihuman,3;

    this should be

    bonus2 bSubRace,RC_Demihuman,3;


  3. I agree it's readable. Format is good but line consuming. Parsing is not that fast. Size of file increase.

    lines are not some valuable resource that will run out, and file size does not increase as much as you think it would.

    685kb -> 1023kb (pre-re)

    887kb -> 1353kb (re)

     

     

    I wish someone make the convertor instead the online convertor. :)

    its already in the repo

    https://raw.github.com/HerculesWS/Hercules/master/tools/itemdbconverter.pl

     

    And about it not being that fast, its actually faster

    [13:48] <Haruna> [11:07:48] <Yommy>   Haruna, does new item_db format take longer to load ? <--- likely, but not in a human-perceivable form, I believe *benchmarks*

    [13:57] <Haruna> takes about 57ms to do the entire parsing and validation

    [14:13] <Haruna> Lol, guess what? The old version takes longer :D

    [14:13] <Haruna> 95ms

    [14:14] <Haruna> old:  (repeated 1000 times in 95603 ms total).

    [14:14] <Haruna> new:  (repeated 1000 times in 57390 ms total).

    [14:14] <Haruna> :D


  4. actually, your accounts are set to 0% exp, because the sql update that made the columns defaulted them to zero.

    then another update made the default as 100, but they already got set to zero

     

    UPDATE `account_data` SET `base_exp`=100, `base_drop`=100, `base_death`=100;

    this is 100% of your rates, (not 100x rates).

     

    Yom

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.