Hercules Battlegrounds

[ljsb 9]

Great plugin!

I've just pushed an implementation so that team emblems are displayed on the character's head instead of swords.

Edited January 12, 2018 by LucasBrito

[ljsb 9]

On 15/12/2017 at 10:20 AM, caspe said:

Alguém pode consertar isso?

On 25/11/2017 at 2:59 AM, melv0 said:

someboody can help me to fix this error??

Fixed in pull #36, f963865

Awaiting @Smoke approval. 

Edited January 12, 2018 by LucasBrito

[astralprojection 35]

On 1/12/2018 at 8:57 AM, LucasBrito said:

Great plugin!

I've just pushed an implementation so that team emblems are displayed on the character's head instead of swords.

how about this issue? did you managed to fix also?  https://github.com/Smokexyz/HerculesBG/issues/32
 

[Sephus 203]

@LucasBrito I've reviewed the PR and left a comment. Please check it as you can.

Thanks for contributing.

[ljsb 9]

@Smoke Answered. It is a pleasure to collaborate with this project!

@astralprojection I'll check it as soon as I can.

[astralprojection 35]

im getting this error on latest Herc
 

hBG.c: In function ‘hBG_addflooritem_area’:
hBG.c:1950:3: error: too few arguments to function ‘map->addflooritem’
   count += (map->addflooritem(bl, &item_tmp, 1, m, mx, my, 0, 0, 0, 4) != 0) ? 1 : 0;

 

[ljsb 9]

On 13/01/2018 at 7:31 PM, astralprojection said:

how about this issue? did you managed to fix also?  https://github.com/Smokexyz/HerculesBG/issues/32
 

On what client does this error occur?

[astralprojection 35]

4 hours ago, LucasBrito said:

On what client does this error occur?

thanks for asking @LucasBrito  i experience at 2015-10-29aRagexe

[astralprojection 35]

On 1/16/2018 at 9:37 PM, astralprojection said:

im getting this error on latest Herc
 

hBG.c: In function ‘hBG_addflooritem_area’:
hBG.c:1950:3: error: too few arguments to function ‘map->addflooritem’
   count += (map->addflooritem(bl, &item_tmp, 1, m, mx, my, 0, 0, 0, 4) != 0) ? 1 : 0;

 

Please help on this @LucasBrito @Smoke  thanks guys this plugin is amazing.

[caspe 16]

On 1/16/2018 at 7:07 PM, astralprojection said:

im getting this error on latest Herc
 

hBG.c: In function ‘hBG_addflooritem_area’:
hBG.c:1950:3: error: too few arguments to function ‘map->addflooritem’
   count += (map->addflooritem(bl, &item_tmp, 1, m, mx, my, 0, 0, 0, 4) != 0) ? 1 : 0;

 

same here, look like another emulator update cause this problem.

[astralprojection 35]

i figure it out, just change to

count += (map->addflooritem(bl, &item_tmp, 1, m, mx, my, 0, 0, 0, 4, false) != 0) ? 1 : 0;

Asheraf committed 26 days ago  Add support for new drop packet 0xadd for zero clients 

[ljsb 9]

On 17/01/2018 at 3:40 AM, astralprojection said:

thanks for asking @LucasBrito  i experience at 2015-10-29aRagexe

Please send me a complete 2015 client (data folder + hexed) through Google Drive so I can run the tests. I have no time to ride.

[ljsb 9]

@astralprojection Apply this fix and make sure everything is fine. I did not test on newer clients, only < 2012.

[caspe 16]

@Smoke

how can i fix this?

in the end the message does not show in proper language.

[bWolfie 138]

2 hours ago, caspe said:

@Smoke

how can i fix this?

in the end the message does not show in proper language.

https://github.com/HerculesWS/Hercules/pull/1890

[caspe 16]

@Myriad i tested this, but not work

btw on GM char i can see message clearly

 

Also it seem ip check function not working

hBG_ip_check: 1

 

[caspe 16]

@Smoke @LucasBrito can u revert BG emblem update?

because in newer client guild emblem does not show in BG map or require EnbleBGEmblem patch which has alignment problems.

better show battleground emblem at top of players head than show nothing. User can easily remove BG sword emblem by making them transparent.

Also if possible please check IP_check function, because it is not working.

[bWolfie 138]

40 minutes ago, caspe said:

@Smoke @LucasBrito can u revert BG emblem update?

because in newer client guild emblem does not show in BG map or require EnbleBGEmblem patch which has alignment problems.

better show battleground emblem at top of players head than show nothing. User can easily remove BG sword emblem by making them transparent.

Also if possible please check IP_check function, because it is not working.

Just installed this plugin, wanted to try it out. I'm unsure what it was like before, but seems the BG Guild Emblems are not displaying correctly.
https://github.com/Smokexyz/HerculesBG/issues/39

@caspe it would be better to include #if PACKETVER <= clientver, replacing clientver with the last known compatible one. I'm not familiar with this plugin, but I guess it would be this part?
 

	/* Display emblem on head of char [lucaslsb] */
#if PACKETVER <= 20141022
	if (hBG_enabled && sd->state.changemap && map->list[sd->bl.m].flag.battleground)
		clif->map_type(sd, MAPTYPE_BATTLEFIELD);
	if (hBG_enabled && map->list[sd->bl.m].flag.battleground)
		clif->map_property(sd, MAPPROPERTY_AGITZONE);
#endif

and then,

		// clif interface overloading [lucaslsb]
#if PACKETVER <= 20141022
		clif->sendbgemblem_area = clif_sendbgemblem_area_overloading;
		clif->sendbgemblem_single = clif_sendbgemblem_single_overloading;
#endif

but after testing, it seems this is pointless, as the newer clients show the emblems just fine (read below). Better to add a config for whether you'd rather show the sword or not.

 ALSO your alignment issue is not exclusive to guild emblems. It's to do with the zoom in/out of your client. It can happen with some headgears to, such as ugly ass wings.

Exhibit A, zoomed in.

Exhibit B, zoomed to an appropriate amount.

Edited February 6, 2018 by Myriad

[Stupidity 0]

Is this plugin stable?

The BG emblem is show properly in what client versions? 

Thanks in Advance .

[caspe 16]

@Myriad Thanks for reply

Tested with 2015-10-29aRagexe client and emblem show property with enablebgemblem patch, no need to revert BG emblem changes.

Need to check other problem's. 

@Stupidity Use 2015-10-29aRagexe or 2012 client

[bWolfie 138]

@caspe you don't suffer from this issue? If not, could you PM me your Nemo profile? As I'm using the same client.

Edited February 6, 2018 by Myriad

[caspe 16]

IP_check function function working but it still allow 2 same ip user's to connect

it block 3rd user from joining BG

[caspe 16]

compile warning on Ubuntu

hBG.c: In function ‘atcommand_reportafk’:
hBG.c:2040:31: warning: unused variable ‘hBGsd’ [-Wunused-variable]
  struct hBG_map_session_data *hBGsd = NULL;
                               ^
hBG.c: In function ‘atcommand_leader’:
hBG.c:2084:31: warning: unused variable ‘hBGsd’ [-Wunused-variable]
  struct hBG_map_session_data *hBGsd = NULL;
                               ^
hBG.c: In function ‘status_get_guild_id_pre’:
hBG.c:3776:31: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
   && (bg_id = bg->team_get_id((struct block_list *)*bl)) > 0
                               ^
hBG.c: In function ‘status_get_emblem_id_pre’:
hBG.c:3797:31: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
   && (bg_id = bg->team_get_id((struct block_list *)(*bl))) > 0
                               ^
hBG.c: In function ‘char_bgstats_tosql’:
hBG.c:4242:4: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘unsigned int’ [-Wformat=]
    "REPLACE INTO `char_bg_stats` ("
    ^
hBG.c: In function ‘hBG_build_guild_data’:
hBG.c:1719:4: warning: ignoring return value of ‘fread’, declared with attribute warn_unused_result [-Wunused-result]
    fread(&bg_guild[j].emblem_data, 1, bg_guild[j].emblem_len, fp);
 

[bWolfie 138]

caspe you should report on the github issues rather than here.

i made an issue for the first four. it's self-explanatory why the compiler is warning you for reportafk and leader: https://github.com/Smokexyz/HerculesBG/issues/38

[caspe 16]

@Smoke this plugin having lot's of issue on ubuntu,

@Myriad i'm getting emblem problem, which u have mentioned

Also players need to use Shift to hit players.

 

I was testing this plugin on windows 7 & using visual studio to compile, now after adding it to the server which is hosted on Ubuntu.

many problem's start occurring.

 

OR can anyone tell me how should i build this plugin on Ubuntu? i'm using make plugins command