Where can I find the commit for getvariableofpc()

[bWolfie 138]

Hi, I want to know where I can find the commit for adding of getvariableofpc() script command. I am running old version of Herc (2016) and want to add this to my source.

[tedexx 7]

https://github.com/HerculesWS/Hercules/commit/1b0d3bd8f84db5b471646e0404193759afb908db

[bWolfie 138]

https://github.com/HerculesWS/Hercules/commit/1b0d3bd8f84db5b471646e0404193759afb908db

 

Thanks! Works.

 

Now I have a second question for anybody who may know.

How come # variable is on the excluded list? Would there be issues if I removed it from here?

 

 

    switch (*name)
    {
    case '#':
    case '$':
    case '.':
    case '\'':
        ShowError("script:getvariableofpc: illegal scope (not pc variable)\n");
        script->reportdata(data);
        script_pushnil(st);
        st->state = END;
        return false;
    }

[Dastgir 1246]

 

https://github.com/HerculesWS/Hercules/commit/1b0d3bd8f84db5b471646e0404193759afb908db

 

Thanks! Works.

 

Now I have a second question for anybody who may know.

How come # variable is on the excluded list? Would there be issues if I removed it from here?

 

    switch (*name)
    {
    case '#':
    case '$':
    case '.':
    case '\'':
        ShowError("script:getvariableofpc: illegal scope (not pc variable)\n");
        script->reportdata(data);
        script_pushnil(st);
        st->state = END;
        return false;
    }

https://github.com/HerculesWS/Hercules/commit/03f416eda0b0d1aeef03516863e11916e75660cd

It was fixed later on.