Failed assertion Achievement

[MikZ 5]

Good day!

I found this error in my map server.

What does this mean?

achievement.c:727: 'amount ! =0! in function 'achievement_validate_zeny
./map-server() [0x62c013]
./map-server() [0x408f03]
./map-server() [0x51f569]
./map-server() [0x50b1c1]
plugins/HPhooking_map.so(HP_npc_sellist+0x97) [0x7f8d12f9757]
./map-server() [0x46a51a]
./map-server() [0x4abddf]
./map-server() [0x637fde]
./map-server(main+0x2ca) [0x40844a]
/lib64/libc.so.6(==libc=start=main+0xf5) [0x7f8df3a31445]

 

please help me fix this. thanks!

[meko 170]

@MikZ this PR should fix your issue: https://github.com/HerculesWS/Hercules/pull/2227

[meko 170]

 'amount ! =0! in function 'achievement_validate_zeny

this is pretty explicit, it means you put a zeny achievement in the achievement db with Goal: 0, which is invalid, because players cannot spend -0 or gain +0 zeny

[MikZ 5]

6 minutes ago, meko said:

 'amount ! =0! in function 'achievement_validate_zeny

this is pretty explicit, it means you put a zeny achievement in the achievement db with Goal: 0, which is invalid, because players cannot spend -0 or gain +0 zeny

Hi, I just updated my git. Where to find this achievement thing?

[meko 170]

db/(pre-)re/achiemement_db.conf

[MikZ 5]

3 hours ago, meko said:

db/(pre-)re/achiemement_db.conf

@meko I cannot find any goal: 0, and i didn't touch this part.

EDIT by meko:
https://0bin.net/paste/CvdHKAJrVAvguh9T#qM5mdxGE3dTyBzf+TwsoGQMZADrr2VGohwO8eDKc3A5

(please use a pastebin service when you have a lot of lines to paste)

 

[meko 170]

@MikZ yes, nevermind, it seems this function is actually called from pc.c when a player spends or obtains zeny.
I'll submit a patch shortly

[MikZ 5]

Thanks!