gold_rank not working (rathena)

[Xombie 0]

On 9/28/2020 at 5:09 AM, AnnieRuru said:

that's because the monster with event labels doesn't trigger OnNPCKillEvent

this has been discuss for years and there are no perfect solution to solve this issue

EDIT: it seems there is, Kenpachi suggest we add another flag to monster spawn with or without event labels

anyway this is developer talk ...

 

to fix your problem just need to remove the OnNPCKillEvent label and incorporate it into OnKill label

 

by the way I have no idea why your screenshot shows so many kills, the `gold_rank` field has been default to 0 in the SQL syntax...

try create another table to solve those incorrect value kills then

 

I don't think its a good idea to run query_sql inside OnNPCKillEvent label, since this script is made for high rate server and players can kill peco fast

so I made minor changes

 

https://gist.github.com/AnnieRuru/6f41d54b03417a768167820ee6f1f037

i try this script but whn i killed on gold room map ranking not updated

Edited October 1, 2020 by AnnieRuru
split topic from https://herc.ws/board/topic/18918-gold_rank-not-working/

[AnnieRuru 957]

Just now, Xombie said:

i try this script but whn i killed on gold room map ranking not updated

I don't recommend to put query_sql inside OnNPCKillEvent

the ranking only update when you exchange into gold

[Bringer 0]

59 minutes ago, AnnieRuru said:

I don't recommend to put query_sql inside OnNPCKillEvent

the ranking only update when you exchange into gold

ranking base on how many gold you get not kill.. do you have another version for Killed Ranking?

[AnnieRuru 957]

https://gist.github.com/AnnieRuru/6f41d54b03417a768167820ee6f1f037/revisions

 

don't come to me saying this script causes lag on your server

 

[Bringer 0]

On 9/28/2020 at 9:12 PM, AnnieRuru said:

https://gist.github.com/AnnieRuru/6f41d54b03417a768167820ee6f1f037/revisions

 

don't come to me saying this script causes lag on your server

 

hello again i try to convert on rathena but the kill ranking is not working 

https://pastebin.com/bZyjxMEN

[AnnieRuru 957]

so many rathena members here ... at least please put it on your profile so people like us don't have to do convert it again to rathena blah blah

 

so many mistakes on your script

1. the checkweight should check from the variable from the *input, if you put check on goldPoint then if players actually farm high amount they might forever said being overweight

2. the overall ranking you put it this way

		for (.@i = 0; .@i < .@nb; ++.@i)
			mes "[ ^C6A518Gold Room Assistant^000000 ]";
			mes (.@i +1)+". "+ .@name$[.@i] +" - "+ .@ppk[.@i] +" Kills";

should be this way

		mes "[ ^C6A518Gold Room Assistant^000000 ]";
		for (.@i = 0; .@i < .@nb; ++.@i)
			mes (.@i +1)+". "+ .@name$[.@i] +" - "+ .@ppk[.@i] +" Kills";

3. and the "your current rank" can be found on the pinned topic

4. rathena don't support strcharinfo(PC_MAP), it just strcharinfo(3)

5. finally its `Points` not `Kills`, this script gives random 1~3 points per kill, and the SQL table log in points not kills

 

https://gist.github.com/AnnieRuru/88e558b500a6e4afe00b559e7dcacd1b