Can someone convert this to Hercules?

[karazu 33]

Critical on magic

http://rathena.org/board/topic/71862-critical-hit-on-magic-2/ 

http://rathena.org/board/topic/71862-critical-hit-on-magic-2/ 

and this

Auto attack like BOT

http://rathena.org/board/topic/71297-autoattack/ 

http://rathena.org/board/topic/71297-autoattack/ 

I tried patching them here in hercules but its getting rejected

Edited October 16, 2013 by karazu

[quesoph 105]

test it...

71862-critical-hit-on-magic-2.patchFetching info...

71297-autoattack.patchFetching info...

[karazu 33]

wow, that was fast yes I will test this ASAP

[karazu 33]

  On 10/16/2013 at 12:47 PM, quesoph said:

test it...

71862-critical-hit-on-magic-2.patch

71297-autoattack.patch

No error in patching. I think its working now.

 

I will try this in game and I willl update you

[karazu 33]

  On 10/16/2013 at 12:47 PM, quesoph said:

test it...

71862-critical-hit-on-magic-2.patch

71297-autoattack.patch

I tried it in the latest SVN and I got patched rejected

 

--- src/map/atcommand.c+++ src/map/atcommand.c@@ -9677,6 +9731,7 @@  ACMD_DEF(searchstore),  ACMD_DEF(costume),  ACMD_DEF(skdebug),+ ACMD_DEF(autoattack),  };  AtCommandInfo* cmd;  int i; 

--- src/map/atcommand.c+++ src/map/atcommand.c@@ -9677,6 +9731,7 @@		 ACMD_DEF(searchstore),		 ACMD_DEF(costume),		 ACMD_DEF(skdebug),+		ACMD_DEF(autoattack),	 };	 AtCommandInfo* cmd;	 int i; 

 

 

EDIT the @auto attack is having a conflict with this

 

 

http://herc.ws/board/files/file/51-costume-system/ 

http://herc.ws/board/files/file/51-costume-system/ 

But 

 

http://herc.ws/board/files/file/51-costume-system/ 

http://herc.ws/board/files/file/51-costume-system/ 

with 

 

 

71862-critical-hit-on-magic-2.patch 

71862-critical-hit-on-magic-2.patch 

is ok together 

Edited October 16, 2013 by karazu

[quesoph 105]

manual patch it.

or if it has errors then post it.

Edited October 16, 2013 by quesoph

[karazu 33]

ok i will thank you
 

[karazu 33]

I did try to manually Patch it. eww it doesnt work, maybe I copied it wrong lol.

[Mhalicot 392]

because don't just copy and paste it.. read the error/syntax then try to figure out why..

[karazu 33]

  On 10/16/2013 at 5:49 PM, sevenzz23 said:

because don't just copy and paste it.. read the error/syntax then try to figure out why..

Hello sevennzzz23 if u remember I did just learned about Tortoise days ago. so I think that should be the reason why i cannot do what u think

[jaBote 438]

It's always a good time for learning.

[karazu 33]

  On 10/17/2013 at 10:55 AM, jaBote said:

It's always a good time for learning.

The problem is I dont know how to edit patch.

 

 

I have the idea since in those both patches they will insert a command next to the default that is found  atcommand

 

 

         ACMD_DEF(searchstore),  ACMD_DEF(costume),  ACMD_DEF(skdebug),+ ACMD_DEF(autoattack), <---THIS ONE 

         ACMD_DEF(searchstore),		 ACMD_DEF(costume),		 ACMD_DEF(skdebug),+		ACMD_DEF(autoattack),    <---THIS ONE 

 

while also in the 

 

http://herc.ws/board/files/file/51-costume-system/ 

http://herc.ws/board/files/file/51-costume-system/ 

this will also add a command on same line. (that maybe the cause of the error.)

 

 

Edited October 17, 2013 by karazu

[themon 63]

I doesn't work so many undefined stuff.

need to find same value from rathena to hercules

example

rathena "clif_displaymessage" in hercules "clif->message"

return -1; return false;

return 0;   return true;

in autoattack

map_foreachinarea ?

unit_attack ?

unit_walktoxy   ?

[quesoph 105]

you dont need to edit the patch. just go to ../src/map/atcommand.c

find: ( CTRL + F )

ACMD_DEF(skdebug),

ACMD_DEF(skdebug),

addACMD_DEF(autoattack),

ACMD_DEF(autoattack),

it should look like: ACMD_DEF(skdebug), ACMD_DEF(autoattack),

         ACMD_DEF(skdebug),         ACMD_DEF(autoattack),

@themon

try this

  On 10/16/2013 at 12:47 PM, quesoph said:

test it...

71862-critical-hit-on-magic-2.patch

71297-autoattack.patch

Edited October 17, 2013 by quesoph

[themon 63]

the @autoattack works on hercules now. but this isn't the one that I played before.

the one that I played before only attack the one that I choose to attack.

 

ex. I attack a poring and after killing that poring if their are still poring near me it will attack it also.

and when their is no poring near my character will just stop and doesn't wonder off like i this patch.

and one thing I remember is that I don't even have to type @autoattack or anything.

I just need to click on the monster I want to attack and I will attack all the same monster in my sight.

 

I wish the can put I on hercules. cause I played that on rathena that I can't even remember the client date but its ragexere.exehercules @autoattack.rar

Edited October 17, 2013 by themon