Implemented Motd change suggestion

[Beret 50]

Looking at the file motd.txt I see that there is no need to keep only a line in the file. My suggestion is the following pass reading motd.txt to source or perhaps for messages.conf.

Edited June 25, 2013 by jaBote

[Ind 945]

good point.

[Mystery 594]

Moving to Feedback centre.

 

I agree it's a good point. Why have an additional file with just one line? Why not have it merged? xD

[jaBote 438]

As long as I know, no server admin I know uses it and they just modify/disable that if they want/know. So I think it'd be a good idea to put it on the messages.conf file as Beret says (reserving a number of lines for it for example) or well simply remove it. I'm almost certain that not much people would miss it, but I'd prefer to put it on the messages.conf.

[frenzmu06 5]

or we can expand motd to accept scriptlike commads?

[Squishyyy 1]

  On 4/5/2013 at 4:59 AM, frenzmu06 said:

or we can expand motd to accept scriptlike commads?

can it not already?

[Ind 945]

  On 4/5/2013 at 4:59 AM, frenzmu06 said:

or we can expand motd to accept scriptlike commads?

how about we drop the motd.txt file and make it a onpcloginevent npc script?

[frenzmu06 5]

wouldn't that degrade performance?

and i think map server throws error from too much npc w/ like onevent npcs

[Ind 945]

  On 5/17/2013 at 12:30 AM, frenzmu06 said:

wouldn't that degrade performance?

hardly, would be run only when a character log in, and it'd be waaay more flexible and customisable, with all the things that a npc script can do.

  On 5/17/2013 at 12:30 AM, frenzmu06 said:

and i think map server throws error from too much npc w/ like onevent npcs

yes it does, we could make it not count towards that limit though

[Judas 100]

  On 5/17/2013 at 12:22 AM, Ind said:

 

  On 4/5/2013 at 4:59 AM, frenzmu06 said:

or we can expand motd to accept scriptlike commads?

how about we drop the motd.txt file and make it a onpcloginevent npc script?

I agree on dropping motd file. If we go through of it being an npc script, we just have to make sure players know that the file for controlling this is in directory X. I know a lot of people say, just get rid of those lines. Is there any customizations we can do this script? Some people like to tweak it to display relavant information about their server.

[frenzmu06 5]

sounds good ind, go ahead +1

[mkbu95 34]

I say put a file in npc folder that is no activated, and drop motd right now.

[Ind 945]

added in https://github.com/HerculesWS/Hercules/commit/9080a58e2184eeb36b30e6dc653ec5459b3acfb1

  On 5/17/2013 at 2:22 AM, mkbu95 said:

I say put a file in npc folder that is no activated, and drop motd right now.

dropped, didn't make it deactivated because I found it'd be better active, so people unaware of this change won't think the feature as a whole was dropped.