[Warning]: pc_bonusX: display itemID

[evilpuncker 504]

based on all info here, I want to suggest the addition of itemID in that warning message so we can know which item is the one that we should fix instead of looking everywhere with no clue on where to start!

 

 

here is a diff that Cydh made for rA, I guess we can adapt it to Hercules as well...

 

pc_bonus_warnings.diff

[Dastgir 1246]

based on all info here, I want to suggest the addition of itemID in that warning message so we can know which item is the one that we should fix instead of looking everywhere with no clue on where to start!

 

 

here is a diff that Cydh made for rA, I guess we can adapt it to Hercules as well...

 

pc_bonus_warnings.diff

I had a talk about this with Haru, and this isn't that simple,

There's some other things like pet/combo/status which run this function, and thus need more checking to display what caused the error and display it.

Surely this would be implemented soon..

[mrlongshen 22]

@@Dastgir Its good to hear that

[daim 6]

yeah, this function very important. Hope this can be done soon. Thanks to dev.

[kyeme 71]

Up~

[Dastgir 1246]

If I remember well, if we implement this, we probably need to implement other errors too, like what if error is from pet?

[Skyline 23]

 

I agree that Warning msgs should be improved, something like

[Warning]: itemid:xxxx pc_bonus: unknown type
[Warning]: itemid:aaaa pc_bonus2: unknown type
[Warning]: itemid:bbbb pc_bonus3: unknown type
[Warning]: itemid:ccc pc_bonus5: unknown type

 

Uhh yo so can we re-suggest this?

 

 

Credits to Angelmelody.

[evilpuncker 504]

http://herc.ws/board/topic/9332-warning-pc-bonusx-display-itemid/

 

I did it already

[Skyline 23]

http://herc.ws/board/topic/9332-warning-pc-bonusx-display-itemid/

 

I did it already

Oh brilliant.

 

ALL HAIL!

 

Edit: I tried to add it manually but I can't find the line in pc.c

You sure this is compatible with the latest build? o.o

Edited March 19, 2016 by Skyline

[Mystery 594]

Merged.

[Dastgir 1246]

Update:

We recently introduced assert report for this, so one can know which function(in src) is causing it

https://github.com/HerculesWS/Hercules/commit/8846818298750048288a39dc8072e15c7e67456d

[evilpuncker 504]

Update:

We recently introduced assert report for this, so one can know which function(in src) is causing it

https://github.com/HerculesWS/Hercules/commit/8846818298750048288a39dc8072e15c7e67456d

 

still no item id I guess? xD or am I missing anything here? can you give us an example?

[Cretino 48]

I did some changes and works fine.

It can still be improved.

 

@EDIT

Little fix.

 

@EDIT2

Other fix in pet script warning. (Little mistake >.<)

 

pc_bonus_warning_v3.patch

pc_bonus_warning_v2.patch

pc_bonus_warning.patch

 

Edited March 31, 2016 by Cretino