Ind 945 Posted June 23, 2013 (edited) Official Item Group/Package/Chain Overview Implementation of the official 'Item Packages', 'Item Group' redesign, 'Item Chain' implementation. item_group.conf : Overview / Sample The file was redesigned to make it attend the official equivalent's and to be more flexible, there are no more limitations on the number of groups or on how many items a group may contain, these limitations were lifted. Old_Card_Album: ( // <= <Container_Item_Name> ("Poring_Card",8), // <= entries can be either ( "<Item_Name>", <Repeat_Count> ) "Sting_Card" // <= or "<Item_Name>" (no repeat) ) item_packages.conf : Overview / Sample The file was created to meet the requirements of the official 'Package Item' feature, there are no limitations on how many packages you may add either. Gift_Bundle: { // <= <Container_Item_Name> White_Slim_Potion: {// <= <Entry_Item_Name> Random: false //May be omit when not false, signs whether a item is random or should be given whenever the packageis consumed. Count: 30 //May be omit when not higher than 1, stands for how many <White_Slim_Potion> } Muffler_: { Expire: 2 //May be omit when none, signs how many hours this item will last (makes a rental item) Announce: True //May be omit when false, signs whether to relay a special item obtain announce when this item comes out of the package. Rate: 50 //May be omit when 'Random' is false, from 1 to 10000 (0.01% - 100%) Named: True //May be omit when false, signs whether the item should have the owner's name in it. } } item_chain.conf : Overview Officially this thing is called groups too but I found it'd be confuse to have 2 group files with entirely different functionality, named chains because the items in it are chained to each other, this file fixes quite a few stuff, for example before this patch having BS_FINDINGORE drop something was almost twice as rare than on official servers, also fixes Jewel_Sword, Gaia_Sword, Blazzer_Card, Tengu_Card and Bogy_Horn. New 'packageitem' script command, it has only 1 param which is optional, for the package item id, when not provided it'll try to use the item id from the item it is being used from (if called from an item script), it runs a item package and grants the items accordingly to the attached player. Changes '#define MAX_RANDITEM' and '#define MAX_ITEMGROUP' were dropped, these limitations no longer exist and the server may support an unlimited number of item groups. 'item_findingore.txt' was dropped, its contents moved into 'item_chain.conf' 'item_bluebox.txt', 'item_cardalbum.txt', 'item_giftbox.txt', 'item_misc.txt', 'item_violetbox.txt' and 'item_group_db.txt' were dropped, its contents moved were updated and moved into 'item_group.conf' 'bonus2 bAddItemHealRate' changed; as group ids no longer exist. 'bAddMonsterDropItemGroup' was renamed to 'bAddMonsterDropChainItem' and changed from bonus 2/3 to bonus (0)/2 as the rate param was dropped because item chains have their own individual rates. Item names are now automatically made constants, so they may be used in any scripts throughout the server e.g. 'getitem Apple,1;', this works for all items except those having ' in their names (e.g. doesn't work for 'Monster's_Feed'). 'getrandgroupitem' and 'grouprandomitem' were modified since group ids no longer exist, item ids should be used instead (or constants as the item above mentions), e.g. 'getrandgroupitem Old_Blue_Box,1;' or 'getrandgroupitem 603,1;' Dropped conf/battle/drops.conf 'finding_ore_rate' for it has no place in the official formula (if you'd like to modify finding ore rates, edit them via item_chain.conf) Special Thanks Beret and hemagx for bringing this change up to discussion, and the data they contributed into it Yommy and Muad_Dib for all the new item data implemented in this commit (a hell of stuff! THANK YOU BOTH <3) Streusel for all the over 100 new items he converted Gepard for the group item repeat info Masao for his debugging of the monster spawn issue Mysterious for updating the documentation Link~u! Commit Edited February 7, 2017 by Ridley 13 Diurnal, Xgear, evilpuncker and 10 others reacted to this Quote Share this post Link to post Share on other sites
Xgear 44 Posted June 23, 2013 Yet another improvement. Thumbs up again to y'all! Quote Share this post Link to post Share on other sites
JulioCF 105 Posted June 23, 2013 very nice, thanks! Quote Share this post Link to post Share on other sites
Beret 50 Posted June 23, 2013 I am happy to help the community. Let's turn the aegis xD. Quote Share this post Link to post Share on other sites
kyeme 71 Posted June 24, 2013 I cant open some boxes like Special_Box, Pet_Egg_Scroll9 etc etc.? Quote Share this post Link to post Share on other sites
Jedzkie 58 Posted June 24, 2013 I cant open some boxes like Special_Box, Pet_Egg_Scroll9 etc etc.? i confirming it. Quote Share this post Link to post Share on other sites
ossi0110 200 Posted June 24, 2013 (edited) I cant open some boxes like Special_Box, Pet_Egg_Scroll9 etc etc.? i confirming it. its because this items dont have a script command , they are just items ^^ Edited June 24, 2013 by ossi0110 Quote Share this post Link to post Share on other sites
Jedzkie 58 Posted June 24, 2013 I cant open some boxes like Special_Box, Pet_Egg_Scroll9 etc etc.? i confirming it. its because this items dont have a script command , they are just items ^^ Even if there are script in the items like "packageitem();" its not working. Quote Share this post Link to post Share on other sites
Ind 945 Posted June 24, 2013 I cant open some boxes like Special_Box, Pet_Egg_Scroll9 etc etc.?The item scripts for some of these boxes are not yet (even though its just a 'createpackage();'), I'll see that it gets updated today. I cant open some boxes like Special_Box, Pet_Egg_Scroll9 etc etc.? i confirming it. its because this items dont have a script command , they are just items ^^ Even if there are script in the items like "packageitem();" its not working. Can you tell me a example so I can try to reproduce? I tested with 12542 (fortune cookie) and I got the items Quote Share this post Link to post Share on other sites
Ind 945 Posted June 24, 2013 By the way I've fixed the problem with the random package rates (thanks to Beret!), also added the missing +130 items (thanks to Streusel!): https://github.com/HerculesWS/Hercules/commit/045c1a44df08c1472f5a95742628a2765c1be9d1 Quote Share this post Link to post Share on other sites
kyeme 71 Posted June 24, 2013 (edited) By the way I've fixed the problem with the random package rates (thanks to Beret!), also added the missing +130 items (thanks to Streusel!): https://github.com/HerculesWS/Hercules/commit/045c1a44df08c1472f5a95742628a2765c1be9d1 Thanks! Can you confirm this? the reward item in my screen it showunknown item? Im testing the announcement xD Edited June 24, 2013 by kyeme Quote Share this post Link to post Share on other sites
Ind 945 Posted June 24, 2013 whats your client date? When I tested that it was totally different (message was way shorter for starters), and in your case the item name and the reward name appear to be swapped Quote Share this post Link to post Share on other sites
kyeme 71 Posted June 24, 2013 (edited) whats your client date? When I tested that it was totally different (message was way shorter for starters), and in your case the item name and the reward name appear to be swapped Im using 2012-04-17ragexe You mean this? pRO line 1629: Citizens of Midgard, Lady Luck shines upon [%s] !! [%s] has awarded the player with '%s' !!# iRO line 1629: [%s] has won [%s] from '%s'.# Edited June 25, 2013 by kyeme Quote Share this post Link to post Share on other sites
kyeme 71 Posted June 25, 2013 (edited) whats your client date? When I tested that it was totally different (message was way shorter for starters), and in your case the item name and the reward name appear to be swapped Ok i understand now because of my msgstringtable but why still showing Unknown Item? Edited June 25, 2013 by kyeme Quote Share this post Link to post Share on other sites
Ind 945 Posted June 25, 2013 Fixed in https://github.com/HerculesWS/Hercules/commit/5d467dd19d1756e42d3c95f553054177be6b5290 (Thanks to Yommy!) 2 Mystery and kyeme reacted to this Quote Share this post Link to post Share on other sites
Jedzkie 58 Posted June 25, 2013 Fixed in https://github.com/HerculesWS/Hercules/commit/5d467dd19d1756e42d3c95f553054177be6b5290 (Thanks to Yommy!) Praise the Lord! Quote Share this post Link to post Share on other sites
jTynne 101 Posted July 10, 2013 Can't seem to get custom additions to the Old_Card_Album to load in-game. Quote Share this post Link to post Share on other sites
Ind 945 Posted July 10, 2013 Can't seem to get custom additions to the Old_Card_Album to load in-game.You're getting errors? If so which or: can you send me the entries you added so I can play with it? Quote Share this post Link to post Share on other sites
Jezu 25 Posted July 30, 2013 (edited) Sir @Ind, Can you try to open Yggdrasil Box(10) #14232 and Elite Siege Supply #14003. It seems some of the packageitem(); is not fully working to me. On screenshot below, after clicking 'Ok' button, nothing happen. NOTE: I'm using fresh Hercules SVN latest. And here's the console errors I got when I open some of the items that has packageitem(); on item_db. Edited July 30, 2013 by Jezu Quote Share this post Link to post Share on other sites
pr3p 39 Posted July 31, 2013 Alright awesome release @ind +10 Quote Share this post Link to post Share on other sites
Ind 945 Posted July 31, 2013 Sir @Ind, Can you try to open Yggdrasil Box(10) #14232 and Elite Siege Supply #14003. It seems some of the packageitem(); is not fully working to me. On screenshot below, after clicking 'Ok' button, nothing happen. NOTE: I'm using fresh Hercules SVN latest. Hello, thanks for bringing this to us. problem you had with #14232 and #14003 has been fixed in https://github.com/HerculesWS/Hercules/commit/94502b74233035b07c8c73a1f991a17b7bf22c55I don't reproduce your console errors though, and I'd challenge your copy being "fresh" since our max level is 150 and in your screenshot it shows 160. Quote Share this post Link to post Share on other sites
themon 63 Posted December 31, 2013 Sir @Ind, Can you try to open Yggdrasil Box(10) #14232 and Elite Siege Supply #14003. It seems some of the packageitem(); is not fully working to me. On screenshot below, after clicking 'Ok' button, nothing happen. NOTE: I'm using fresh Hercules SVN latest. 1.JPG And here's the console errors I got when I open some of the items that has packageitem(); on item_db. 2.JPG getting same error Quote Share this post Link to post Share on other sites
ossi0110 200 Posted December 31, 2013 Sir @Ind, Can you try to open Yggdrasil Box(10) #14232 and Elite Siege Supply #14003. It seems some of the packageitem(); is not fully working to me. On screenshot below, after clicking 'Ok' button, nothing happen. NOTE: I'm using fresh Hercules SVN latest. 1.JPG And here's the console errors I got when I open some of the items that has packageitem(); on item_db. 2.JPG getting same error Cant Reproduce , im running on latest Herc and i can open the boxes without any problems , or server errors msgs/ warning i dont use SQL item db . and Running in PRE-RE mode be sure to update your sql item DBs Quote Share this post Link to post Share on other sites