Some upcoming hercules features

[4144 366]

Futures already added to hercules:

Inventory expanding

 http://imgc1.gnjoy.com/ufile/ro/2018/11/21/QK3O60RA1MGOMU301NUO.gif

Supported from clients: 2018-10-31 ragexe/ragexeRE, 2018-11-14 zero.

For expand inventory need to have in inventory item Inventory_Extension_Coupon (25793)

 

Barter shop

 

Supported from  clients: 2019-01-16 ragexe/ragexeRE, 2018-12-26 zero.

For shop barter shop need uncomment line

"npc/custom/bartershop.txt",

in npc/scripts_custom.conf. Barter shop demo npc will be added in prontera at (159, 284).

 

Most client exes can be downloaded here: http://nemo.herc.ws/downloads/

[4144 366]

Now hercules version released and this features can be used from stable or master branch.

[utofaery 7]

Sir,

What will be the max expandable limit of this expandable Inventory expanding?

 

[AnnieRuru 957]

already mentioned in script_commands.txt

*expandInventory(<value>)

Adjust player inventory to given value.
Maximum inventory size is MAX_INVENTORY.
Minimum inventory size is FIXED_INVENTORY_SIZE.
For supported clients it send inventory change packet. For old clients,
this change is silent.
Current max inventory size can be read by function getInventorySize().

https://github.com/HerculesWS/Hercules/blob/82d634ad431b2ffe7077a561f4eafd2486ede44b/doc/script_commands.txt#L10349

https://github.com/HerculesWS/Hercules/blob/82d634ad431b2ffe7077a561f4eafd2486ede44b/src/common/mmo.h#L170

[4144 366]

In other words default values for MAX_INVENTORY is 200

for FIXED_INVENTORY_SIZE is 100

 

[AnnieRuru 957]

wait a moment ... why the *expandInventory has the I as capital letter ?

I remember there was a script standardization topic, forgot where issit now, discussed years ago

1. all constants should be CAPITAL LETTERS -> QUEUEOPT_LOGOUT, IOT_PARTY,  GETTIME_WEEKDAY ...
2. all functions start with F_, and Capitial Letters only on word -> F_MesInfo, F_MesColor, F_InsertComma, F_SaveQuestSkills
3. all script commands should be low cap
4. and the ... no idea when ... variables ...

for example your *getInventorySize() has I and S capital, opposed to *getinventorylist() all low cap

 

hercules script engine is case-sensitive, so we have to be extra be careful when apply the capital letters
... although there are already some controversial ... like the "All" vs "all" ... reported #784