Dastgir 1246 Posted August 13, 2020 Hello, I have today released new plugin, namely NoView. It adds command @noview to disable the headgear views for users (Upper/Mid/Lower headgear views) Link: https://github.com/dastgirp/HPM-Plugins/blob/master/src/plugins/noview.c 1 3 AnnieRuru, Kuroyama, master@ragna and 1 other reacted to this Quote Share this post Link to post Share on other sites
0 Kuroyama 6 Posted August 13, 2020 First to thank you with this sir dast. This is what I've been looking for months. Great work! Quote Share this post Link to post Share on other sites
0 Zero Human 0 Posted August 18, 2020 At first, thanks for the plugin release, but It's just me who get the const error? Quote noview.c: In function ‘clif_send_helper’: noview.c:168:49: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual] CONST_PARAMETER struct packet_idle_unit *p = (CONST_PARAMETER struct packet_idle_unit *)RBUFP(buf, 0); ^ noview.c:169:50: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual] CONST_PARAMETER struct packet_idle_unit *p2 = (CONST_PARAMETER struct packet_idle_unit *)RBUFP(buf_new, 0); ^ noview.c:175:50: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual] CONST_PARAMETER struct packet_spawn_unit *p = (CONST_PARAMETER struct packet_spawn_unit *)RBUFP(buf, 0); ^ noview.c:176:51: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual] CONST_PARAMETER struct packet_spawn_unit *p2 = (CONST_PARAMETER struct packet_spawn_unit*)RBUFP(buf_new, 0); ^ noview.c:182:52: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual] CONST_PARAMETER struct packet_unit_walking *p = (CONST_PARAMETER struct packet_unit_walking *)RBUFP(buf, 0); ^ noview.c:183:53: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual] CONST_PARAMETER struct packet_unit_walking *p2 = (CONST_PARAMETER struct packet_unit_walking *)RBUFP(buf_new, 0); ^ noview.c:189:53: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual] CONST_PARAMETER struct packet_viewequip_ack *p = (CONST_PARAMETER struct packet_viewequip_ack *)RBUFP(buf, 0); ^ noview.c:190:54: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual] CONST_PARAMETER struct packet_viewequip_ack *p2 = (CONST_PARAMETER struct packet_viewequip_ack *)RBUFP(buf_new, 0); ^ noview.c: In function ‘clif_send_sub_hook’: noview.c:269:6: warning: variable ‘bool_’ set but not used [-Wunused-but-set-variable] int bool_; Quote Share this post Link to post Share on other sites
0 Zero Human 0 Posted August 18, 2020 On 8/13/2020 at 2:13 PM, Dastgir said: It adds command @noview to disable the headgear views for users Aaand the next stuff. Don't know if this just me, but the command works for the whole server. So... if anyone use the command, the whole server can't see headgears. xD Quote Share this post Link to post Share on other sites
0 Kuroyama 6 Posted August 21, 2020 On 8/18/2020 at 4:47 PM, Zero Human said: At first, thanks for the plugin release, but It's just me who get the const error? noview.c: In function ‘clif_send_helper’: noview.c:168:49: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual] CONST_PARAMETER struct packet_idle_unit *p = (CONST_PARAMETER struct packet_idle_unit *)RBUFP(buf, 0); ^ noview.c:169:50: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual] CONST_PARAMETER struct packet_idle_unit *p2 = (CONST_PARAMETER struct packet_idle_unit *)RBUFP(buf_new, 0); ^ noview.c:175:50: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual] CONST_PARAMETER struct packet_spawn_unit *p = (CONST_PARAMETER struct packet_spawn_unit *)RBUFP(buf, 0); ^ noview.c:176:51: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual] CONST_PARAMETER struct packet_spawn_unit *p2 = (CONST_PARAMETER struct packet_spawn_unit*)RBUFP(buf_new, 0); ^ noview.c:182:52: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual] CONST_PARAMETER struct packet_unit_walking *p = (CONST_PARAMETER struct packet_unit_walking *)RBUFP(buf, 0); ^ noview.c:183:53: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual] CONST_PARAMETER struct packet_unit_walking *p2 = (CONST_PARAMETER struct packet_unit_walking *)RBUFP(buf_new, 0); ^ noview.c:189:53: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual] CONST_PARAMETER struct packet_viewequip_ack *p = (CONST_PARAMETER struct packet_viewequip_ack *)RBUFP(buf, 0); ^ noview.c:190:54: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual] CONST_PARAMETER struct packet_viewequip_ack *p2 = (CONST_PARAMETER struct packet_viewequip_ack *)RBUFP(buf_new, 0); ^ noview.c: In function ‘clif_send_sub_hook’: noview.c:269:6: warning: variable ‘bool_’ set but not used [-Wunused-but-set-variable] int bool_; I notice this error too (but in centos/linux only. On windows, its fine), but somehow I didn't experience that whole server noview. I'll try to test that very soon. Quote Share this post Link to post Share on other sites
0 xJhay 8 Posted September 24, 2020 (edited) Quote noview.c: In function ‘clif_send_helper’: noview.c:168:49: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual] CONST_PARAMETER struct packet_idle_unit *p = (CONST_PARAMETER struct packet_idle_unit *)RBUFP(buf, 0); ^ noview.c:169:50: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual] CONST_PARAMETER struct packet_idle_unit *p2 = (CONST_PARAMETER struct packet_idle_unit *)RBUFP(buf_new, 0); ^ noview.c:175:50: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual] CONST_PARAMETER struct packet_spawn_unit *p = (CONST_PARAMETER struct packet_spawn_unit *)RBUFP(buf, 0); ^ noview.c:176:51: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual] CONST_PARAMETER struct packet_spawn_unit *p2 = (CONST_PARAMETER struct packet_spawn_unit*)RBUFP(buf_new, 0); ^ noview.c:182:52: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual] CONST_PARAMETER struct packet_unit_walking *p = (CONST_PARAMETER struct packet_unit_walking *)RBUFP(buf, 0); ^ noview.c:183:53: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual] CONST_PARAMETER struct packet_unit_walking *p2 = (CONST_PARAMETER struct packet_unit_walking *)RBUFP(buf_new, 0); ^ noview.c:189:53: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual] CONST_PARAMETER struct packet_viewequip_ack *p = (CONST_PARAMETER struct packet_viewequip_ack *)RBUFP(buf, 0); ^ noview.c:190:54: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual] CONST_PARAMETER struct packet_viewequip_ack *p2 = (CONST_PARAMETER struct packet_viewequip_ack *)RBUFP(buf_new, 0); ^ noview.c: In function ‘clif_send_sub_hook’: noview.c:269:6: warning: variable ‘bool_’ set but not used [-Wunused-but-set-variable] int bool_; Is this normal to receive this warning? And is there any way to get rid of this? Edited September 25, 2020 by xJhay Quote Share this post Link to post Share on other sites
0 AnnieRuru 957 Posted September 24, 2020 hmm ........ already 2 people getting the same error message I just tested on my test server, compile with visual studio 2019, no problem everything green though if you get this error does it means you also get disable view for whole server instead of individual player ? Quote Share this post Link to post Share on other sites
0 xJhay 8 Posted September 25, 2020 6 hours ago, AnnieRuru said: hmm ........ already 2 people getting the same error message I just tested on my test server, compile with visual studio 2019, no problem everything green though if you get this error does it means you also get disable view for whole server instead of individual player ? Hi mam annie. Sometimes, its happening and I'm not sure of that kind of behavior but the main thing is I kinda worried of those warning because it's too many and might cause of more exploits or something. Quote Share this post Link to post Share on other sites
0 Dastgir 1246 Posted September 25, 2020 17 hours ago, xJhay said: Hi mam annie. Sometimes, its happening and I'm not sure of that kind of behavior but the main thing is I kinda worried of those warning because it's too many and might cause of more exploits or something. The error can ignore for now, but I will get it fixed soon. If you could tell me the steps to reproduce, I will fix it, but without the steps to reproduce, it's hard for me to test as well. Quote Share this post Link to post Share on other sites
0 xJhay 8 Posted September 26, 2020 (edited) 8 hours ago, Dastgir said: The error can ignore for now, but I will get it fixed soon. If you could tell me the steps to reproduce, I will fix it, but without the steps to reproduce, it's hard for me to test as well. Hello sir dastgir. I do nothing but to put the plugin and recompile it, then the warning shows up. Edit: When I compile it to windows, its okay and it has no error shows. Only in CentOS. Edited September 26, 2020 by xJhay Edit: Adding additional info. Quote Share this post Link to post Share on other sites
0 Dastgir 1246 Posted September 26, 2020 2 hours ago, xJhay said: Hello sir dastgir. I do nothing but to put the plugin and recompile it, then the warning shows up. Edit: When I compile it to windows, its okay and it has no error shows. Only in CentOS. I am aware of this warning, for now it's safe to ignore, I was talking about the bug wherein whole server couldn't see hg, I want to know the steps to reproduce that bug Quote Share this post Link to post Share on other sites
0 raymedium 1 Posted January 30, 2021 how would I disable character own hat too, not just only other player 1 xJhay reacted to this Quote Share this post Link to post Share on other sites
0 Daraen 7 Posted January 31, 2021 (edited) On 9/26/2020 at 7:04 AM, Dastgir said: I am aware of this warning, for now it's safe to ignore, I was talking about the bug wherein whole server couldn't see hg, I want to know the steps to reproduce that bug same error as @Zero Human etc etc I just recompile my server after dragging the files for the plugin. Edited January 31, 2021 by Daraen Quote Share this post Link to post Share on other sites
0 brunosc 2 Posted March 1, 2021 (edited) Here got same warning when compile first time. if compile again without (make clean) dont show this warnings. Edited March 4, 2021 by brunosc Quote Share this post Link to post Share on other sites
Hello,
I have today released new plugin, namely NoView.
It adds command @noview to disable the headgear views for users (Upper/Mid/Lower headgear views)
Link: https://github.com/dastgirp/HPM-Plugins/blob/master/src/plugins/noview.c
Share this post
Link to post
Share on other sites