Ai4rei 321 Posted November 14, 2013 (edited) In case eAthena r15263 will be merged and the community has use for it, there's an excess add-on code, that has not and will not be committed to eAthena, due to it's nature of being a custom. The patch allows to optionally reject completely transparent emblems as part of the emblem validation code. Transparent emblems are typically abused during WoE times to draw less attention in castles and were/are considered against the rules on some official and private RO servers. Commented lines are an alternative approach for same effect, and may be removed. patch Edited January 17, 2016 by Ai4rei 4 Ind, evilpuncker, kyeme and 1 other reacted to this Quote Share this post Link to post Share on other sites
kyeme 71 Posted November 14, 2013 Awesome Thanks for this master Ai4rei, I hope they will merge this Quote Share this post Link to post Share on other sites
Ind 945 Posted November 14, 2013 very nice indeed, thanks for sharing Quote Share this post Link to post Share on other sites
Jedzkie 58 Posted November 14, 2013 Lighta already commited this on rathena. Quote Share this post Link to post Share on other sites
kyeme 71 Posted November 14, 2013 Lighta already commited this on rathena. Yes and emblem_woe_change // Do we allow to change guild emblem during woe_time ?emblem_woe_change: yes Quote Share this post Link to post Share on other sites
Gerz 7 Posted November 15, 2013 (edited) rAthena commit this changes ( nicely ) https://github.com/rathena/rathena/commit/d07314bcacd300d603c2f0414e91880d12058637 Edited November 15, 2013 by Gerz Quote Share this post Link to post Share on other sites
Ai4rei 321 Posted November 15, 2013 (edited) rathena's version can be worked around (in more ways than one). Edited November 15, 2013 by Ai4rei 1 evilpuncker reacted to this Quote Share this post Link to post Share on other sites
evilpuncker 503 Posted November 18, 2013 well, we got this implemented already now, no? xD btw I would love to have the emblem_woe_change option too Quote Share this post Link to post Share on other sites
ossi0110 200 Posted November 18, 2013 well, we got this implemented already now, no? xD btw I would love to have the emblem_woe_change option too yes its allready got added into hercules https://github.com/HerculesWS/Hercules/commit/e095650d437c81e6ae90a99a3cd1bb0c8c6eba38 Quote Share this post Link to post Share on other sites