Suggestion for restricted equipment (making a new conf for it)

[jaBote 438]

Hi everybody! I was thinking if it was possible to create a new conf value for the disabled equipment which make you decide whether you want to unequip a disabled item or just nullify its effect.

 

Yeah I know nullifying that effect is the official option and that it was implemented in 5b378058f5 and cc8e005f27 (thanks, kyeme!), but I know for sure that there'll be a lot of mess on servers because of unaware people (the most) seeing they can use their equip on those maps but without any effect and claiming it to be a critical bug, which is not correct. Most players and admins are used to being forced by the map server to unequip disabled equipment. Moreover, they know an item is disabled because they see it wear off, but with the new system you don't usually note one of your equipped items is disabled until you see it has no effect.

 

What I'm suggesting is to create a conf value just like the item_restricted_consumption_type one in /conf/battle/items.conf which should let server admins to decide whether they want to select the official behavior or the one that has been there for years.

 

Thanks a lot!

[Emistry 145]

Hercules got this..

http://herc.ws/board/topic/302-introducing-hercules-map-zone-database/

[jaBote 438]

Yes I know -I've been reading this forum and Hercules source commits for like a month before deciding to register-, and I think this is a great addition for the emulator, but when you disable any equipment in the db/{re or pre-re}/map_zone_db.txt it just gets... what it says, disabled, like you were equiping dummy equipment. But I think it'd be useful to make admins have the power of deciding if they want to just disable the equipment or do what Athena emulators were doing for ages, just unequip them where they are deactivated. It'd be logic.

[Ind 945]

what it says, disabled, like you were equiping dummy equipment. But I think it'd be useful to make admins have the power of deciding if they want to just disable the equipment or do what Athena emulators were doing for ages, just unequip them where they are deactivated. It'd be logic.

this was changed recently when we found out that it was how official servers were doing it (nullify effect instead of unequip) i think we added a config to choose between the two hmmm....

edit:

aah no we added the setting only for the item-use behavior that was also changed with it...

// Will disabled consumables (disabled by map_zone_db.conf) be consumed when trying to use them?// 1 (official): yes// 0: noitem_restricted_consumption_type:1

[jaBote 438]

Time is a very valuable resource, I wouldn't want to waste yours so I triple-checked before posting this

[Svanhild 2]

I have a question. I'm trying to restrict an item (equipment) not consumable, placed it in mapzone but it doesn't seem to work at all?

[jaBote 438]

Restricted items are by default consumed but have no effect. You can change it on the item_restricted_consumption_type one in /conf/battle/items.conf.

 

P.S.: I'll take advantage the revival of my suggestion to say BUMP! to it :3

[akbare 2]

how about command @reloadmapzone

[Ind 945]

makes sense to me, i agree.

[AnnieRuru 957]

http://upaste.me/f94d11052d9751e97

this one should go inside SVN

EDIT: suddenly I feel this one can be improve ....

 

ok this one better

http://upaste.me/d2ac11053eed06c03

Edited March 9, 2014 by AnnieRuru

[kyeme 71]

http://upaste.me/f94d11052d9751e97

 

this one should go inside SVN

I agree ^

[evilpuncker 503]

http://upaste.me/f94d11052d9751e97

this one should go inside SVN

EDIT: suddenly I feel this one can be improve ....

 

ok this one better

http://upaste.me/d2ac11053eed06c03

 

make a pull request

[Mystery 594]

I added it to my repo so far and compiled the source without any errors ;3 I'll just wait for approval of the devs and see if it can be merged inside our main repo ;3

 

Thanks Annie!

[karazu 33]

how about command @reloadmapzone

this one please

[evilpuncker 503]

I added it to my repo so far and compiled the source without any errors ;3 I'll just wait for approval of the devs and see if it can be merged inside our main repo ;3

 

Thanks Annie!

 

any dev thoughts on this?

[AnnieRuru 957]

actually I'm thinking of writing both ... with this one

http://herc.ws/board/topic/4412-map-zone-dbconf-allows-to-restrict-an-item-type/

then only pull request

[evilpuncker 503]

actually I'm thinking of writing both ... with this one

http://herc.ws/board/topic/4412-map-zone-dbconf-allows-to-restrict-an-item-type/

then only pull request

 

go ahead annie, both ideas are good and got support from community! they will be accepted for sure

[jaBote 438]

I read this topic before, when I was on my cellphone.

 

First of all, thanks Annie for the SRC ! I feel this would be appropriate to add to the repo because it's a classic mechanic, but will refrain to do that until a dev agrees on committing it just to see if my opinion is followed.

[Angelmelody 221]

makes sense to me, i agree.

Hope Hercules to implement this fix , Cuz player still can wear  the restricted equipments of disabled_items

[astralprojection 35]

http://upaste.me/f94d11052d9751e97

this one should go inside SVN

EDIT: suddenly I feel this one can be improve ....

 

ok this one better

http://upaste.me/d2ac11053eed06c03

 

Holy Cow!!! Damn!!!! Developers please commit!!! 

[AnnieRuru 957]

pull request that's it ?

https://github.com/HerculesWS/Hercules/pull/330

 

for the other one ... its quite tough ...

it got 2 problems that needs time to tackle with

 

https://github.com/rathena/rathena/blob/master/conf/battle/items.conf#L91

I just realized rathena already have something similar ...

so we should get to do the same

Edited August 28, 2014 by AnnieRuru