bWolfie

You need to edit atcommand_exec This piece of code here orders that part. I think if you just remove the check for group level it will work. if (info == NULL) { if (pc_get_group_level(sd) == 0) // TODO: remove or replace with proper permission return false; sprintf(output, msg_fd(fd,153), command); // "%s is Unknown Command." clif->message(fd, output); atcommand->get_suggestions(sd, command + 1, is_atcommand); return true; }

I will up my efforts try to get to 15 PR for October

trying to come up with 3 more PRs is hard...maybe I will just delete and re-open my ones from before October lol.

Nice job Dastgir good to see you are still updating this. People of Hercules, keep reporting in a constructive manner to make a good system

nice one. remember to take consideration to geography, what kind of people are living there and some immersion stuff like that. Even though you may not fill your map with anything, it will help you with your designs. Aesthetically pleasing.

This is to do with client not Hercules.

@Habilis i will be the first to get the t-shirt.

About BlackoutRO Oh, hey, what's up? long time no chat u gm. BlackoutRO is a very old server. It first opened in 2006. After 10 years of service, in 2015, it closed due to the neglect of development. In 2016, the server was rebuilt from scratch and went through a long testing phase. August 2018 saw the full relaunch of the server. Read more about the history of BlackoutRO: [Click here] Why should you invest time in BlackoutRO? Here at Blackout, we are all about fast-paced BG, PvP and WoE. Do the words "skill spam" send tingles down your spine? They should. Free-flowing battles is what we all crave. How about "competitive War of Emperium"? We boast the most consistently competitive private server WoE scene. Since 2010, players have attended Wars with open arms, ready to be torn to shreds and to repeat it week after week. As of August 2018, "Pay to Win" elements have been removed from the server. To become a serious player, you'll need to actually play the game. Good? Bad? You decide! We, the Staff Team, are all about making ethical decisions in the best interest of the server. The server always comes before one's own interests. These values, along with our strong connection to our community, will be what drive us forward, and is why you should feel comforted in investing time into BlackoutRO. Join our community. It'll be the time of your RO life. www.blackout-ro.net Server Information Server Opened: August 16, 2018. The current database has been live since September 2016 - all items and zeny from before then were lost due to the server being rebuilt from scratch. Accounts, characters and guilds were retained. Server Location: California, USA Mode: Pre-Renewal Maximum Base / Job Levels: 500 / 120 Base / Job Experience Rates: 10001x / 10001x Drop rates: 100% (most common items and MvP drops), 30% (most equipment), 10% (cards) Maximum Stat Value: 450 Maximum Attack Speed: 197 Instant Cast: 170 DEX Status Immunity: 300 LUK

Hercules master race

I haven't been able to enable sanitize and test again, but something peculiar happened. I got a few of these messages, then everyone got booted from the map server. (08/27/2018 12:16:09) [ Error ] : Memory manager: freed-data is changed. (freed in achievement.c line 79) [Aug/27 12:16:26][Info]: Character 'Some Character' logged off. [Aug/27 12:16:26][Info]: Character 'Some Character 2' logged off. [Aug/27 12:16:26][Info]: Character 'Some Character 3' logged off. I just thought it was weird and maybe too coincidental? No crash, everyone was able to login a few moments later. Also I have had a few of these floating around: (08/16/2018 21:08:07) [ Error ] : --- failed assertion -------------------------------------------- (08/16/2018 21:08:07) [ Error ] : achievement.c:727: 'amount != 0' in function `achievement_validate_zeny' (08/16/2018 21:08:07) [ Error ] : /home/user/Hercules/./map-server() [0x62f233] (08/16/2018 21:08:07) [ Error ] : /home/user/Hercules/./map-server() [0x408ea3] (08/16/2018 21:08:07) [ Error ] : /home/user/Hercules/./map-server() [0x521069] (08/16/2018 21:08:07) [ Error ] : /home/user/Hercules/./map-server() [0x50c661] (08/16/2018 21:08:07) [ Error ] : /home/user/Hercules/./map-server() [0x46ac9a] (08/16/2018 21:08:07) [ Error ] : /home/user/Hercules/./map-server() [0x4ad21f] (08/16/2018 21:08:07) [ Error ] : /home/user/Hercules/./map-server() [0x63b1de] (08/16/2018 21:08:07) [ Error ] : /home/user/Hercules/./map-server(main+0x2ca) [0x4083ea] (08/16/2018 21:08:07) [ Error ] : /lib64/libc.so.6(__libc_start_main+0xf5) [0x7ffff62c3445] (08/16/2018 21:08:07) [ Error ] : /home/user/Hercules/./map-server() [0x40859b] (08/16/2018 21:08:07) [ Error ] : --- end failed assertion ---------------------------------------- Using last months release (I believe v2018.07.29+2) with no edits or plugins related to acheivements.

I received this crashlog. I don't know what caused it, some plugins were referenced: https://pastebin.com/W2wXWDrg Tried checking over all those plugins for null pointer. Disabled afk, unit, status, trade and itembonus, then it happened later, referencing again the ones I didn't disable.

Thank you. Seems there were some errors in two buildins used in my scripts. 1. npcshopdelitem(), which was breaking every time it was used. 2. setmapflag(), breaking sometimes when setting 'mf_zone'. I will update again if further issues persist.

Yup it's quite modified. My Hercules is up to date, as in I have merged current master with my source. Src: 5118dceb5c1c5cad7d0c06137a9b1eee2acbe4e8 Scripts: 20f045c8de9f5fb6dde5bb8c8da6306facf2517c static int pc_eventtimer(int tid, int64 tick, int id, intptr_t data) { struct map_session_data *sd=map->id2sd(id); char *p = (char *)data; int i; if(sd==NULL) return 0; ARR_FIND( 0, MAX_EVENTTIMER, i, sd->eventtimer[i] == tid ); if( i < MAX_EVENTTIMER ) { sd->eventtimer[i] = INVALID_TIMER; sd->eventcount--; npc->event(sd,p,0); // pc.c: 9909 here } else ShowError("pc_eventtimer: no such event timer\n"); if (p) aFree(p); return 0; }

When compiling my server, I did: make clean ./configure --enable-debug=gdb --disable-lto --enable-sanitize=full make sql plugins pc.c: 9909 = pc_eventtimer - npc->event(sd,p,0);

I managed to compile on my live server. I got this crash info. Would you mind taking a look at it and seeing if you can decipher anything? https://pastebin.com/M3YCHpkk

Here is my ./configure --enable-sanitize=full log. I think maybe it's a CentOS issue? https://pastebin.com/5kUksZ7R

yum list installed .... zlib.x86_64 1.2.7-17.el7 installed zlib-debuginfo.x86_64 1.2.7-17.el7 @base-debuginfo zlib-devel.x86_64 1.2.7-17.el7 @base zopfli.x86_64 1.0.1-1.el7 @epel I'm using CentOS 7 that package is not available. I have installed zlib-devel. Edit: I am now trying debian and that flag has worked.

Yep I updated to GCC 7.3 and can't enable it. It is working in one of my servers but I can't use it cause it's live. The other servers I tried I just keep getting ./configure --enable-sanitize=full . .. ... checking for library containing inflateEnd... no configure: error: zlib library not found or incompatible... stopping

I managed to --enable-sanitize=full by installing packages miniz and zopfli (not sure which one did it). Hopefully I will be able to debug this now. Edit 1:Despite installing the same packages, I could only get sanitize to work on my production server for some reason, so makes testing hard. I assume this has something to do with any edits I made to pc.c am I correct? or could it be something doing pc->function? ================================================================= ==2032== ERROR: AddressSanitizer: heap-buffer-overflow on address 0x7f23a8ea442c at pc 0x730c95 bp 0x7fffb665a940 sp 0x7fffb665a930 READ of size 4 at 0x7f23a8ea442c thread T0 #0 0x730c94 (/home/user/Hercules/map-server+0x730c94) #1 0x823e0b (/home/user/Hercules/map-server+0x823e0b) #2 0x8cbb5a (/home/user/Hercules/map-server+0x8cbb5a) #3 0x8d25e2 (/home/user/Hercules/map-server+0x8d25e2) #4 0x715134 (/home/user/Hercules/map-server+0x715134) #5 0xa63330 (/home/user/Hercules/map-server+0xa63330) #6 0xa63458 (/home/user/Hercules/map-server+0xa63458) #7 0x7281a7 (/home/user/Hercules/map-server+0x7281a7) #8 0x729b78 (/home/user/Hercules/map-server+0x729b78) #9 0x6d1fea (/home/user/Hercules/map-server+0x6d1fea) #10 0x409ef1 (/home/user/Hercules/map-server+0x409ef1) #11 0x7f23b015b444 (/usr/lib64/libc-2.17.so+0x22444) #12 0x40a622 (/home/user/Hercules/map-server+0x40a622) 0x7f23a8ea442c is located 139791134507871 bytes to the right of global variable '<null>' (0x4d) of size 128 ASAN:SIGSEGV ==2032== AddressSanitizer: while reporting a bug found another one.Ignoring.

I don't know what to do. Seems all sorts of things can cause a crash. Now pc_setregistry did it. https://pastebin.com/Nc5e03gH For reference, I am using src mods (Gepard Shield) and some plugins of my own (various edit). The #BG_TIE variable is being called using pc_setglobalreg(sd, script->add_str("#BG_TIE"), pc_readglobalreg(sd, script->add_str("#BG_TIE")) + 1); pc_setglobalreg(sd, reference_uid(script->add_str("#BG_TIE"), month), pc_readglobalreg(sd, reference_uid(script->add_str("#BG_TIE"), month)) + 1); #1: pc.c/9816 p = ers_alloc(pc->num_reg_ers, struct script_reg_num); #2 script.c/3573 [code:c] case '\'': set_reg_instance_num(st, num, name, val); return 1; default: if (ref) { script->set_reg_pc_ref_num(st, ref, num, name, val); } else { pc_setglobalreg(sd, num, val); //<<<< Here } return 1; [/code] #3 intif,c/1349 script->set_reg(NULL,sd,reference_uid(script->add_str(key), index), key, (const void *)h64BPTRSIZE(ival), NULL); #4 intif.c/2892 case 0x3804: intif->pRegisters(fd); break; #5 chrif.c/1645 if (cmd < 0x2af8 || cmd >= 0x2af8 + ARRAYLENGTH(chrif->packet_len_table) || chrif->packet_len_table[cmd-0x2af8] == 0) { int result = intif->parse(fd); // Passed on to the intif // <<<here #6 socket.c/1418 sockt->session[i]->func_parse(i); #7 core.c/557 sockt->perform(next);

I wasn't able to enable sanitize after installing those packages. I cleared my char_reg_num_db and things have been okay for 36 hours now. I will post again if things become an issue.

Thanks for your responses. I am unable to use the enable-sanitize=full option. It tells me 'configure: error: zlib library not found or incompatible...', despite the fact I have installed that dependency (version 1.2.7). The crashes are referencing variables that aren't being used by any script (but were used in the past). And I never made any edit to any src in pc or script other than adding some script command via plugin. This part here, is where pc_setglobalreg(sd, num, val); occurs. Are there any immediate quickfix options like clearing my char_reg_num/str_db? Or that wouldn't make a difference? name=0x7fffffffe0d0 "newbquest", value=0x1, ref=0x0) at script.c:3573

I'm using quite a few plugins. I've tried to disable them one by one but it is difficult to find what is the cause.

Hello, Recently my map server crashed. Hoping somebody can help me from this gdb debug information. First it said there was an overflow in script, at script_reg_destroy at if( p->value ) Then it crashed with this log on 'bt full'. https://pastebin.com/q50NEiDD

this feature is pleb feature. Just same fancy marketing tool. why u want this. its feature of rathena flux cp. since hercules is not updated we dont have it. anyway if you want to make, you need to record players online in your server. save it in $Variable and then use sql queries to call from flux cp.