Mystery

April Digest 2017
The following digest covers the month of April 1st - April 30th 2017
 
 
Development Highlights
Implementation of unit controlling script commands  Implementation of Item Options System Add missing non shuffle packets for 2014 - 2015 years. Unequip arrows when a bow is unequipped. (RE only) add getunits() buildin Fix a null pointer in guild->isallied()  Fix wrong parameters in a call to mapif->party_broken()  Monster Vulture's Eye and Snake's Eye removed Update Status ID Update NPC ID Implemented Official Summer 2 Costume Added oktoberfest_ignorepalette configuration Made prevent_logout effect on log-in optional  Removed hard coded values on @cashmount and setcashmount. Added AB_HIGHNESSHEAL in skill_add_heal_rate configuration Removal of cashfood_use_interval setting. Status effects from Cash Food items cannot be removed by death. expose bank vault to the script engine Removal of rare_drop_announce config. Added job checks for @bodystyle command  Tons of Packets Changes and Information  Remove wrong and duplicate packets for 20150226 Fix non shuffle unused packets in 20140305. Fix shuffle packets for 2014-01-15eRagexe. Move packets ZC_SELECTCART and CZ_SELECTCART into past into correct date Fix shuffle packets for 2015-10-01aRagexe. Added the correct PACKETVER Date for MSG_NPC_WORK_IN_PROGRESS message. Add encryption packets for 2016 RE clients. New Packet Additions: 2015-01-07aRagexeRE | 2015-01-14aRagexe | 2015-01-28aRagexe | 2015-02-04aRagexe | 2015-02-25aRagexeRE | 2015-02-26aRagexeRE | 2015-03-11aRagexeRE | 2015-03-25aRagexe | 2015-04-01aRagexe | 2015-04-22aRagexeRE | 2015-04-29aRagexe | 2015-05-07bRagexe | 2015-05-27aRagexe | 2015-06-17aRagexeRE | 2015-06-18aRagexeRE | 2015-08-19aRagexeRE | 2015-08-26aRagexeRE | 2015-10-07aRagexeRE | 2015-10-14bRagexeRE | 2015-10-28cRagexeRE | 2015-11-18aRagexeRE | 2015-12-02bRagexeRE | 2015-12-23bRagexeRE Additional Shuffle Packets 2016-01-27bRagexeRE | 2016-02-03aRagexeRE | 2016-02-17cRagexeRE | 2016-03-02bRagexeRE | 2016-03-09aRagexeRE | 2016-03-30aRagexeRE | 2016-05-11aRagexeRE | 2016-05-25aRagexeRE | 2016-06-08aRagexeRE | 2016-06-15aRagexeRE | 2016-06-30aRagexeRE | 2016-07-06cRagexeRE | 2016-07-13bRagexeRE | 2016-07-20aRagexeRE | 2016-07-27bRagexeRE | 2016-08-31bRagexeRE | 2016-09-07aRagexeRE | 2016-09-21bRagexeRE | 2016-10-12aRagexeRE | 2016-10-26bRagexeRE | 2016-11-09bRagexeRE | 2016-12-07eRagexeRE | 2016-12-14bRagexeRE | 2016-12-21aRagexeRE  
Database Highlights
Novice SP Table correction Fix wrong level check for MC_CHANGECART skill Implemented official Giant Fly Wing Effect Update GX Poison items Update Rune Knight Runes & Ores  
 

 
New script commands: chr ord gettimer getunits getvariableofpc can_use_command has_permission addchannelhandler removechannelhandler setunitdata getunitdata getunitname setunitname getequipisenableopt getequippedoptioninfo getequipoptioninfo setequipoption navigateto   Modified script commands (extra parameters): strcharinfo strnpcinfo addtimer deltimer addtimercount checkoption checkoption1 checkoption2 setoption warpparty warpguild classchange   New params: BankVault  
Big projects currently in development:
Implementation of the official Clan system Implementation of the official RoDEX system Implementation of the official Achievements system Complete rewrite of the map cache system  
 Thanks to Meko for posting this information and helping out! 
 

 
April Statistics
During the period there were 147 Commits. 31 Commits from Pull Requests with 8 Bugs* fixed from merged issues.  
*Please note: Bug fixes are counted as references to issues; it does not include bugs that have been fixed without issue reference. The number of commits includes those that were merged.

Hey everyone! We have a Discord Server --> https://discord.gg/0XUVOkY4khKmQUim You are free to join it if you like  

Last year, I launched a RO-themed webcomic which I've been updating weekly. I've been posting it in several forums and someone told me to share it here too, so I thought why not~
 
This comic follows Joshua, a newb adventurer who just arrived in Rune Midgard, struggling to understand how the world works, with some helping hands guiding him... kinda...
 
http://tapas.io/series/PORINGS
 
Been goin for almost a year, 44 strips so far and going strong. Updated every Friday~

It seems there's been no changelog since quite a while so here's one highlighting the most recent changes related to scripting. Sorry if that's not the right category, please move accordingly.     New script commands: chr ord gettimer getunits getvariableofpc can_use_command has_permission addchannelhandler removechannelhandler setunitdata getunitdata getunitname setunitname getequipisenableopt getequippedoptioninfo getequipoptioninfo setequipoption navigateto   Modified script commands (extra parameters): strcharinfo strnpcinfo addtimer deltimer addtimercount checkoption checkoption1 checkoption2 setoption warpparty warpguild classchange   New params: BankVault  
 
Big projects currently in development:
Implementation of the official Clan system Implementation of the official RoDEX system Implementation of the official Achievements system Complete rewrite of the map cache system

Beautiful as always Adel! 

Blood Wings
    
      
         
         
   

Mob Sprites
 
         
      
         
   

kRO had released anew refinery interface for item refinement last year in their 2016-10-* clients.
 
Source: 
 
A preview of my implementation:

 
I already have it working on my local Hercules branch. A big thanks to @Asheraf for providing information from kRO. This will be available for Hercules as and when it support the newer clients.
Just thought I'd share the info here
Hope for its release soon!

Thanks for the share. Though, since they are outdated, don't think they will work 100% with Hercules. People will need to make some adjustments to the script! But overall, thanks for the release.

February Digest 2017
The following digest covers the month of February 1st - February 28th 2017
 
 
Team Changes
hemagx has been moved to Former Core Developer from Core Developer Ragno has been moved to Community Contributor Frost has been moved to Script Developer from Former Script Developer (welcome back!)  
 
Development Highlights
Update gitlab-ci configuration to match current debian packages Fixes named items having their names changed when near other players Adds GvG2 zone on WoE:SE maps, disabling use of Leap/High Jump Fixes disguise position de-synchronization add chr() and ord() buildins Added option to show classchange only to one player Fix a CI build failure (gcc-5)  
 
Scripting Highlights
Add quest log for moscovia quests remove useless check for questprogress Fixes getbattleflag on npc/other/auction.txt  
 
February Statistics
During the period there were 19 Commits. 10 Commits from Pull Requests with 3 Bugs* fixed from merged issues.  
*Please note: Bug fixes are counted as references to issues; it does not include bugs that have been fixed without issue reference. The number of commits includes those that were merged.

About Code Review and Why You'd Want Your Code to Be Reviewed
 
Hello, fellow developers and code contributors!
As you certainly know, years ago, Hercules adopted a workflow based on pull requests, that includes code review as one of the necessary steps before any new piece of code makes it into the master branch of the repository.
While being an uncommon and somewhat controversial change in Hercules (and in the RO emulator scene in general), code review is part of the workflow of most software projects, both open source and closed source, and has many benefits.
 
Why Code Review
 
The benefits of code review are several:
"Given enough eyeballs, all bugs are shallow" [Linus's Law by Eric S. Raymond -- The Cathedral and the Bazaar, 1999]. While the law is not strictly true, it's certainly true that the more developers read and analyze a piece of code, the more likely it is that bugs that might be hidden in it are discovered early. Testing is not enough. It's very hard (or in the case of our codebase just plain impossible) to cover all the possible edge cases when testing a new feature or a fix. An additional pair of eyes reading the code may help discovering those more easily. This includes cases where the client would normally prevent a certain thing from happening, but it's not ensured anywhere on the server side. Better quality of code. By having other developers read a piece of code, they'll end up wondering why a certain approach was taken, rather than another, and discuss it with the submitter, leading to better, more efficient algorithms, or better engineered code. Better documentation. Since the code needs to be read by other people, it'll require proper comments (or they'll ask for explanations about the parts they can't easily explain). This increases the chance that the author, or anyone else that will need to read the same code again months or years after it's been submitted, will be able to understand it again, by finding appropriate comments in the appropriate parts of the code. Better insight into the code across the team. By reading code from different parts of the emulator as part of the review process, every team member increases their own general knowledge of the software, bit by bit. This is a very efficient way of learning how different parts of the emulator work, and why they were implemented that way. Future-proofing. By having public reviews, we keep a permanent trace of what were the hot topics and why certain decisions were taken, when a certain part of the emulator was implemented. If a bug arises, or something needs to be redesigned in future, we can look up the associated pull request and related discussion, and learn more about the discussion that went on in the past, and what's hiding behind code design decisions. Reviewing code from other people, as well as having one's own code reviewed by others might not be easy for everyone, especially at the beginning, but please try your best. Here are some suggestions on how to approach code review from either side. 
How to approach code review (for code authors)
 
As a code author, the worst thing you can do is to be afraid or shy about other people judging your code. This is the wrong approach! Don't be shy, have your code looked at by others, have them praise you for your genial approach to tackle a problem, listen to their suggestions on how to improve it. But be ready to defend your implementation, if you believe it's better than the suggestions you receive, or if the critics that are moved against it are wrong or meaningless.
 
Always keep in mind that:
Having your code reviewed and commented on isn't humiliating. Other people are spending their time looking at your code, asking you why you did something in a certain way rather than another, suggesting improvements. Both sides have a lot to learn from each others. (On the other hand, if no one reviews your code, that's somewhat humiliating!) If someone spots an issue in your code, it doesn't mean that you're a bad developer. We all make mistakes, and we should be happy to learn from them (and it's definitely better if someone spots them and points them out to us before it's too late and they were able to do some harm). Never, ever, take code review personally. No one will laugh about you, fire you, kill you, shame you, etc. if your code is commented on. If you believe you're right and the comments you received are pointless or wrong, chance is that you really are right. Be ready to defend your reasons, it's possible that the reviewer didn't think of them. It is your duty to explain them your reasons. How to approach code review (for code reviewers) 
Reviewing code is several orders of magnitude harder than having your own code reviewed. You have to check the code for several classes of problems, point out your findings, suggest improvements. And you still have to deal with the worry about hurting the code author's feelings when pointing out a mistake.
 
Here are some things you should keep in mind when reading and reviewing code from other people:
You're not judging a person. You're judging code. Don't make your review sound personal. Always think of uncommon and edge cases, and never assume they can't happen, unless there's an explicit check that makes them impossible to happen. Even if the code was tested by the author, it doesn't mean that it can't cause problems to other existing features, or have some issues the author couldn't think of. If the same person writes and tests a piece of code, the chance that they don't test the cases they forgot to handle while coding, is very close to 100%. If the code is not following the project's style guidelines (and this isn't just about indentation, but also about names, conventions about function calls, proper modularization, etc), it is your duty to point it out now, before it's merged. This will make the life of your fellow developers easier later on. Think defensively. Consider the code you have in front of you as buggy until you can prove its correctness. If you see that a sanity check is missing, ask the author to add it. If you believe that a function returns the wrong value in certain cases, even if very unlikely to occur, prepare an example of input for which that happens and point it out. Remember that threats such as overflows, underflows, buffer overruns, null pointers, invalid pointers, numeric (floating point) approximation, etc. are always behind the corner, check for them as often as possible and prove that they can't occur. And remember that, while the code author isn't your enemy (and code review shouldn't generate negative feelings), it's often a good idea to think of them as your "professional enemies". There's a chance that something nasty is hiding in their code, even if they didn't write it with ill intent, and as such, you shouldn't blindly trust the code, regardless of who the author is. Don't be afraid when you comment on other people's code. Your goal isn't to hurt their feelings, you're asking them for explanations and/or suggesting the way you would have done something. Likewise, don't be afraid of making a pointless comment. If the author has a good reason for their implementation, be ready to take back your comment and learn from them. Don't accept compromises. If you're firmly convinced that the author's defense of their code is wrong, your duty is to prove them wrong. But if they manage to convince you, don't be ashamed of admitting you were wrong. Happy reviewing!

Soon will be writing a
Step by step guide on how to setup a server on your RaspberryPi 3
For my RaspberryPi Related blog, will publish a version of it here. though, I don't think it is meaningful, as there are already nice guides on how to setup Hercules on linux...
 
 

Hello community!
I'm new (well not so new anymore... Had server hosting experience back in 2007 with eAthena).
 
Well, enough of lifestories. After all, you would read a book, if you wanted a story.
 
So, I'm writing here just to share this proof of concept.
Running Hercules server on RaspberryPi 3 is, indeed, possible.
 
I've just started. So far, I've been able to setup and connect to server.

 
 
As soon as I will finish sorting out Client PreRe 2013-12-30 mess
(It is a mess, since most links are dead)
I will Invite some friends to gather feedback about their overall experience playing on the server hosted on RaspberryPi,
I thought, that could be a nice experience to share with you guys.
 
 
UPD : Ow, and I suppose, the choice of Hercules is pretty obvious ?  ( back in 2007, I hosted that eAthena server on a similar spec PC as the RaspberryPi 3.)

Working on this
 
The complete system is vast and requires scripting for most achievements as they're through NPCs. And we don't have much official info. But I've made it flexible enough to be customized for types of possible achievements, even ones not present in kRO.

Preview of the achievements and the achievement window working on Hercules
 
(All official content, no customizations - although supported in my implementation.)
 

Thanks for the share. Though, since they are outdated, don't think they will work 100% with Hercules. People will need to make some adjustments to the script! But overall, thanks for the release.

Description:   A collection of events I made 6 years ago (2011) on my server. I was using eAthena server files when I made these scripts. I'm not sure if it's compatible with Hercules' server files. Some servers are still using some of these scripts and I think they're using new emulators like rAthena or Hercules.   I just want to share these scripts to everyone.   I don't know anything about programming when I made these scripts so the code is quite ugly. I did not even use functions lol.   Players on my server really enjoyed Stop the Clock and Guess the Word event.   I can't answer any questions regarding these scripts. I can't even remember the codes I've written here.   Events: Stop the Clock event Guess the Word event Run for your Life event Monster Hunt event - The last boss in Monster Hunt is a custom mob. Change it into whatever you want to avoid errors.
True or False event Lucky Box Event Poring Punch event Poring Catcher event Racing event MVP event Last Man Standing event (pvp) Free for All event (pvp) Soccer Ball event Treasure Box event  
NPC: Prize Giver npc - Download the sql script in the link below. Load and execute it on your database (phpMyAdmin / MySQL Workbench). It will create a table used by the Prize Giver npc. It won't work without this table.
Event Manager npc Event Warper npc Time Play npc Bubble Gum npc (copied the bubble gum quest in VanRO)  
Note: The prize of some events, especially the automated events, is a custom item. Change it into whatever you want to avoid errors. babbs-event-scripts.rar
prize-giver-sql-script.rar

There was no update here for quite a while, but clans is actually ready and full configurable. You can set an inactivity timer, buffs and also add custom clans. Adel made a small image pack for a custom clan (which I attach upon the release).
There is some last testing and then we show it to Haru and hope for a quick merge. Afterwards I do a topic about how everything works.

Hey everyone,
 
We recently implemented Issue & Pull Request templates. You can find them here:
Pull Request : https://github.com/HerculesWS/Hercules/blob/master/.github/PULL_REQUEST_TEMPLATE.md Issues : https://github.com/HerculesWS/Hercules/blob/master/.github/ISSUE_TEMPLATE.md  
Basically, when users are creating Issues or Pull Requests, they will see this form. This helps Hercules' Developers & Contributors by having the right details at the start of a thread. It ensures issues get resolved quickly and time isn't wasted. These templates are a step forward to help lessen issues or pull requests that do not meet requirements. Failure to follow these templates will result in an automatic closure of the issue or pull request. 
 
It is important for users to follow these templates and fill them out when creating issues and / or pull requests. 
 
 

February Digest 2017
The following digest covers the month of February 1st - February 28th 2017
 
 
Team Changes
hemagx has been moved to Former Core Developer from Core Developer Ragno has been moved to Community Contributor Frost has been moved to Script Developer from Former Script Developer (welcome back!)  
 
Development Highlights
Update gitlab-ci configuration to match current debian packages Fixes named items having their names changed when near other players Adds GvG2 zone on WoE:SE maps, disabling use of Leap/High Jump Fixes disguise position de-synchronization add chr() and ord() buildins Added option to show classchange only to one player Fix a CI build failure (gcc-5)  
 
Scripting Highlights
Add quest log for moscovia quests remove useless check for questprogress Fixes getbattleflag on npc/other/auction.txt  
 
February Statistics
During the period there were 19 Commits. 10 Commits from Pull Requests with 3 Bugs* fixed from merged issues.  
*Please note: Bug fixes are counted as references to issues; it does not include bugs that have been fixed without issue reference. The number of commits includes those that were merged.

Hey everyone,
 
We recently implemented Issue & Pull Request templates. You can find them here:
Pull Request : https://github.com/HerculesWS/Hercules/blob/master/.github/PULL_REQUEST_TEMPLATE.md Issues : https://github.com/HerculesWS/Hercules/blob/master/.github/ISSUE_TEMPLATE.md  
Basically, when users are creating Issues or Pull Requests, they will see this form. This helps Hercules' Developers & Contributors by having the right details at the start of a thread. It ensures issues get resolved quickly and time isn't wasted. These templates are a step forward to help lessen issues or pull requests that do not meet requirements. Failure to follow these templates will result in an automatic closure of the issue or pull request. 
 
It is important for users to follow these templates and fill them out when creating issues and / or pull requests. 
 
 

February Digest 2017
The following digest covers the month of February 1st - February 28th 2017
 
 
Team Changes
hemagx has been moved to Former Core Developer from Core Developer Ragno has been moved to Community Contributor Frost has been moved to Script Developer from Former Script Developer (welcome back!)  
 
Development Highlights
Update gitlab-ci configuration to match current debian packages Fixes named items having their names changed when near other players Adds GvG2 zone on WoE:SE maps, disabling use of Leap/High Jump Fixes disguise position de-synchronization add chr() and ord() buildins Added option to show classchange only to one player Fix a CI build failure (gcc-5)  
 
Scripting Highlights
Add quest log for moscovia quests remove useless check for questprogress Fixes getbattleflag on npc/other/auction.txt  
 
February Statistics
During the period there were 19 Commits. 10 Commits from Pull Requests with 3 Bugs* fixed from merged issues.  
*Please note: Bug fixes are counted as references to issues; it does not include bugs that have been fixed without issue reference. The number of commits includes those that were merged.

I believe this is what you're looking for:
 
http://herc.ws/board/topic/316-introducing-hercules-channel-system/?p=36309
 
Adding it to your channel:
@channel setopt <channelname> MessageDelay <seconds 1 -10>  
Increasing 10 seconds to maybe 255 seconds. Go to your atcommand.c file:
https://github.com/HerculesWS/Hercules/blob/master/src/map/atcommand.c#L9125 Change 10 to your desired number.

February Digest 2017
The following digest covers the month of February 1st - February 28th 2017
 
 
Team Changes
hemagx has been moved to Former Core Developer from Core Developer Ragno has been moved to Community Contributor Frost has been moved to Script Developer from Former Script Developer (welcome back!)  
 
Development Highlights
Update gitlab-ci configuration to match current debian packages Fixes named items having their names changed when near other players Adds GvG2 zone on WoE:SE maps, disabling use of Leap/High Jump Fixes disguise position de-synchronization add chr() and ord() buildins Added option to show classchange only to one player Fix a CI build failure (gcc-5)  
 
Scripting Highlights
Add quest log for moscovia quests remove useless check for questprogress Fixes getbattleflag on npc/other/auction.txt  
 
February Statistics
During the period there were 19 Commits. 10 Commits from Pull Requests with 3 Bugs* fixed from merged issues.  
*Please note: Bug fixes are counted as references to issues; it does not include bugs that have been fixed without issue reference. The number of commits includes those that were merged.

January Digest 2017
The following digest covers the month of January 1st - January 31st 2016
 
 
Team Changes
None  
Development Highlights
Update *waitingroom script document (#1537) Update md5 calculation to be able to hash a binary buffer HPM Hooks Update Fix CMDLINE_OPT_PARAM arguments in plugins failing to load remove hardcoded chat area size from clif.c, add chat_area_size to battleconf  
Database Highlights
Correct Para_Team_Mark_ effect Adjust 2@nyd areamobs  
Scripting Highlights
Double NPC Name in Royal Guard job change quest (#1538) Fixed announces from Koschei the Immortal (Moscovia Quests) (#1542) Add quest log for Juperos Ruins History Quest  
January Statistics
During the period there were 25 Commits. 9 Commits from Pull Requests with 0 Bug(s)* fixed from merged issues.  
*Please note: Bug fixes are counted as references to issues; it does not include bugs that have been fixed without issue reference.


December Digest 2016
The following digest covers the month of December 1st - December 31st 2016
 
 
Team Changes
None  
Development Highlights
Fixed areawarp cell check  Script command - makeitem2 (78854572) ​Fixed a null-pointer dereference in BUILDIN(makeitem2) Add support for static assertions (on compilers that support them) Update party_check_state (017c388c94) Clarify the meaning of the MAPID_* constants Clarify some Job Class vs MapID confusion (1/2)  Clarify some Job Class vs MapID confusion (2/2) Ensure that pc->addfame() increments the correct fame points Re-add -fvisibility=hidden on FreeBSD (necessary for plugins)  Fixing an small markdown mistake  
Scripting Highlights
Add a custom weight check in ring of the wise king quest Fixed incorrect OnTouch label in Crow of Destiny Quest  
December Statistics
During the period there were 18 Commits. 5 Commits from Pull Requests with 0 Bug(s)* fixed from merged issues.  
*Please note: Bug fixes are counted as references to issues; it does not include bugs that have been fixed without issue reference.