20120410 Client crashes when playing .rrf replays

[20120410 Client crashes when playing .rrf replays]

 

 

Can you give us some details of the errors? What does it say when the error appears? Use Ctrl + C when it pops up and paste it. Also, anything recorded is only compatible with that client and newer.

So we can accurately tell what's problem

 

There no error dumper in my client. The client suddenly "YouRO.exe has stopped working" No dump. Nothing to copy.

[20120410 Client crashes when playing .rrf replays]

 

Make sure your server is compiled to use the correct PACKETVER in the mmo.h file and that your clientinfo.xml file has the correct version set for the packet set. I know very little about replays since ive never used or tried it before.

Replay don't connect to server.

Replay records all activity and saves them, so if you warp to custom map, replay tends to find that map in grf, and loads it, if not found, error. Same applies with custom item/mob, and we cannot tell anything without any logs.

Make sure that you run replay from -Replay tag in your RO CLIENT.

 

Yes, I am using my own client on -Replay

But still having that error.

[@noatk ?? An atcommand that disable attacking?]

 

 

 

 

 

 

(would be great if it can be done via bindatcommand)

I don't think you can make one using via bindatcommand unless there is a script command appropriate with it..

 

so here I make a simple HPM plugin for you..just browse the wiki on how to install it..enjoy..

// Copyright (c) Hercules Dev Team, licensed under GNU GPL.// See the LICENSE file// Sample Hercules Plugin#include <stdio.h>#include <stdlib.h>#include <string.h>#include "../common/HPMi.h"#include "../common/malloc.h"#include "../common/mmo.h"#include "../common/socket.h"#include "../common/strlib.h"#include "../map/clif.h"#include "../map/pc.h"#include "../map/script.h"#include "../common/HPMDataCheck.h" /* should always be the last file included! (if you don't make it last, it'll intentionally break compile time) *//* malufett@yourservice */HPExport struct hplugin_info pinfo = {"ATCMD_NO_ATK",  // Plugin nameSERVER_TYPE_MAP,// Which server types this plugin works with?"0.1",   // Plugin versionHPM_VERSION, // HPM Version (don't change, macro is automatically updated)};struct atk_state{int enabled;};ACMD(no_atk) {struct atk_state *data;if(!(data = getFromMSD(sd,0))){  CREATE(data,struct atk_state,1);  data->enabled = 0;  addToMSD(sd,data,0,true);}if(data->enabled){  data->enabled = 0;  clif->message(sd->fd, "You can now attack normally.");}else{  data->enabled = 1;  clif->message(sd->fd, "You are now disabled to attack.");}return true;}int hook_battle_check_target(int retVal, struct block_list *src, struct block_list *target,int *flag){struct map_session_data* sd;struct atk_state *data;struct block_list *s_bl = src;if( retVal != 1 || src->type != BL_PC ) return retVal;if( (s_bl = battle->get_master(src)) == NULL )  s_bl = src;sd = BL_CAST(BL_PC, s_bl);if(sd && *flag&BCT_ENEMY && (data = getFromMSD(sd,0)) && data->enabled)  return 0;return retVal;}HPExport void plugin_init (void) {char *server_type;char *server_name; /* core vars */server_type = GET_SYMBOL("SERVER_TYPE");server_name = GET_SYMBOL("SERVER_NAME");/* core interfaces */battle = GET_SYMBOL("battle");clif = GET_SYMBOL("clif");iMalloc = GET_SYMBOL("iMalloc");/* addAtcommand */addAtcommand("noatk",no_atk); // @noatkaddAtcommand("na",no_atk); // @na/* postHook */addHookPost("battle->check_target",hook_battle_check_target);ShowStatus ("Running HPM Plugin: '"CL_WHITE"%s"CL_RESET"'.n", pinfo.name);}

 

 

 

 

Bro, I am having this error in console after rebuilding:

 

>> 

 

[Error]: HPM:AddHook Fail! 'ATCMD_NO_ATK' tried to hook to 'battle->check_target

' but HPMHooking is disabled!iv>

not sure if related to this: http://herc.ws/board/topic/7723-building-on-windows-platform-hpm-hooking-errors/#entry46426

 

Thanks!

 

Simple enable it in conf/plugins.conf

 

plugins_list: [	/* Enable HPMHooking when plugins in use rely on Hooking */-	//"HPMHooking",+	"HPMHooking",	//"db2sql",	//"sample",	//"other",]

 

 

 

 

 

but...

 

[Warning]: HPM:plugin_load: failed to load 'plugins/HPMHooking_map.dll', skipping...[Warning]: HPM:plugin_load: failed to load 'plugins/HPMHooking_char.dll', skipping...[Warning]: HPM:plugin_load: failed to load 'plugins/HPMHooking_login.dll', skipping...

because...

------ Build started: Project: plugin-HPMHooking_map, Configuration: Release Win32 ------Build started 11/15/2014 2:30:20 PM.InitializeBuildStatus:  Creating "plugin-HPMHooking_mapReleaseplugin-HPMHooking_map.unsuccessfulbuild" because "AlwaysCreate" was specified.ClCompile:  HPMHooking.c..srcpluginsHPMHooking.c(78): fatal error C1189: #error :  HPMHooking plugin needs to be compiled for a specific server type. Please make sure your Makefiles are up to date.Build FAILED.Time Elapsed 00:00:06.11========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========

from http://herc.ws/board/topic/7714-hpmhooking-charso-failed-to-load/

 

or, I just need to wait?

[20120410 Client crashes when playing .rrf replays]

No error dump of client. Just sudden client crashing.

I am using a 20120410 client, and my full kRO is 20141101

[@noatk ?? An atcommand that disable attacking?]

 

(would be great if it can be done via bindatcommand)

I don't think you can make one using via bindatcommand unless there is a script command appropriate with it..

 

so here I make a simple HPM plugin for you..just browse the wiki on how to install it..enjoy..

// Copyright (c) Hercules Dev Team, licensed under GNU GPL.// See the LICENSE file// Sample Hercules Plugin#include <stdio.h>#include <stdlib.h>#include <string.h>#include "../common/HPMi.h"#include "../common/malloc.h"#include "../common/mmo.h"#include "../common/socket.h"#include "../common/strlib.h"#include "../map/clif.h"#include "../map/pc.h"#include "../map/script.h"#include "../common/HPMDataCheck.h" /* should always be the last file included! (if you don't make it last, it'll intentionally break compile time) *//* malufett@yourservice */HPExport struct hplugin_info pinfo = {"ATCMD_NO_ATK",  // Plugin nameSERVER_TYPE_MAP,// Which server types this plugin works with?"0.1",   // Plugin versionHPM_VERSION, // HPM Version (don't change, macro is automatically updated)};struct atk_state{int enabled;};ACMD(no_atk) {struct atk_state *data;if(!(data = getFromMSD(sd,0))){  CREATE(data,struct atk_state,1);  data->enabled = 0;  addToMSD(sd,data,0,true);}if(data->enabled){  data->enabled = 0;  clif->message(sd->fd, "You can now attack normally.");}else{  data->enabled = 1;  clif->message(sd->fd, "You are now disabled to attack.");}return true;}int hook_battle_check_target(int retVal, struct block_list *src, struct block_list *target,int *flag){struct map_session_data* sd;struct atk_state *data;struct block_list *s_bl = src;if( retVal != 1 || src->type != BL_PC ) return retVal;if( (s_bl = battle->get_master(src)) == NULL )  s_bl = src;sd = BL_CAST(BL_PC, s_bl);if(sd && *flag&BCT_ENEMY && (data = getFromMSD(sd,0)) && data->enabled)  return 0;return retVal;}HPExport void plugin_init (void) {char *server_type;char *server_name; /* core vars */server_type = GET_SYMBOL("SERVER_TYPE");server_name = GET_SYMBOL("SERVER_NAME");/* core interfaces */battle = GET_SYMBOL("battle");clif = GET_SYMBOL("clif");iMalloc = GET_SYMBOL("iMalloc");/* addAtcommand */addAtcommand("noatk",no_atk); // @noatkaddAtcommand("na",no_atk); // @na/* postHook */addHookPost("battle->check_target",hook_battle_check_target);ShowStatus ("Running HPM Plugin: '"CL_WHITE"%s"CL_RESET"'.n", pinfo.name);}

 

 

Bro, I am having this error in console after rebuilding:

 

[Error]: HPM:AddHook Fail! 'ATCMD_NO_ATK' tried to hook to 'battle->check_target

' but HPMHooking is disabled!

not sure if related to this: http://herc.ws/board/topic/7723-building-on-windows-platform-hpm-hooking-errors/#entry46426

 

Thanks!

[20120410 Client crashes when playing .rrf replays]

There may be crash due to some file not found(or using different grf which does not have that specific view ids or maps)

 

Bro, I tried considering that. But isn't the error should already be reproduced not only on replay client but also on main client? Anyways, pretty sure the clients load the view IDs I am using already (no custom map). The crash only occurs exactly the same time I click the "Play" button.

[Building on Windows Platform HPM Hooking errors]

------ Rebuild All started: Project: plugin-HPMHooking_login, Configuration: Release Win32 ------Build started 11/14/2014 11:33:38 PM._PrepareForClean:  Deleting file "plugin-HPMHooking_loginReleaseplugin-HPMHooking_login.lastbuildstate".InitializeBuildStatus:  Touching "plugin-HPMHooking_loginReleaseplugin-HPMHooking_login.unsuccessfulbuild".ClCompile:  HPMHooking.c..srcpluginsHPMHooking.c(78): fatal error C1189: #error :  HPMHooking plugin needs to be compiled for a specific server type. Please make sure your Makefiles are up to date.Build FAILED.Time Elapsed 00:00:00.52------ Rebuild All started: Project: plugin-HPMHooking_char, Configuration: Release Win32 ------Build started 11/14/2014 11:33:38 PM._PrepareForClean:  Deleting file "plugin-HPMHooking_charReleaseplugin-HPMHooking_char.lastbuildstate".InitializeBuildStatus:  Touching "plugin-HPMHooking_charReleaseplugin-HPMHooking_char.unsuccessfulbuild".ClCompile:  HPMHooking.c..srcpluginsHPMHooking.c(78): fatal error C1189: #error :  HPMHooking plugin needs to be compiled for a specific server type. Please make sure your Makefiles are up to date.Build FAILED.

Everytime I build, these 2 keep on having errors, for now I am just ignoring, I just pulled the latest GIT.

 

Is this normal?

[20120410 Client crashes when playing .rrf replays]

So, recording works fine. I already added -Replay to my client command line, and it loads perfectly, but when played my client crashes. What file am I missing? what am I missing?

 

Thanks!

[i can't equip my 'shadow' item.]

@reloaditemdb ?

[NEMO - Client Patcher]

Bro, please check this bug:
I am using 20120410 and adding a custom headgear

2 Chat Flood Allow8 Custom Window Title9 Disable 1rag1 type parameters (Recommended)13 Disable Ragexe Filename Check (Recommended)15 Disable HShield (Recommended)17 Enable Official Custom Fonts19 Enable Title Bar Menu20 Extend Chat Box21 Extend Chat Room Box22 Extend PM Box24 Fix Camera Angles (Recommended)28 Increase Headgear ViewID32 Increase Zoom Out Max33 Always Call SelectKoreaClientInfo() (Recommended)34 Enable /showname (Recommended)35 Read Data Folder First36 Read msgstringtable.txt (Recommended)37 Read questid2display.txt (Recommended)38 Remove Gravity Ads (Recommended)39 Remove Gravity Logo (Recommended)40 Restore Login Window (Recommended)41 Disable Nagle Algorithm (Recommended)44 Translate Client (Recommended)46 Use Normal Guild Brackets48 Use Plain Text Descriptions (Recommended)49 Enable Multiple GRFs (Recommended)50 Skip License Screen63 Use Official Cloth Palettes64 @ Bug Fix (Recommended)68 Enable 64k Hairstyle69 Extend Npc Dialog Box73 Remove Hourly Announce (Recommended)74 Increase Screenshot Quality205 Enable Monster tables75 Enable Flag Emoticons76 Enforce Official Login Background86 Only First Login Background90 Enable DNS Support (Recommended)97 Cancel to Login Window (Recommended)102 Fix Tetra Vortex

Using Nemo Patcher makes my client close suddenly

But using Shin's Diff Patcher with WeeDiffGenerator makes the addition successful

I am not sure where is the problem.

The problem with ShinDP is even if you tick read data folder first, it seems to be not reading the clientinfo.xml inside the data folder (bad for local dev`ing)

Hope you can look on it. /thx

 

UPDATE. Actually, I also learned that diffing with NEMO on 20120410 client will make the shields not showing: http://herc.ws/board/topic/7369-client-is-not-showing-shield-sprite/

 

UPDATE. Also I learned that another issue from my client is also due to diffing with Nemo, http://herc.ws/board/topic/7378-lua-cannot-automatically-allocate-skill-points-on-some-skills/

 

Hope Nemo can solve problem with 20120410 client.

[is it normal to have vending tax? and how to remove it?]

in /conf/battle/items.conf

 

 

// Tax to apply to all vending transactions (eg: 10000 = 100%, 50 = 0.50%)// When a tax is applied, the item's full price is charged to the buyer, but// the vender will not get the whole price paid (they get 100% - this tax).vending_tax: 200

 

 

Is this an official behavior?

[is it normal to have vending tax? and how to remove it?]

is it normal to have vending tax? and how to remove it?

 

I never knew this, is this part of official mechanics?

[Detect all NPC file that uses goto]

script.c

BUILDIN(goto){if( !data_islabel(script_getdata(st,2)) ){  ShowError("script:goto: not a labeln");  script->reportdata(script_getdata(st,2));  st->state = END;  return false;}ShowDebug("script.c: function 'goto' detected!n");st->pos = script_getnum(st,2);st->state = GOTO;return true;} 

 

 

How can it also show the file name and location?

[Detect all NPC file that uses goto]

Why not just do a folder search with "goto"? Usually text editors provide such feature, like I know for sure both Notepad++ and Sublime Text have it via ctrl+shift+f (I use it pretty often, helps to find all the instances of something in specific folder. And if coupled with mass replace it helps even more, like I was able to switch to lowercase commands in all scripts quite easy).

That's what I'm doing but sometimes false detect, *goto*

[Detect all NPC file that uses goto]

I just want to avoid any future trouble, so I wanna ask if there's a way I can detect all NPC files that are using goto function. I have so many custom NPCs. Is there a way these goto function uses to show at my console so I can debug?

 

Thanks!

[Is it normal that "vcproj-10\plugin-HPMHooking.vcxproj" could not be found."]

I pulled last night, is it normal that "vcproj-10plugin-HPMHooking.vcxproj" could not be found.", I cannot see it on the commits.

 

Thanks!

[@noatk ?? An atcommand that disable attacking?]

 

 

(would be great if it can be done via bindatcommand)

I don't think you can make one using via bindatcommand unless there is a script command appropriate with it..

 

so here I make a simple HPM plugin for you..just browse the wiki on how to install it..enjoy..

// Copyright (c) Hercules Dev Team, licensed under GNU GPL.// See the LICENSE file// Sample Hercules Plugin#include <stdio.h>#include <stdlib.h>#include <string.h>#include "../common/HPMi.h"#include "../common/malloc.h"#include "../common/mmo.h"#include "../common/socket.h"#include "../common/strlib.h"#include "../map/clif.h"#include "../map/pc.h"#include "../map/script.h"#include "../common/HPMDataCheck.h" /* should always be the last file included! (if you don't make it last, it'll intentionally break compile time) *//* malufett@yourservice */HPExport struct hplugin_info pinfo = {"ATCMD_NO_ATK",  // Plugin nameSERVER_TYPE_MAP,// Which server types this plugin works with?"0.1",   // Plugin versionHPM_VERSION, // HPM Version (don't change, macro is automatically updated)};struct atk_state{int enabled;};ACMD(no_atk) {struct atk_state *data;if(!(data = getFromMSD(sd,0))){  CREATE(data,struct atk_state,1);  data->enabled = 0;  addToMSD(sd,data,0,true);}if(data->enabled){  data->enabled = 0;  clif->message(sd->fd, "You can now attack normally.");}else{  data->enabled = 1;  clif->message(sd->fd, "You are now disabled to attack.");}return true;}int hook_battle_check_target(int retVal, struct block_list *src, struct block_list *target,int *flag){struct map_session_data* sd;struct atk_state *data;struct block_list *s_bl = src;if( retVal != 1 || src->type != BL_PC ) return retVal;if( (s_bl = battle->get_master(src)) == NULL )  s_bl = src;sd = BL_CAST(BL_PC, s_bl);if(sd && *flag&BCT_ENEMY && (data = getFromMSD(sd,0)) && data->enabled)  return 0;return retVal;}HPExport void plugin_init (void) {char *server_type;char *server_name; /* core vars */server_type = GET_SYMBOL("SERVER_TYPE");server_name = GET_SYMBOL("SERVER_NAME");/* core interfaces */battle = GET_SYMBOL("battle");clif = GET_SYMBOL("clif");iMalloc = GET_SYMBOL("iMalloc");/* addAtcommand */addAtcommand("noatk",no_atk); // @noatkaddAtcommand("na",no_atk); // @na/* postHook */addHookPost("battle->check_target",hook_battle_check_target);ShowStatus ("Running HPM Plugin: '"CL_WHITE"%s"CL_RESET"'.n", pinfo.name);}

 

 

Thank you very much! Wow. I will test this in my local dev before releasing to public.

 

Btw, I forgot, Is it too much if I also want to disable them from chatting like "red mute", it would be annoying for participants if the audience keeps chatting ?

[[Solved] Crashing Map no error on console]

Hello! I just pulled and recompiled. I am wondering why I cannot access map server, it keeps failing to connect after selecting the character.

 

I have Hercules' packet keys enabled.

I don't think it is packet keys, I disabled it on packets.h and battle/client.conf and still can't connect. (

 

Thanks!

 

Btw, how to undo pull?

 

Figured out it was one of my script that makes the server crash,

getitem 31019,14*24*60*60;

supposed to be rentitem

[@noatk ?? An atcommand that disable attacking?]

It keeps me bothered that game masters can hit players in PVP or GVG maps. (accidental)
Actually, I am trying to code a warper where players can watch GvG and PvP events by letting them use @hide temporarily, but they can still attack players, is there also atcommand for not letting invoking players to use skill nor attacks?

(would be great if it can be done via bindatcommand)

The closest I found was from rAthena but it was for GMs http://rathena.org/board/topic/60581-onoff-option-to-disable-gms-attackskill/#entry117746


Thanks!

[Map server crash how to get dump or error log?]

Is there an error log for map server?

My map server is crashing and the console is not saying anything. How do you pinpoint the problem?

 

Thanks!

 

i'm on windows platform.

[updated map user count in PUB every minute?]

found that somewhere in my HDD

http://upaste.me/07c8156078217feff

 

wow, so while(1) would keep the script running, very clever.

Another question, will it be memory extensive if the NPC will be duplicated 20+ times? Because seems like each NPC would getmapuser every <x> millisecond.

Thanks!

 

if this is true, I might just store the data globally. Thanks!

[updated map user count in PUB every minute?]

Haha, I have seen this to some servers, but up to know I have no idea where to start coding.

All I know is that PUB must be created, but to destroy it and update it I have no idea.

 

Can somebody please lead me where to start?

 

Thanks!

[@autotrade fails at first try.]

It's pretty easy to reproduce:

Try to vend items, that you just put in the cart from inventory, and that were in inventory when you logged on, and it will defy those items. I wrote it in the bug report.

 

It should be fine if your local server has latest repo though, so don't even try to reproduce it there

 

Oh thanks! That completely described the scenario. Thanks!

[@autotrade fails at first try.]

Actually, no, but update your repo and it should be fixed.

 

Thanks man! Will try on my next server's maintenance. I can't reproduce my live server's problem in my local.

Thanks!

[@autotrade fails at first try.]

I read something about that because of the "Safety Check" button, try not to tick it when you are going to use autotrade

 

Bro, where is it?