Problem with HP bars (Again)

[Daraen 7]

Hello to the developer of Hercules @Haru @4144 and to all those who contribute to the proper functioning of Hercules.

I was not the only one to "complain" about the visibility problem of the HP bar in WoE on Emperium and Guardian.

I even made a request on github which has been updated 21 days ago now! https://github.com/HerculesWS/Hercules/issues/2912
I have followed your update. https://github.com/HerculesWS/Hercules/pull/2821
 

However it seems that your new update is such that the HP of monsters such as MvP and mini-bosses are no longer displayed.

 

When I use this setup then I get this.

 

Spoiler

// Display some mob info next to their name? (Note 3)
// (does not works on guardian or Emperium)
// 1: Display mob HP (Hp/MaxHp format)
// 2: Display mob HP (Percent of full life format)
// 4: Display mob's level
show_mob_info: 0

// Show hp bar on monsters? (Note 3)
// NOTE: only works on client 2012-04-04aRagexeRE onwards
// 1 = Show hp bar on all monsters except Emperium and MVP
// 2 = Enable hp bar on Emperium
// 4 = Enable hp bar on MVP
// (Default: 1)
show_monster_hp_bar: 1

 

 

See for yourself that Garm (Hati) has no apparent HP bar despite the fact that I attack him

 

Let's move on!

 

New config

 

Spoiler

// Display some mob info next to their name? (Note 3)
// (does not works on guardian or Emperium)
// 1: Display mob HP (Hp/MaxHp format)
// 2: Display mob HP (Percent of full life format)
// 4: Display mob's level
show_mob_info: 0

 

// Show hp bar on monsters? (Note 3)
// NOTE: only works on client 2012-04-04aRagexeRE onwards
// 1 = Show hp bar on all monsters except Emperium and MVP
// 2 = Enable hp bar on Emperium
// 4 = Enable hp bar on MVP
// (Default: 1)
show_monster_hp_bar: 4

 

 

See for yourself that the poring has no more HP bar and that the guardian has a bar now

 

LAST

 

Spoiler

// Display some mob info next to their name? (Note 3)
// (does not works on guardian or Emperium)
// 1: Display mob HP (Hp/MaxHp format)
// 2: Display mob HP (Percent of full life format)
// 4: Display mob's level
show_mob_info: 0

 

// Show hp bar on monsters? (Note 3)
// NOTE: only works on client 2012-04-04aRagexeRE onwards
// 1 = Show hp bar on all monsters except Emperium and MVP
// 2 = Enable hp bar on Emperium
// 4 = Enable hp bar on MVP
// (Default: 1)
show_monster_hp_bar: 5

 

 

See for yourself that the guardian still has the hp bar which should not be the case in view of your update.

 

I don't think I missed an update on this, but maybe I'm wrong. So if there is a place to fix this, can someone let me know?

If the problem really exists for other people, folks developers, I think your best bet would be to change configuration number 4 so that it only displays for normal mvp, mini bosses and monsters and ignores the emperium and them. guardians.

Neither saw any attack on your work, I am simply trying to contribute in my own way to the good development of Hercules.

Cordially

Edited January 5, 2021 by Daraen
Missing pictures

[Samuel 83]

@Daraen ahh sorry, as of now, at default guardians are considered as MVP/boss monsters that's why at default it will not show hp bar. But when config for enabling the HP bar for MVP is enabled, guardians will show HP bar as well. There is no way to differentiate guardians as of now, either they're boss or normal monsters.

 

I have tried to make a pull request: 

Quote

https://github.com/HerculesWS/Hercules/pull/2931

 

I don't know if this is the right fix for this, waiting for the other developers say about it.

 

But I have tested this pull request on my test server and it should work with config:

Quote

// Show hp bar on monsters? (Note 3)
// NOTE: only works on client 2012-04-04aRagexeRE onwards
// 1 = Show hp bar on all monsters except Emperium, WOE Guardians and MVP
// 2 = Enable hp bar on Emperium and WOE Guardians
// 4 = Enable hp bar on MVP
// (Default: 1)
show_monster_hp_bar: 5

With config 5, all monsters & MVP will show HP bar except for Emperium and WOE Guardians

and if ever i have missed any monsters (guardians) you could simply add Guardian:true in their modes and do @reloadmobdb

[Kuya Jeo 120]

5 hours ago, Daraen said:

Hello to the developer of Hercules @Haru @4144 and to all those who contribute to the proper functioning of Hercules.

I was not the only one to "complain" about the visibility problem of the HP bar in WoE on Emperium and Guardian.

I even made a request on github which has been updated 21 days ago now! https://github.com/HerculesWS/Hercules/issues/2912
I have followed your update. https://github.com/HerculesWS/Hercules/pull/2821
 

However it seems that your new update is such that the HP of monsters such as MvP and mini-bosses are no longer displayed.

 

When I use this setup then I get this.

 

  Reveal hidden contents

// Display some mob info next to their name? (Note 3)
// (does not works on guardian or Emperium)
// 1: Display mob HP (Hp/MaxHp format)
// 2: Display mob HP (Percent of full life format)
// 4: Display mob's level
show_mob_info: 0

// Show hp bar on monsters? (Note 3)
// NOTE: only works on client 2012-04-04aRagexeRE onwards
// 1 = Show hp bar on all monsters except Emperium and MVP
// 2 = Enable hp bar on Emperium
// 4 = Enable hp bar on MVP
// (Default: 1)
show_monster_hp_bar: 1

 

 

See for yourself that Garm (Hati) has no apparent HP bar despite the fact that I attack him

 

Let's move on!

 

New config

 

  Reveal hidden contents

// Display some mob info next to their name? (Note 3)
// (does not works on guardian or Emperium)
// 1: Display mob HP (Hp/MaxHp format)
// 2: Display mob HP (Percent of full life format)
// 4: Display mob's level
show_mob_info: 0

 

// Show hp bar on monsters? (Note 3)
// NOTE: only works on client 2012-04-04aRagexeRE onwards
// 1 = Show hp bar on all monsters except Emperium and MVP
// 2 = Enable hp bar on Emperium
// 4 = Enable hp bar on MVP
// (Default: 1)
show_monster_hp_bar: 4

 

 

See for yourself that the poring has no more HP bar and that the guardian has a bar now

 

LAST

 

  Reveal hidden contents

// Display some mob info next to their name? (Note 3)
// (does not works on guardian or Emperium)
// 1: Display mob HP (Hp/MaxHp format)
// 2: Display mob HP (Percent of full life format)
// 4: Display mob's level
show_mob_info: 0

 

// Show hp bar on monsters? (Note 3)
// NOTE: only works on client 2012-04-04aRagexeRE onwards
// 1 = Show hp bar on all monsters except Emperium and MVP
// 2 = Enable hp bar on Emperium
// 4 = Enable hp bar on MVP
// (Default: 1)
show_monster_hp_bar: 5

 

 

See for yourself that the guardian still has the hp bar which should not be the case in view of your update.

 

I don't think I missed an update on this, but maybe I'm wrong. So if there is a place to fix this, can someone let me know?

If the problem really exists for other people, folks developers, I think your best bet would be to change configuration number 4 so that it only displays for normal mvp, mini bosses and monsters and ignores the emperium and them. guardians.

Neither saw any attack on your work, I am simply trying to contribute in my own way to the good development of Hercules.

Cordially

Based on the conf/map/battle/monster.conf

// Show hp bar on monsters? (Note 3)
// NOTE: only works on client 2012-04-04aRagexeRE onwards
// 1 = Show hp bar on all monsters except Emperium and MVP
// 2 = Enable hp bar on Emperium
// 4 = Enable hp bar on MVP
// (Default: 1)
show_monster_hp_bar: 1

The monster bar is working on me.
You cannot see HP of the monster unless  you will hit it.

[Daraen 7]

2 hours ago, Kuya Jeo said:

Basé sur le fichier conf / map / battle / monster.conf

// Show hp bar on monsters? (Note 3) // NOTE: only works on client 2012-04-04aRagexeRE onwards // 1 = Show hp bar on all monsters except Emperium and MVP // 2 = Enable hp bar on Emperium // 4 = Enable hp bar on MVP // (Default: 1) show_monster_hp_bar: 1

La barre de monstre travaille sur moi.
Vous ne pouvez pas voir les HP du monstre à moins que vous ne le frappiez.

I hit it, look at the pictures.

Moreover

 

// Show hp bar on monsters? (Note 3)
// NOTE: only works on client 2012-04-04aRagexeRE onwards
// 1 = Show hp bar on all monsters except Emperium and MVP
// 2 = Enable hp bar on Emperium
// 4 = Enable hp bar on MVP
// (Default: 1)
show_monster_hp_bar: 1

set to 1, does not show HP bar for MvP and emperium.
I need the HP bar to be displayed for all monsters except Emperium and WoE guardian
I have already explained all using pictures

Edited January 5, 2021 by Daraen

[Samuel 83]

2 hours ago, Daraen said:

I hit it, look at the pictures.

Moreover

 

// Show hp bar on monsters? (Note 3) // NOTE: only works on client 2012-04-04aRagexeRE onwards // 1 = Show hp bar on all monsters except Emperium and MVP // 2 = Enable hp bar on Emperium // 4 = Enable hp bar on MVP // (Default: 1) show_monster_hp_bar: 1

// Show hp bar on monsters? (Note 3)
// NOTE: only works on client 2012-04-04aRagexeRE onwards
// 1 = Show hp bar on all monsters except Emperium and MVP
// 2 = Enable hp bar on Emperium
// 4 = Enable hp bar on MVP
// (Default: 1)
show_monster_hp_bar: 1

set to 1, does not show HP bar for MvP and emperium.
I need the HP bar to be displayed for all monsters except Emperium and WoE guardian
I have already explained all using pictures

How did you spawn your guardian in your test?

 

// Display some mob info next to their name? (Note 3)
// (does not works on guardian or Emperium)
// 1: Display mob HP (Hp/MaxHp format)
// 2: Display mob HP (Percent of full life format)
// 4: Display mob's level
show_mob_info: 0

// Show hp bar on monsters? (Note 3)
// NOTE: only works on client 2012-04-04aRagexeRE onwards
// 1 = Show hp bar on all monsters except Emperium and MVP
// 2 = Enable hp bar on Emperium
// 4 = Enable hp bar on MVP
// (Default: 1)
show_monster_hp_bar: 1

 

With this setting, emperium, mvp and guardian doesn't show HP bar using fresh hercules emulator.

 

Only normal mobs shows HP bar.

 

// Display some mob info next to their name? (Note 3)
// (does not works on guardian or Emperium)
// 1: Display mob HP (Hp/MaxHp format)
// 2: Display mob HP (Percent of full life format)
// 4: Display mob's level
show_mob_info: (any value above 1) will work on emperium and guardian as well but still no HP bar

 

@Daraen This following guardians: 1285, 1286, 1287 has this mode:
 

Quote

Mode: {
        CanMove: true
        Aggressive: true
        Boss: true
        CanAttack: true
        Detector: true
        CastSensorChase: true
        ChangeChase: true
        Angry: true
        ChangeTargetMelee: true
    }

 

as you can see they have boss mode enabled thus they are considered MVP afaik, but no MVPexp thus no MVP sign when killed. In default, it should not show for this following guardians.

The easiest thing is to delete the boss: true in their mode do @reloadmobdb and it should work

Edited January 5, 2021 by Samuel

[Daraen 7]

So you did not understand what I said.
in short I try to have the HP bar visible on all monsters except the emperium and the WoE guardians when they are hit.

// Show hp bar on monsters? (Note 3)
// NOTE: only works on client 2012-04-04aRagexeRE onwards
// 1 = Show hp bar on all monsters except Emperium and MVP
// 2 = Enable hp bar o n Emperium
// 4 = Enable hp bar on MVP
// (Default: 1)
show_monster_hp_bar: 1

Currently MVPs are ignored if the value is set to 1.
I try to make the bar visible to everyone when we hit them except for the emperium and the guardians (This is normal behavior but it is not currently)
I'm not trying to display the% hp or the level of the monster.
Thank's for your answers.

Edited January 5, 2021 by Daraen

[wartton 0]

A little off topic  @Darean but, how do you show  this mvp mini icon beside its name, is it a new client feature?

Edited January 5, 2021 by wartton

[Daraen 7]

9 minutes ago, wartton said:

Un peu hors sujet  @Darean  mais, comment afficher cette mini icône mvp à côté de son nom, est-ce une nouvelle fonctionnalité client?

Off topic yes but this is present on the latest version of Hercules

 

You will find the image in data / texture / À¯ÀúÀÎÅÍÆäÀ̽º / montype_mvp.bmp

Edited January 5, 2021 by Daraen

[Daraen 7]

Haha @ Samuel I was telling myself that you did not understand my subject 😛As I said with configuration 5, all the monsters show a bar of HP except in my case and exceptionally the emperium. As you could see in the github requests where you mentioned my subject
I will try to add the guardian function and I will tell you if that fixes my problem

Edited January 6, 2021 by Daraen

[Daraen 7]

OMG @Samuel you are the best.
Your pull request is working wonderfully !!

Here is my config so that everything works as I wanted.
If the solution is not clear, let me know, I will redo a full description.

Thank you so much @Samuel

https://github.com/HerculesWS/Hercules/pull/2931
https://github.com/HerculesWS/Hercules/pull/2931/commits/0cb5f4479650aa77f2709e67daf8fd0285641093

MY CONFIG 

 

// Display some mob info next to their name? (Note 3)
// (does not works on guardian or Emperium)
// 1: Display mob HP (Hp/MaxHp format)
// 2: Display mob HP (Percent of full life format)
// 4: Display mob's level
show_mob_info: 0

// Show hp bar on monsters? (Note 3)
// NOTE: only works on client 2012-04-04aRagexeRE onwards
// 1 = Show hp bar on all monsters except Emperium, WOE Guardians and MVP
// 2 = Enable hp bar on Emperium and WOE Guardians
// 4 = Enable hp bar on MVP
// (Default: 1)
show_monster_hp_bar: 5

 

The guardians and the emperium do have the hidden hp bar when I hit it !!

The mvp show their hp bar as well as all the other monsters!

 

Edited January 7, 2021 by Daraen