Angelmelody 221 Posted April 14, 2015 (edited) @@Dastgir I think the params of hooking functions should be pointer instead of normal variable,so type == SC_HIDING || type == SC_CLOAKING || type == SC_CHASEWALK || .... would be *type == SC_HIDING || *type == SC_CLOAKING || *type == SC_CHASEWALK || ... Edited April 14, 2015 by Angelmelody 1 Kong reacted to this Quote Share this post Link to post Share on other sites
Dastgir 1246 Posted April 14, 2015 @@Dastgir I think the params of hooking functions should be pointer instead of normal variable,so type == SC_HIDING || type == SC_CLOAKING || type == SC_CHASEWALK || .... would be *type == SC_HIDING || *type == SC_CLOAKING || *type == SC_CHASEWALK || ... Ohh there you go, don't know how I missed it in this plugin... Will update in some time v1.3 Available, Refactored some part of the source, Fixed Crash on @hide and @warp 3 Kong, evilpuncker and karazu reacted to this Quote Share this post Link to post Share on other sites
Kong 9 Posted April 14, 2015 Wow so that's the reason I'm getting crashes on Shadow Chaser hehe, thank you @Angelmelody Thanks for fixing @@Dastgir Quote Share this post Link to post Share on other sites
Kong 9 Posted April 14, 2015 (edited) Hi @@Dastgir I tested this morning and I'm not getting any crash signals anymore which is a good thing however when I try to warp using @hide and @warp, aura is gone after loading. It's like removing it on instances where it is supposed to crash before BUT, it will be back when you relog without using @aura. So I guess that's still fine.. In addition to recent tests, hides of shadow chaser including invincibility, chase walk etc are still showing the aura. However if someone on the screen just respawned with the current stalker on hide status, it won't show the aura until the stalker unhides itself. Then problem on hiding the aura again when stalker tries to hide. There's also a weird crash happening again and luckily I was able to get a core dump... Please see attached: Edited April 15, 2015 by Kong Quote Share this post Link to post Share on other sites
Dastgir 1246 Posted April 15, 2015 @@Kong v1.4 Available - Fixed Crash, Refactored Some more Parts. Quote Share this post Link to post Share on other sites
Kong 9 Posted April 15, 2015 @@Kong v1.4 Available - Fixed Crash, Refactored Some more Parts. Were you able to read the core dump? What is the cause of the crash so I can try to reproduce with the latest version haha Quote Share this post Link to post Share on other sites
Dastgir 1246 Posted April 15, 2015 @@Kong v1.4 Available - Fixed Crash, Refactored Some more Parts. Were you able to read the core dump? What is the cause of the crash so I can try to reproduce with the latest version haha It was caused by monsters(Non Player) Units when they try to end the hide effect of themself. Quote Share this post Link to post Share on other sites
Kong 9 Posted April 15, 2015 (edited) @@Dastgir It seems to be working fine, but I had a crash when I character select during @hide when I have @aura on. Trying to do it again Ok after tesing it again I was able to reproduce: I have an NPC that gives Priest Buffs + Food Buffs. When I use @hide with buffs on and @aura on and then character select, boom. map crashes It probably has something to do with status this time Added test: Actually, even without @hide, it will produce a crash. With buffs on These are the NPC buffs: Blessing Inc Agi Gloria Magnificat Impositio Manus + all 6 Food Buffs +10 Added more test: The crash is happening even with @aura off (0, 0, 0) I'm sure it's from auraset.c because when i turn plugin off, it works xD Edited April 15, 2015 by Kong Quote Share this post Link to post Share on other sites
karazu 33 Posted April 15, 2015 (edited) @@Dastgir and @@KongIs this a correct GDB report? Program received signal SIGSEGV, Segmentation fault.status_change_end_preAura (bl=0x7fffea16fe84, type_=0x7fffffffe41c, tid=<value optimized out>, file=0x65f5db "unit.c", line=0x7fffffffe414) at auraset.c:243243 if (sce->timer != *tid && (*tid) != INVALID_TIMER)(gdb) Auraset 1.4 Edited April 15, 2015 by karazu Quote Share this post Link to post Share on other sites
Dastgir 1246 Posted April 15, 2015 @@Dastgir and @@KongIs this a correct GDB report? Program received signal SIGSEGV, Segmentation fault.status_change_end_preAura (bl=0x7fffea16fe84, type_=0x7fffffffe41c, tid=<value optimized out>, file=0x65f5db "unit.c", line=0x7fffffffe414) at auraset.c:243243 if (sce->timer != *tid && (*tid) != INVALID_TIMER)(gdb) Auraset 1.4Hmm.. I should really avoid quick fixes and should give appropriate time to this plugin..Yes that's correct report, and I know why it happens, because I changed PostHook to PreHook and forgot to add some conditions. Quote Share this post Link to post Share on other sites
karazu 33 Posted April 15, 2015 @@Dastgir and @@KongIs this a correct GDB report? Program received signal SIGSEGV, Segmentation fault.status_change_end_preAura (bl=0x7fffea16fe84, type_=0x7fffffffe41c, tid=<value optimized out>, file=0x65f5db "unit.c", line=0x7fffffffe414) at auraset.c:243243 if (sce->timer != *tid && (*tid) != INVALID_TIMER)(gdb)Auraset 1.4Hmm.. I should really avoid quick fixes and should give appropriate time to this plugin..Yes that's correct report, and I know why it happens, because I changed PostHook to PreHook and forgot to add some conditions. Thank you! We will wait for the fix! Quote Share this post Link to post Share on other sites
Kong 9 Posted April 16, 2015 @@karazu Thank you for giving the GDB report Yes we'll wait for the fix Quote Share this post Link to post Share on other sites
Dastgir 1246 Posted April 24, 2015 Hoping it does not crash now . New version added v1.4a Tested several method, and doesn't crash for me Tested methods: 1) having status with/without hide 2) warping with/without hide 3) changing auras with/without hide and having/not having statuses. 1 Kong reacted to this Quote Share this post Link to post Share on other sites
Kong 9 Posted April 24, 2015 (edited) Hoping it does not crash now . New version added v1.4a Tested several method, and doesn't crash for me Tested methods: 1) having status with/without hide 2) warping with/without hide 3) changing auras with/without hide and having/not having statuses. Wow thank you very much. I'll test this asap EDIT: Looking good so far, I've tested it on my test servers and it's working fine. @hide+aura or aura+buffs status does not produce crash anymore. I'm moving this to my Live Server to see if it will still crash. @@Dastgir Map crashed again. To reproduce: - Get aura in-game - Get buffs/status - Character select - Map crash Edited April 24, 2015 by Kong Quote Share this post Link to post Share on other sites
Dastgir 1246 Posted April 24, 2015 Hoping it does not crash now . New version added v1.4a Tested several method, and doesn't crash for me Tested methods: 1) having status with/without hide 2) warping with/without hide 3) changing auras with/without hide and having/not having statuses. Wow thank you very much. I'll test this asap EDIT: Looking good so far, I've tested it on my test servers and it's working fine. @hide+aura or aura+buffs status does not produce crash anymore. I'm moving this to my Live Server to see if it will still crash. @@Dastgir Map crashed again. To reproduce: - Get aura in-game - Get buffs/status - Character select - Map crash Seems like AuraSet likes to make new crashes each time Quote Share this post Link to post Share on other sites
karazu 33 Posted April 24, 2015 Hoping it does not crash now . New version added v1.4a Tested several method, and doesn't crash for me Tested methods: 1) having status with/without hide 2) warping with/without hide 3) changing auras with/without hide and having/not having statuses. Wow thank you very much. I'll test this asap EDIT: Looking good so far, I've tested it on my test servers and it's working fine. @hide+aura or aura+buffs status does not produce crash anymore. I'm moving this to my Live Server to see if it will still crash. @@Dastgir Map crashed again. To reproduce: - Get aura in-game - Get buffs/status - Character select - Map crash Seems like AuraSet likes to make new crashes each time I will test it also.. Quote Share this post Link to post Share on other sites
Kong 9 Posted April 25, 2015 @@Dastgir Haha yes. Hope there would be no crash on the next version Quote Share this post Link to post Share on other sites
Dastgir 1246 Posted April 25, 2015 @@Dastgir Haha yes. Hope there would be no crash on the next version The problem is I can't reproduce the crash with your methods.Can you state which buffs you had? Quote Share this post Link to post Share on other sites
Kong 9 Posted April 25, 2015 @@Dastgir I'm using the Healer NPC that has Food Buffs and Priest Buffs Quote Share this post Link to post Share on other sites
karazu 33 Posted April 25, 2015 @@Dastgir I'm using the Healer NPC that has Food Buffs and Priest Buffs I cannot reproduce the problem, can u please give me ur script? Quote Share this post Link to post Share on other sites
Kong 9 Posted April 26, 2015 Hmm I'll try to produce a core dump log @@karazu @@Dastgir I actually can't reproduce it anymore weird. lol Works fine on my Live Server. You can ignore this for now Quote Share this post Link to post Share on other sites
buczak 1 Posted May 8, 2015 I can use sprite or only effects aura? Thks! Quote Share this post Link to post Share on other sites
evilpuncker 504 Posted May 9, 2015 I can use sprite or only effects aura? Thks! only effects unless you change your client to accept new sprites for aura Quote Share this post Link to post Share on other sites
Dastgir 1246 Posted May 9, 2015 I can use sprite or only effects aura? Thks! only effects unless you change your client to accept new sprites for aura What you guys mean by sprites o_O changelook might work if its like item sprite 1 buczak reacted to this Quote Share this post Link to post Share on other sites
evilpuncker 504 Posted May 9, 2015 I can use sprite or only effects aura? Thks! only effects unless you change your client to accept new sprites for aura What you guys mean by sprites o_O changelook might work if its like item sprite yeah we were talking about item sprites, can you add changelook effect to this plugin then? 1 buczak reacted to this Quote Share this post Link to post Share on other sites
