Hack to npc?

[Alexandria 53]

Hello there, an user could get some items from this npc (it works with cash shop system). Do you have an idea how he could do it?

 

I leave my npc: http://pastebin.com/qWhTmm7H

 

Thank you

[evilpuncker 503]

OnBuyItem is easily hacked with WPE

[Litro 45]

OnBuyItem is easily hacked with WPE

 

has someone report its to devs already?

[Alexandria 53]

Alright, do you have an idea on how to secure this script OR a better (safer) script to recommend please? By the way the server uses Harmony; Never had this kind of troubles before until today... Thanks for your help/recommandations

[Dastgir 1244]

OnBuyItem is easily hacked with WPE

Is it really so??

If yes, one can enable packet encryption to stop wpe.

[Angelmelody 221]

the below Code Snippet is dangerous , after submitting the select option,

 

script should ValidateCost again

                        if( select( "^0000FFPurchase^000000:Cancel" ) == 1 ){                                if( getitemname( atoi( @Currency$ ) ) != "null" )                                        delitem atoi( @Currency$ ),@TotalCost;                                else{                                        set getd( @Currency$ ),getd( @Currency$ ) - @TotalCost;                                }                                for(set @i,0; @i < getarraysize( @bought_nameid ); set @i,@i+1)                                        getitem @bought_nameid[@i],@bought_quantity[@i];                                //message strcharinfo(0),"Received "+getarraysize( @bought_nameid )+" Items.";                                message strcharinfo(0),"[Cash Shop] Transaction completed.";                                mes "thx!";                        }

[Angelmelody 221]

OnBuyItem is easily hacked with WPE

http://herc.ws/board/tracker/issue-3680-npc-onbuyitem-when-attacked-by-wpe/

 

I think It was already fixed by Ai4rei

https://code.google.com/p/eathena/source/detail?r=14616

[Alexandria 53]

 

OnBuyItem is easily hacked with WPE

http://herc.ws/board/tracker/issue-3680-npc-onbuyitem-when-attacked-by-wpe/

 

I think It was already fixed by Ai4rei

https://code.google.com/p/eathena/source/detail?r=14616

 

 

Thank you but it seems it does not work anymore.

[iZeal 5]

what about the regular npc's we have by default out of the box from the git?

[Adam 3]

what about the regular npc's we have by default out of the box from the git?

What about them ?

 

Are you asking if they are safe or are you saying they are safe and should be used instead ?

[iZeal 5]

yes of course if they are safe.