Jump to content
  • Sign Up

bWolfie

Members
 View Profile  See their activity

  • Content Count

    848

  • Joined

  • Last visited

  • Days Won

    34

Posts posted by bWolfie

  4. Posted · Edited by Myriad

    upload your code in code tag or to a site like uppaste or pastebin. we dont want to download stuff. Also, you should describe the issue, what is currently happening and what you are trying to achieve.

  5. Posted · Edited by Myriad

    Requesting someone to make a guide on plugins. It's really confusing trying to make pre-hooks work just for a small part of the function you want to change. It's annoying for everyone having to ask over and over again why my plugin is not working the way it is intended.

    Example, I made a pre-hook, but it ends up ignoring everything that follows this part of the function. Instead of asking somebody the reason behind this, it's good if we can learn ourselves. With the documents and resources available, trial and error is my only option.

    Existing plugin examples is NOT great because there are not examples which cover every aspect of source.

    Will have to go back to editing source if this continues to be a pain -_-

    If I can quote AnnieRuru..,

     

    Quote

    http://herc.ws/board/topic/4842-hpm-pre-hook-allows-to-not-returning-to-original-function/?do=findComment&comment=31211

    HAHAHA !! that's another thing that's not documented

    its like asking us to read the source and figure out ourselves =/

    Rebel reacted to this

  9. Posted · Edited by Myriad

    40 minutes ago, caspe said:

    @Smoke @LucasBrito can u revert BG emblem update?

    because in newer client guild emblem does not show in BG map or require EnbleBGEmblem patch which has alignment problems.

    better show battleground emblem at top of players head than show nothing. User can easily remove BG sword emblem by making them transparent.

    Also if possible please check IP_check function, because it is not working.

    Just installed this plugin, wanted to try it out. I'm unsure what it was like before, but seems the BG Guild Emblems are not displaying correctly.
    https://github.com/Smokexyz/HerculesBG/issues/39

    @caspe it would be better to include #if PACKETVER <= clientver, replacing clientver with the last known compatible one. I'm not familiar with this plugin, but I guess it would be this part?
      

    	/* Display emblem on head of char [lucaslsb] */
#if PACKETVER <= 20141022
	if (hBG_enabled && sd->state.changemap && map->list[sd->bl.m].flag.battleground)
		clif->map_type(sd, MAPTYPE_BATTLEFIELD);
	if (hBG_enabled && map->list[sd->bl.m].flag.battleground)
		clif->map_property(sd, MAPPROPERTY_AGITZONE);
#endif

    and then, 

    		// clif interface overloading [lucaslsb]
#if PACKETVER <= 20141022
		clif->sendbgemblem_area = clif_sendbgemblem_area_overloading;
		clif->sendbgemblem_single = clif_sendbgemblem_single_overloading;
#endif

    but after testing, it seems this is pointless, as the newer clients show the emblems just fine (read below). Better to add a config for whether you'd rather show the sword or not.

     ALSO your alignment issue is not exclusive to guild emblems. It's to do with the zoom in/out of your client. It can happen with some headgears to, such as ugly ass wings.

    Exhibit A, zoomed in.
    mElvGh5.png

    Exhibit B, zoomed to an appropriate amount.
    HWLLYMY.png

  10. Posted

    3 hours ago, ρixєℓ said:

    I diff the client from the zero ro but when I execute it it only opens the setup, does anyone know how to solve it?

    Maybe you have the HKLM instead of .... patch active (forgot what it's called). Disable that one.

  12. Posted

    firstly, you should describe what you are trying to achieve in the future when seeking support.

    When OnTimer is triggered, there is no player attached, so its trying to getitem without player attached.
    better to use addtimer/deltimer for this function

    also you dont need to stop the timer when they logout, since the data gets erased at that point anyway

  15. Posted · Edited by Myriad
    include acmd preview

    This fixes the client hang issue when using the @refresh command while a NPC dialog box/menu is open. I don't know if this plugin will compile, as I made it on the fly, but the command fix definitely works. :)
    Inspired from npc_rr_secure_timeout_timer

    Download: https://pastebin.com/zUzYyz1S 

    ACMD(refresh)
{
    if (sd->npc_id) {
        /**
         * If we still have the NPC script attached, tell it to stop.
         **/
        if (sd->st)
            sd->st->state = END;
        sd->state.menu_or_input = 0;
        sd->npc_menu = 0;
        clif->scriptclose(sd, sd->npc_id);
        /**
        * We will end the script ourselves, client will request to end it again if it have dialog,
        * however it will be ignored, workaround for client stuck if NPC have no dialog. [hemagx]
        **/
        sd->state.dialog = 0;
        npc->scriptcont(sd, sd->npc_id, true);
    }

    clif->refresh(sd);
    return true;
}

  24. Posted

    Will try it out. It's a decision you have to make whether to use it or not, since once you increase storage limit, you shouldn't ever reduce it, since players won't be able to access some items until they empty space :| could prove problematic. This is not exclusive to this plugin, though, thought I'd put it out there :P. Thanks as always, Dastgir!

    Dastgir reacted to this
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept