Jump to content

Nagad

Members
  • Content Count

    109
  • Joined

  • Last visited


Reputation Activity

  1. Upvote
    Nagad reacted to Triedge in Link Item System!!!!   
  2. Upvote
    Nagad reacted to Winterfox in [REQ] New Donation System   
    @@rector
     
    prontera,166,207,4 script Flux Point Shop 4_M_YOUNGKNIGHT,{ openshop; end; OnInit: setarray .@itemIds,501, 502, 503; setarray .@itemPrices, 1, 1, 1; tradertype( NST_CUSTOM ); for( .@i = 0; .@i < getarraysize( .@itemIds ); .@i++ ) sellitem .@itemIds[ .@i ], .@itemPrices[ .@i ]; end; OnCountFunds: query_sql "SELECT balance FROM cp_credits WHERE account_id = " + getcharid( 3 ), .@balance; setcurrency( .@balance ); end; OnPayFunds: query_sql "SELECT balance FROM cp_credits WHERE account_id = " + getcharid( 3 ), .@balance; if( .@balance < @price ) end; query_sql "UPDATE cp_credits SET balance = balance - " + @price + " WHERE account_id = " + getcharid( 3 ); purchaseok(); end;}
  3. Upvote
    Nagad reacted to Dastgir in @whosell   
    @@Alexandria
    That's due to much recent change in plugin system.
    Just remove all lines having GET_SYMBOL
    And have this line at start of file
    #include "common/hercules.h"
     
    Above 2 step will fix the errors.
  4. Upvote
    Nagad reacted to Dastgir in [Release] ExtendedBG for Hercules (with eAmod BG modes)   
    Today's update: optimizing memory usage..
    Upcoming weeks may see the finished product...
  5. Upvote
    Nagad got a reaction from Alexandria in [Release] ExtendedBG for Hercules (with eAmod BG modes)   
    You mean ALL the BGs like in eAmod?? The entire project is almost done?? In this case I'm ready to give you a generous donation for your hard work!! Can't wait to try everything *-* I'm checking this topic every day xD
  6. Upvote
    Nagad reacted to Dastgir in [Release] ExtendedBG for Hercules (with eAmod BG modes)   
    Isnt that statement over exaggerated?I am almost complete(this was going to end on August, but I am having much busy weeks since then(and still)...) Just few days of work on this would finish it(whenever that few days come alive...)
  7. Upvote
    Nagad reacted to randabias in How to fix this problem ?   
    actually i found this sollution to fix black node and missing texture,1.play ragnarok2.when your in game try to push [ Alt+Ctrl+Delete]This will make your Vga reload Driver3.open your task manager,close3.and back to your game4.Problem solve.work on w8.1, gtx 970, latest driver ver 355.82


  8. Upvote
    Nagad reacted to Jguy in HAT - The Hercules Admin Tool!   
    Hi all.
     
    quick update. Home ownership is going well, I'm in the process of moving in and bouncing between my new place and parents house. Internet is scheduled to be installed June 6th, this upcoming Saturday. I suspect the week after internet is installed I might be able to push a few updates more regularly as I had been.
     
    Thank you for your patience.
  9. Upvote
    Nagad reacted to Mumbles in Points to Item Exchanger   
    Released yesterday evening: http://herc.ws/board/topic/4173-utility-coin-trader/
  10. Upvote
    Nagad reacted to Dastgir in Ultimate Guild Ranker   
    File Name: Ultimate Guild Ranker
    File Submitter: Dastgir
    File Submitted: 17 Mar 2014
    File Category: PvP, WoE, GvG, & Battleground
     
    Script By Request : http://herc.ws/board/topic/4756-ultimate-guild-ranking
    Percentage Changes:AgitCount= 20%Emp Break = 50%Active Participants = 20%KDR = 10%
    Features:
    Guild Ranking
    Previous Month Guild Ranking
    Rewards based on previous month

    Edits to made after installing the Script:
    Open npc/guild/agit_main.txt
    Add Following Line
    doevent "UltimateRanker#00::OnEmpBreak";
    Before
    // Adjust Economy Invest Level for Castle set .@Economy,getcastledata(strnpcinfo(2),2) - 5;
     
    Have a Custom WoE? And its not triggering the Script??
    Solution: add the following line on EmperiumBreaking Label.
    doevent "UltimateRanker#00::OnEmpBreak";
     
    Please report any bugs/suggestions.
     
    Click here to download this file
  11. Upvote
    Nagad reacted to Mystery in June & July Digest 2015   
    June & July Digest 2015
    The following digest covers the month of June 1st - June 30th 2015 and July 1st - July 31st 2015.
     
     
    June Digest
     
    Team Changes
    [*]@@4144 has joined the team as a Core Developer.

     
    Development Highlights
    [*]Re-implemented clif->colormes to accept arbitrary colors [*]Plugin load failure now causes Fatal Error [*]Implemented strcmp Function [*]Improved the HPMHookingGen parser [*]Dropped VS9 (Visual Studio 2008) broken/outdated project [*]Fixed an issue causing some structs to be missing from the HPMDataCheck [*]Improved info/error messages during plugin loading [*]Fixing party creation failure condition

     
    Database Highlights
    [*]Changed RC_DemiHuman to RC_DemiPlayer in Pre-Renewal [*]RC_Player, RC_DemiPlayer, RC_NonPlayer, RC_NonDemiPlayer, RC_All [*]Added New Item,Combo. Fixed some item scripts. CleanUp of Some Item [*]Added new costumes from JRO [*]Fix Veteran_Axe and Doom_Slayer_I item script [*]Updated item_bonus document, added missing race2 constants [*]Updated item_db with Race2 Constants

     
    Script Highlights
    [*]Corrected a mistake in the OrcsMemory script [*]Renamed guild and guild2 folder to woe-fe and woe-se [*]Updated Eclage Warps [*]Updated Item Scripts [*]Sura quest fix [*]Fixed costume name in eclage quest [*]Updated Blacksmith job quest with some extra conditions. [*]Added Renewal quest items to Ayothaya Dungeon Entrance quest [*]Added and Optimized Halloween 2013 [*]JobChanger Updated [*]Added duplicates of Riding Creature Master [*]Updated eden_iro.txt [*]Added Ninja Shop [*]Fix Izlude In Shops Location and Direction [*]Updated Buying Shops script [*]Added new NPC constants [*]Fixed Several Bugs(Old GlastHeim) [*]Added missing 'end' in some scripts

     
    June Statistics
    [*]During the period there were 62 Commits. [*]Of these 62 commits, 8 included bug-fixes. [*]3 Commits from Pull Requests.



     

    July Digest
     
    Team Changes [*]None

     
    Development Highlights
    [*]Fixes skill blocks overiding larger blocks [*]Fixed a compile error on armv7l (Raspberry Pi 2 model) [*]Add missing checks into login.c [*]Add missing checks to account_sql.c. [*]Add missing check and NONNULL attributes to char.c. [*]Add missing checks to pincode.c [*]Remove useless checks from char server. [*]Remove useless checks from map server. [*]Move check cards related code into separate functions. [*]Reduce memory usage in HPM in homunculus.c [*]Reduce memory usage in HPM in skill.c [*]Reduce memory usage in HPM in quest.c [*]Reduce memory usage in HPM in status.c [*]Reduce memory usage in HPM in mercenary.c

     
    Scripting Highlights
    [*]Removed blank text contents in NPC scripts. [*]Update Unique ID system to match official now it cover all cash items… [*]Added 2013 Christmas Event [*]Implemented 2012 Headgears Quest [*]Implemented Kagerou/Oboro Gear Enchants. [*]Added Shadow item Refiner

     
    Database Highlights
    [*]Removed all Default Values from item_db [*]ItemDB: Updated Promotional Shadow Item

     
    July Statistics
    [*]During the period there were 38 Commits. [*]Of these 38 commits, 4 included bug-fixes. [*]3 Commits from Pull Requests.

  12. Upvote
    Nagad reacted to Anisotropic Defixation in [Release] ExtendedBG for Hercules (with eAmod BG modes)   
    It depends, for official modes the in-game queue offers more options, plus if I remember correctly it was made usable for one BG mode time ago but never finished completely.
     
    Another thing that would be really good is having both party and random queue option and the random option to have "smart" randomization, creating parties based on jobs so stuff like 5 priests on the same team doesn't happen.
  13. Upvote
    Nagad reacted to Dastgir in [Release] ExtendedBG for Hercules (with eAmod BG modes)   
    Development of this had already started... 
    For more technical changelog along with date :http://server.athenacore.net/getrss.php?q=ebg
  14. Upvote
    Nagad reacted to Winterfox in Card Gambler Girl   
    Hey guys,
     
    i once again want to share a little script i did.
     
    It's a card gambler that works like this:
     
    You pick how many rounds you want to play and which card you want.
    The Card Gambler Girl picks 5 random cards and puts the card you want at the bottom of the pile.
    If you don't like her random picked cards you can get her to pick new ones for a little extra free as long as you can afford it.
     
    Afterwards she throws 3 dice and if atleast 2 share the same number, you get the according card on the pile.
    She does that till you run out of paid rounds or won one card.
     
    You can find the source here: https://github.com/Reilaen/NPC-Releases/blob/master/card_gambler_girl.txt
     
    NOTES: Since i get ridiculously accused of "get rich quick schemes" by Emistry for using a linbucks link to get a little bit of money for each click so you the community and i have both something of this free release, please consider donating me a small amount if you really like this npc.   I will only will fix bugs that are issued on github. Custom changes are only done for pay based on my service conditions that are described here.
  15. Upvote
    Nagad reacted to KirieZ in Configurable Refiner   
    File Name: Configurable Refiner
    File Submitter: KirieZ
    File Submitted: 02 Aug 2015
    File Category: Utility
     
    This is a configurable refiner that I made after reading the request from this topic.
     
    It contains the following options (all of them configurable):
    Normal refine
    Refine N times at once (It's possible to allow this for a different group)
    Set different zeny and item requirements based on item's WeaponLv field
    Display information about the refine like: the safe refine and the chance of the next level.
    Allow the usage of items that increase the success chance
    Allow the usage of items that avoids the item from being destroyed when the refine fails
    (2.0) Ask if want to use items to protect / increase refine chance
    (2.0) Define custom effects when refine fails: stay as is, decrease one level or go back to +0

    Everything is configurable at the end of the script.
     
    I made some tests and it seems to be working correctly, if you run into any bug or wants to suggest a new feature, please let me know and I'll see what I can do.
     
    Click here to download this file
  16. Upvote
    Nagad reacted to Michi in Follow some rathena stuff   
    This is the list that I think it's missing in hercules. I have remove unnecessary log that should not be merge. Maybe this will help. This is just a suggestion =)
     
    http://trac.rathena.org/changeset/17182/rathena
    -Alpha release for eleanor skill (use with caution)
    --Implement : MH_TINDER_BREAKER, MH_CBC, MH_EQC, MH_SONIC_CRAW, MH_SILVERVEIN_RUSH, MH_MIDNIGHT_FRENZY
    --Fix style_change not giving sphere when eleanor attacking, and auto set to fighting mode when created.
    --Add display msg to know in wich mode we are.
    --Remove state check not working well with homon since ??
    --Upd MH_SUMMON_LEGION to use summon mob declaration rather then real mob, and set them as agressive by default
    -Mob doesn't have fixed casttime anymore bugreport:5697
    -Fix few typos
    --Enforce logs.sql to check if table not existing. (remove fail at import)
    --fix bloodylust effect (temp)
    --slave now return final master when killing mob
     
    http://trac.rathena.org/changeset/17206/rathena
    - Fixed chances for inflicting status changes on Spectral Spear (self), Ivory Lance and Pagdayaw
    - Fixed Raid to deal damage in a 7x7 area in renewal (bugreport:7381)
    - Fixed success chance of Storm Gust's freeze status change in pre-renewal, iROwiki says 150% and feedback from official server players confirmed that it is indeed 150%
    - Second phase of the big status resistance update:
    * Created a structure to consider status change source (we are still missing the information and use a copy of target instead right now, lighta is working on a solution)
    * Entered the fully official formulas of all status changes based on an Aegis leak (since source is not in right now the level difference will always give "0")
    * As tick_def2 is never equal to sc_def2, it will not use it by default anymore
    * Applied Deep Sleep's kRO balance update, duration can now be reduced by 50ms for each int and each base level, minimum duration is 5000ms
    * The final chance for the status change will now consider Aegis accuracy (everything between 0.01% and 0.09% should actually be 0.1%, etc.)

    http://trac.rathena.org/changeset/17212/rathena
    -Hotfixs for :
    --bugreport:7364 null SC_STYLE_CHANGE crashing serv (when eleanor die and try to skill afterward)
    --bugreport:7352 skillnotok_hom typo, checking other case.
    -Remove unwanted debuginfo from r17211

    http://trac.rathena.org/changeset/17213/rathena
    -upd homonS skills with Yommy leak infos, thx !
    -fix summon_legion multiple spawn exploit and set summon stats.
    -fix MH_LIGHT_OF_REGENE being broken since eleanor upd (typo)

    http://trac.rathena.org/changeset/17220/rathena
    * Added official Homunculus S mutation quest (previous file renamed).
    * Added 'checkhomcall' & 'morphembryo' commands and updated 'hommutate' command, as required by the Hom-S quest. (code by Aleos/lighta)
    * Modified 'gethominfo' to work for Homunculi in 'rest' state, also needed for the Hom-S quest to run properly.
    * Updated spawns for Scaraba Hole (dic_dun) and Dewata (dew_fild, dew_dun).
    * Minor update to some item scripts.

    http://trac.rathena.org/changeset/17222/rathena
    - Implemented the official stun chance of Bash based on an Aegis leak; basically the base chance (5% per level above 5) will get multiplied by BaseLevel/50.0, so on level 50, it will be 1x, on level 75 it will be 1.5x and on level 99 it will be almost 2x (prior reductions), e.g. a level 99 knight using bash 10 will have a 49.5% base success chance to stun with it (if he has learned the quest skill)

    http://trac.rathena.org/changeset/17224/rathena
    * Added "Play with Baby Cats" to Malangdo quests.
    * Updated quest_db with all remaining Malangdo entries.
    * Temporariliy added new coordinates to Warlock job quest to match new Morroc map. (tid:80650)
    * Fixed some misplaced 'close2' commands in El Dicastes quests (incl. bugreport:7431).
    * Minor changes to script_commands.txt.

    http://trac.rathena.org/changeset/17234/rathena
    * Added "Malangdo Island" to Malangdo quests, and fixed the dialogue in other Malangdo scripts.

    http://trac.rathena.org/changeset/17236/rathena
    * Adjusted @speed so it is no longer reset when a player's status is recalculated. Log out or use @speed -1 to reset to default. (bugreport:7306)
    > Follow up to r17220:
    * Added an extra check if a player does not have a homunculus for 'hommutate' and 'morphembryo'

    http://trac.rathena.org/changeset/17241/rathena
    Updates Reflect Damage to official behavior - bugreport:7393
    Fixes Weapon Crush to be an auto-attack skill - bugreport:7422

    http://trac.rathena.org/changeset/17244/rathena
    Fixes Palm Push Strike to push characters in Safety Wall - bugreport:7500
    Ventus - Zephyr (defensive state) no longer nullifies magic damage - bugreport:7506

    http://trac.rathena.org/changeset/17260/rathena
    -Fix TINDER_BREAKER stuking Eleanor when jump
    -Fix combo continuation after MH_MIDNIGHT_FENZY and MH_EQC
    -Upd console notice, less ambigious

    http://trac.rathena.org/changeset/17262/rathena
    Extremity Fist SP Cap raised to work better with renewal stats - bugreport:7455
    Expanded Super Novice receives +10 stat bonuses for a 0 death counter - bugreport:7394
    Renewal Assassin Cross of Sunset now includes AGI into the formula - bugreport:6604
    Berserk job level check works as intended - bugreport:6960

    http://trac.rathena.org/changeset/17270/rathena
    Initial implementation of Renewal Homunculus stats and growth rates
      -> Note: Formulas were derived from iRO and then modified to roughly match with data growth tables presented by players
      -> Note2: ATK formula is currently being multiplied until renewal attack is implemented because they were too weak with normal formula
    Pyroclastic doesn't give insane ATK bonuses anymore - bugreport:7526
    Weapon Refine and Forging now get straight bonuses when used by Mechanic - bugreport:7509

    http://trac.rathena.org/changeset/17275/rathena
    * Implemented Malangdo NPCs "Cat Invest Helper" and "Storekeeper".
    * Added official and/or improved dialogue for many Malangdo NPCs.
    * Added missing Malangdo Points Merchant.
    * Removed reference to nonexistent 'checkpeco' command. (bugreport:7566)

    http://trac.rathena.org/changeset/17279/rathena
    * Initial implementation of Malangdo Culvert instance and related quests. A huge thanks to Metamorphic for gathering some of the dialogue!
    * Updated Renewal mob_db and mob_skill_db with Malangdo entries. (credits: Lemongrass)
    * Created a 'force drop' flag (4) for map_addflooritem and applied it appropriately. (credits: lighta, follow-up r17274)
    * Fixed KG_KAGEMUSYA active duration. (bugreport:7567)

    http://trac.rathena.org/changeset/17283/rathena
    * Amplify Magic Power no longer affects Release. (bugreport:7400)
    * Thorn Trap cannot be created near another trap, under a target, and has a maximum of 3 active. (bugreport:7488)

    http://trac.rathena.org/changeset/17286/rathena
    - Fix MH_MIDNIGHT_FRENZY and MH_EQC wrong combo duration (6s => 2s)

    http://trac.rathena.org/changeset/17292/rathena
    Updated Basilica to finally act more official - Related to bugreport:171
    Small restructure of disabling skill checks - Fixes bugreport:7411 and bugreport:7577
    Updated 3rd class weight limit bonuses to official (thanks Baalberith) - Fixes bugreport:7019
    Some skill tree cleanup as ALL_INCCARRY and ALL_BUYING_STORE aren't necessary anymore
    Some small fixes to the MVP Arena script (aleos) - Fixes bugreport:7592

    http://trac.rathena.org/changeset/17295/rathena
    - Implemented official Bowling Bash with all its special behaviors including the gutter line (bugreport:4209)
    * As many servers probably want to remove the gutter line problem, it is configurable; just adjust the bowling_bash_area setting in skill.conf
    - Sonic Blow now has a fixed range of 1, even for monsters; a monster can't use this skill if you tank it from farther away (bugreport:3453)

    http://trac.rathena.org/changeset/17296/rathena
    Fixed Poison Mist to accurately display and damage correct area - Fixes bugreport:7600

    http://trac.rathena.org/changeset/17301/rathena
    Song/Dance timers cannot be updated by self without Soul Link - Fixes bugreport:7155
    Updated Magic Crasher for Renewal - Fixes bugreport:6340
    Attempt to fix walking dead by modifying death function sequence - Fixes bugreport:7607 (but blame aleos if it breaks something - he helped me)
    Some code cleanup

    http://trac.rathena.org/changeset/17307/rathena
    Cap reflected damage to max HP of the one reflecting - Fixes bugreport:7375
    Minor fix to Reflect Damage timer going over time limit - Fixes bugreport:7511
    Fix npc_idle_timer error when SECURE_NPC_TIMEOUT is not enabled (lighta) - Fixes bugreport:7623
    Fix freezing issues after being forcefully closed out of an NPC (lighta) - Fixes bugreport:7615
    Some fixing up of Crescent Blow

    http://trac.rathena.org/changeset/17311/rathena
    Re-worked unitwalk script command and updated documentation - Fixes bugreport:7626
    Fixed issue with updating area clients when a player is forced to stand - Fixes bugreport:7635
    Finished updating Crescent Elbow to official behaviour
    Fixed Star Gladiator Miracle not using correct ratio (lighta)
    Fixed character position not always updating correctly (thanks Antares) - Concerning bugreport:7492
    Cleaned up unit.h comments and some other minor issues

    http://trac.rathena.org/changeset/17316/rathena
    Per official behavior, Mistress card effect removes all gemstone requirements on all skills EXCEPT Hocus Pocus and Ganbantein

    http://trac.rathena.org/changeset/17318/rathena
    - Fixed armor refines giving only 0.66 def instead of 0.7 def; please do not "unfix" things just based on info from iROwiki
    - Fixed Bowling Bash, Brandish Spear, Grand Darkness and Meteor Assault reducing def during cast; the only skill that does this officially is Grand Cross (bugreport:7582)

    http://trac.rathena.org/changeset/17320/rathena
    * fix Tetra Vortex triggering cooldown when not enough spheres present bugreport:7598 * fix Tetra Vortex not removing 5th sphere if present after casting * followup to r17316 - Mistress card removes gemstone requirements from Adoramus and Comet

    http://trac.rathena.org/changeset/17321/rathena
    Updated recovery command with many more options - Suggestion tid:82374
    -> Updated documentation on changes
    Updated Overbrand to a closer official area behaviour - Fixes bugreport:7651
    Fixed status effects not being removed correctly (lighta, Akinari) - Fixes bugreport:7634

    http://trac.rathena.org/changeset/17328/rathena
    * Added "Cat Gamers" to Malangdo quests. This marks the completion of the Malangdo episode.
    * Implemented Port Malaya Kafras, guides, sailors, and Eden teleporter.
    * Edited documentation for 'sc_start' and 'addmonsterdrop'/'delmonsterdrop' commands. (follow-up r17326, r17237)
    * Updated atcommand documentation and help file.
    * Minor organizing of script locations.

    http://trac.rathena.org/changeset/17329/rathena
    * Fixed poison status reducing health below 25%
    * Per official behavior, Knight's Auto Counter skill is based off of player's ASPD for delay

    http://trac.rathena.org/changeset/17330/rathena
    - Fixed Novice Figure not giving the HP+30 bonus to Novice High and Super Novice
    - Updated mob_boss.txt to official
    - Fixed an exploit that caused Byorgue to re-summon his slaves every 60000ms rather than every 60000s

    http://trac.rathena.org/changeset/17335/rathena
    * Added more Port Malaya NPCs, adapted from Masao's conversion.
    * Optimized Sage skills quest and cleaned Rogue skills quest.
    * Small edit to mapflag documentation - thanks, Lighta!
    * Code by Zopokx:
    -- Optimized Eden Quests 56-70 (adapted).
    -- Moved "Dollshoi" and "Ponka-Hontas" NPCs (Morroc and Payon Solutions) out of Pre-Renewal directory to npc/quests/mage_solution.txt.
    -- Added support for Baby Novices in Novice Skills quest.

    http://trac.rathena.org/changeset/17336/rathena
    - Minor fixes for El Dicastes quest.

    http://trac.rathena.org/changeset/17337/rathena
    * Implemented HD ore refiners "Mighty Hammer" and "Basta" (hd_refiner). (bugreport:6577)
    * Fixed coordinates of "Suhnbi" (advanced_refiner).
    * Merged Hercules b17e2b7 (adapted):
    -- Implemented official Port Malaya warps.
    -- Fixed bug where players could not take the "Ring of the Wise King" and "Finding a Fairy" quests using the Cat Hand Agent warper inside Eden Group Headquarters.
    -- Fixed bug where players could not complete the "Guardian of Yggdrasil" quest. (bugreport:6855)

    http://trac.rathena.org/changeset/17338/rathena
    * Implemented Blessed ore refiner "Blacksmith Dister" and Refine Ticket NPC. Since these were event NPCs, they are disabled by default.
    * Updated item_db and item_trade with HD/Blessed ores/boxes and Guarantee Refine Tickets.
    * Added remaining Port Malaya generic town NPCs.

    http://trac.rathena.org/changeset/17340/rathena
    * Fixed a small error in the new refiners - thanks, Joseph!
    * Other misc. changes.

    http://trac.rathena.org/changeset/17342/rathena
    * Removed party size check for Malangdo Culverts, as there is none on official servers.

    http://trac.rathena.org/changeset/17343/rathena
    Fixed bugreport:7686
    - quests_dicastes.txt: Fixed variable.
    - quests_13_1.txt: Fixed invalid event label.

    http://trac.rathena.org/changeset/17344/rathena
    * Optimized Mora Enchants.
    * Updated mapflags for some newer maps. (ea:15238)

    http://trac.rathena.org/changeset/17346/rathena
    Revert countitem2 back to original check method - Fixes bugreport:7695
    Update unit_teleport_timer to enforce tid check (lighta) - Attempted fix for bugreport:7696
    Fixed small bugs in Mora Enchants script. (follow-up r17344, credits: Lemongrass)

    http://trac.rathena.org/changeset/17350/rathena
    > Quick fixes:
    * Incorrect quest check in Malangdo quests, "Yggdrasil Berry Gathering". (bugreport:7711)
    * Typo breaking ammunition in hotkeys. (follow-up r17349, bugreport:7709)

    http://trac.rathena.org/changeset/17353/rathena
    Added LG_BANISHINGPOINT hitrate increase - Fixes bugreport:7535
    Fixed pc.c compile warning when not using Renewal Drop Rate (Lighta) - Fixes bugreport:7704
    Some status.c and status.h standardizing (spaces suck)
  17. Upvote
    Nagad reacted to Playtester in Follow some rathena stuff   
    Just a Heads-up for Michi.
     
    The following changes still need to be merged:
     
     
    A
    https://github.com/rathena/rathena/commit/b89b66932511e12b5b168e5dfee3f59e5ed02e49
    Half of the combo code was already working in Herc, I tried to use Herc's structure so it's easier to merge. However when browsing Herc code I found a few bugs that I fixed at the same time:
     
    1. All combos have a hard-coded delay on Aegis, so it won't show up on the Aegis files. By testing I concluded that the canact delay applied is 1000ms - 4*agi - 2*dex whereas the time you can activate a combo is until 1300ms - 4*agi - 2*dex (so effectively you have a 300ms time window to activate them). Even though our old files had different after cast delays specified, my tests on official servers showed that it's same delay for all of them (exactly the same time until I can activate them). The problem is that the current code uses aftercast delay specified in the skill_cast_db and that value was not set for many skills, especially in the renewal database it was missing completely. I solved this by defaulting the aftercast delay of combo skills to 1000ms if not specified otherwise in the skill_cast_db and removing all the delay from the pre-re skill_cast_db. This is still missing on Herc.
     
    Also on rAthena there was the bug that skills that automatically activate but do not go via the Autospell code will not set any canact delay so it was possible use MO_CHAINCOMBO right when triple attack activates rather than after it. We have to manually set canact delay in these cases. This probably needs to be fixed on Herc as well but I'm not sure. Needs to be tested.
     
    Should be easy to merge, on Herc function is called "skill_delay_fix" instead of "skill_delayfix", otherwise identical.
     
    2. Beast Strafing was already fixed on Hercules Renewal, however it was neglected on Pre-Renewal, see this bug report:
    http://herc.ws/board/tracker/issue-8417-beast-strafing/
    Just need to update pre-re/skill_db.txt to fix it as I posted in the thread already. :-)
     
    3. Taekwon combos were already 75% fixed on Hercules. You implemented a new mode "2" of SC_COMBOATTACK which means "set only attack delay but no move delay". I used a similar solution in my commit. However you forgot to forward that variable for TK_COUNTER:
    sc_start2(src, src, SC_COMBOATTACK, rate, TK_COUNTER, bl->id,(2000 - 4*sstatus->agi - 2*sstatus->dex));Just replace this code with sc_start4 as I did in my commit. It's a different function, but the code part is 1:1 identical so it should be easy to merge. 
    4. This is ONLY bugged on Herc: In unit.c, Herc removed SC_COMBOATTACK when moving. However, my tests showed that I could use combo skills even after moving. That means SC_COMBOATTACK should NOT be removed on moving.
     
    5. Herc doesn't have the function skill_combo, but you can find this code part:
    if (combo) { //Possible to chain if ( (combo = DIFF_TICK32(sd->ud.canact_tick, tick)) < 50 ) combo = 50;/* less is a waste. */ sc_start2(NULL,src,SC_COMBOATTACK,100,skill_id,bl->id,combo); clif->combo_delay(src, combo);}As you can see here, it put minimum delay for combos to 50. But actually a delay below aMotion doesn't make any sense because the client will refuse to send skill requests during aMotion in the first place. The only who benefits from a lower delay is a hacker who can send skill requests manually. 
    6. Monk Spirit should make the 4 Monk Combo skills CHAINCOMBO, COMBOFINISH, TIGERFIST and CHAINCRUSH cost only 2 SP, regardless of original cost. Also easy to merge, code is pretty much the same just search for the line:
    req.sp -= req.sp*25/100; //FIXME: Need real data. this is a custom value.Don't forget to remove MO_TRIPLEATTACK from the case list or else you will make it cost 2 SP instead of 0 SP! 
    The rest of my changes were already working on Hercules, no need to merge. :-)
     
     
    B
    https://github.com/rathena/rathena/commit/37faf6b9f6271b657a9c1168bd2011f5be43b5e7
    Strongly recommend to use my solution for Icewall instead of the current "can't cast on same cell again" implementation.
    Reasons are explained here: http://herc.ws/board/tracker/issue-7058-icewall/
     
    (Btw you can close this one - http://herc.ws/board/tracker/issue-144-firepillar-and-traps/)
     
     
    C
    https://github.com/rathena/rathena/commit/902c920b734cdaa0a13650528a6075937edfb95c
    Most of this still needs to be merged. Not sure how easy it is to merge.
    I recommend at least updating map.c and add the unit_blown_immune function. Those changes are 100% backwards compatible.
    My Skid Trap fix should also be easily possible to directly merge (make it knock back away from original position of caster when the trap was placed and make the affected unit unable to walk for 3000ms).
    The rest depends a bit on the existing code structure and might require testing renewal traps, but from a quick look, it looks almost identical to rA, so should be easy to merge I think?
     
     
    D
    https://github.com/rathena/rathena/commit/b6b6b1366a6d30f38bcc895f9215ddee66c5976a
    Should be merged, autobonus is also bugged on Herc in exactly the same way.
    The other half is already merged. :-)
     
     
    E
    https://github.com/rathena/rathena/commit/0d8a7c0313ebba3ebc11fe65906759fcc40fc41f
    These are also bugged on Herc, but the code is a bit different. However it's not too hard to fix. Basically level 1-5 have duration 30000 and level 6-10 have duration 2000. We originally solved that on rAthena by making the duration divided by 15 for players in the status change defense code. But later it was changed to use Aegis behavior and just define different duration in skill_cast_db.
    It is however conflicting with the defense code (divided by 15 TWICE).
    Also there is some weird status change resistance code there that shouldn't be there:
    sc_def2 = st->vit*25 + st->agi*10 + SCDEF_LVL_CAP(bl, 99) * 20; // Linear Reduction of RateThat part should be removed. You CAN'T resist buffs. 
    Also note that SC_ARMORCHANGE on rAthena is SC_STONESKIN on Herc. Otherwise it's quite similar.
     
     
    Hope this helps, just ask if you have more questions.
  18. Upvote
    Nagad reacted to Playtester in Follow some rathena stuff   
    Oh and I forgot to mention that Herc still has custom ABRACADABRA rates rather than rates depending on level of skill used.
    https://github.com/rathena/rathena/commit/da56e53efd7f10da6f2aa546ee88de93e92c646f
    Imo, should have high priority to update as the chance of classchange is more than 10 times higher than officially at the moment.
     
     
    And MVP drop should check first item first, then second, then third, instead of random order:
    https://github.com/rathena/rathena/commit/5110ddbaf47c358a4a656c32043eb9973b3cd0ab
  19. Upvote
    Nagad reacted to zackdreaver in Repository of official sprites and textures   
    Hello community,
     
    A few days ago i came with an idea to make repository of official sprites and textures
    from all non KRO server (eg: JRO, IDRO, TWRO...etc).
     
     
    My dreams is to collect all items from all official RO server,
    unfortunately many of my files got corrupted when merging some files,
    so only around 75% that can be saved.
     
    You can find my repository through this link :
     
    https://github.com/zackdreaver/RO-Clientresources
     
     
     
    Because of many items missing,
    i want your participation to help me completing the files tha not exist in repository
    through Pull Request or give me the required files via comment/PM.
     
     
    (PS: only non KRO files are accepted)
  20. Upvote
    Nagad reacted to malufett in 'job_db1.txt' Redesign   
    'job_db1.txt' Redesign
     
    What is it?
    The file has been upgrade to achieve 2 goals: make it easier for us to update the file and for our users to customize it better. The old hp/sp computation has been drop and replace by hp/sp tables. job_db.conf Format:
    Job_Name: { // Job names as in src/map/pc.c (they are hardcoded at the moment so if you want to add a new job you should add it there)     Inherit: ( "Other_Job_Name" );     // Base job from which this job will inherit its max weight, base ASPD set and HP/SP table.     InheritHP: ( "Other_Job_Name" );// Base job from which this job will inherit its HP table.     InheritSP: ( "Other_Job_Name" );// Base job from which this job will inherit its SP table.     Weight: Max Weight            (int, defaults to 20000, units in Weight/10)     BaseASPD: {                 // Base ASPD for specific weapon type         Fist: 0~200                (int, defaults to 200)         Dagger: 0~200            (int, defaults to 200)         Sword: 0~200            (int, defaults to 200)         TwoHandSword: 0~200        (int, defaults to 200)         Spear: 0~200            (int, defaults to 200)         TwoHandSpear: 0~200        (int, defaults to 200)         Axe: 0~200                (int, defaults to 200)         TwoHandAxe: 0~200        (int, defaults to 200)         Mace: 0~200                (int, defaults to 200)         TwoHandMace: 0~200        (int, defaults to 200)         Rod: 0~200                (int, defaults to 200)         Bow: 0~200                (int, defaults to 200)         Knuckle: 0~200            (int, defaults to 200)         Instrumen: 0~200        (int, defaults to 200)         Whip: 0~200                (int, defaults to 200)         Book: 0~200                (int, defaults to 200)         Katar: 0~200            (int, defaults to 200)         Revolver: 0~200            (int, defaults to 200)         Rifle: 0~200            (int, defaults to 200)         GatlingGun: 0~200        (int, defaults to 200)         Shotgun: 0~200            (int, defaults to 200)         GrenadeLauncher: 0~200    (int, defaults to 200)         FuumaShuriken: 0~200    (int, defaults to 200)         TwoHandRod: 0~200        (int, defaults to 200)         Shield: 0~200            (int, defaults to 0)     }     HPTable:[ 1, .... 150 ]        (int[]) Reference table for base HP per level      SPTable:[ 1, .... 150 ]        (int[]) Reference table for base SP per level     // Note: If table index size is smaller than the max level the server will automatically generate the missing index based on the average increase per level.} Benefit?
    You can now easily specify a class base weight, base aspd for specific weapon types and HP/SP per level. Lessen redundant entries and good for the eyes.. RE ASPD formula is improved to compatibly(less/no more conversion) accept aegis database. Tools?
    http://herc.ws/board/files/file/202-hercules-hpsp-table-generator/ Special Thanks to:
    Awesome @Yommy Best @Michi Incredible @Ind Nice @Beret Links
    Commit: https://github.com/HerculesWS/Hercules/commit/b59b9d1ab4c5a21081cdd2af126997ed7093d743 File: https://github.com/HerculesWS/Hercules/blob/master/db/re/job_db.conf
  21. Upvote
    Nagad reacted to Winterfox in Exp values bugged??   
    There is no reason to doubt what Garr said. 
  22. Upvote
    Nagad reacted to Garr in Exp values bugged??   
    Stop with the panic, what exactly is wrong with that chart?
     
    You do realize that after character hits 98->99 for base exp or 69->70 for job exp his exp is nulled out, like on every level up? That's exactly the case there. If character continues to play AFTER he reached 99 he STILL gets exp, but it's just not shown ingame. As you can see, maximum base exp a 99 trans character can reach is 343.210.000, and 213.852.071 for job exp. Iirc SNs can reach more job exp, but I'm not actually sure on their limit (It's because they have 99 jobs unlike 70 on trans/extended and 50 1st/2nd).
     
    Did you all think character just stops getting exp after hitting 99? ._.
  23. Upvote
    Nagad reacted to Winterfox in Little problem with Interface buttons positioning   
    Did you check if you accidently put a transparent gap in the button while editing it?
  24. Upvote
    Nagad reacted to Neo-Mind in Little problem with Interface buttons positioning   
    u hid 4 buttons by changing their width & height to 1 pixel so it makes sense the last button would show 4 blank pixels to its left.
    Unless you can find a way to completely empty an image and make the client accept it, i don't think you can fix it without hexing
  25. Upvote
    Nagad reacted to zackdreaver in Little problem with Interface buttons positioning   
    @@Nagad
    patch your client with "Ignore Resource errors"
    then use these
    data.zip
     
    tested on 2014-04-16 client

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.