Charms [Item gift effect while in inventory]

[Litro 45]

I got this patch from rathena (attached below), i have patched it in my server (using herc emulator), can some one help me to make it like just one item will be in effect if there is more than one in inventory ?

 

Charms.txt

eA_Charms.txt

[karazu 33]

Dastgir gave me a Plugin for this one.

 

 

U can ask him about it though

[Dastgir 1246]

http://upaste.me/f8b42118100b0bab2
^ This is as it is version, made months ago, there's no compile warnings/errors, but dont' know if it works or not with new rev,

 

How it works?

Add Following to item:

Charm: true

in item_db.conf in whichever item you want.

[Litro 45]

hi sir, how about the main question if there is item marked charm in inventory and later on he got one again other item with different id (so there is 2 charm marked item) is will just one that will giving effect either the first one or the latter?

http://upaste.me/f8b42118100b0bab2
^ This is as it is version, made months ago, there's no compile warnings/errors, but dont' know if it works or not with new rev,

 

How it works?

Add Following to item:

Charm: true

in item_db.conf in whichever item you want.

 

and Thanks for this, the patch used by me giving memory dump when im closing or restarting the map server, i will try this one after removing my patch

[Gerz 7]

 

1>c:usersbanhb_000desktopnewherculespluginscharm_system.c(13): fatal error C1083: Cannot open include file: 'common/HPMi.h': No such file or directory

 

Help, complie with vc 2010

 

Fixed!

 

Another error:

 

HPM:Addhook: unkown Hooking point 'status->calc_pc_additional'!

 

@@Dastgir help!

Edited July 26, 2015 by Gerz

[4144 366]

Look like this code based on still not merged pull request

[Gerz 7]

yes, read it few minutes ago, just may crash or something @@Dastgir, what can i do now?

Edited July 26, 2015 by Gerz

[Dastgir 1246]

Look like this code based on still not merged pull request

Hmm.. Yup, I think that's why I didn't released it.. And i forgot.

I think I manually merged that PR in @@karazu server and then given this plugin.

[Gerz 7]

@@Dastgir, so how about your pull request, did you test it? is it ok? if yes i will merge manually :3

 

Thank you!

Edited July 27, 2015 by Gerz

[Angelmelody 221]

https://github.com/dastgir/Hercules/commit/a6ceeb41d3daf30b1ce8f9c5e5b629977ca80964

 

and you have to generate HPM Hook  manually

[Litro 45]

@@Angelmelody how about centos ? how to generate it ?

[Gerz 7]

Tested!

 

It work but bonus appear only when character log out and log in, change map

 

drop item from inventory effect do not disappear, @@Dastgir

[Litro 45]

Tested!

 

It work but bonus appear only when character log out and log in, change map

 

drop item from inventory effect do not disappear, @@Dastgir

 

tested to, get the same result

[Gerz 7]

@@Dastgir help please!

Edited July 29, 2015 by Gerz

[fourxhackd 9]

Using @Dastgir's updated charms.c plugin found in his Github (Apr 29 2017), I was able to test it and it seems to be working fine on my build.

Dropping the item from my inventory results to the effects (+1 STR in my case) to disappear. Picking the item up returns the effect. The command @itemreset removes the effect as well.

I do however, experience a warning when I build on a unix-based (Ubuntu) system. The warnings showed up when I executed the command:

make clean && make all

Warnings

Despite the warning, the effects seem to be fine and I am currently having no problems whatsoever.