Follow some rathena stuff

[Michi 101]

Hi,

 

I think it will be really intersting to follow some rathena update.

 

I have see that lot of npc have been optimized in rathena and we didn't have this on hercules.

There is also the homunculus S that are not complete in hercules.

There is also some skill update that would be nice to have.

 

I will update this topic with svn revision that need to be implement on hercules.

 

http://trac.rathena.org/changeset/16381/rathena

http://trac.rathena.org/changeset/17220/rathena

http://trac.rathena.org/changeset/17270/rathena

 

There is many other things but this is a start.

 

thanks for your great job =)

 

Special thanks to malu and ind for the renewal formula and new battleground. Guys I love you.

[Mystery 594]

Hi,

 

I think it will be really intersting to follow some rathena update.

 

I have see that lot of npc have been optimized in rathena and we didn't have this on hercules.

There is also the homunculus S that are not complete in hercules.

There is also some skill update that would be nice to have.

 

I will update this topic with svn revision that need to be implement on hercules.

 

http://trac.rathena.org/changeset/16381/rathena

http://trac.rathena.org/changeset/17220/rathena

http://trac.rathena.org/changeset/17270/rathena

 

There is many other things but this is a start.

 

thanks for your great job =)

 

Special thanks to malu and ind for the renewal formula and new battleground. Guys I love you.

 

 

http://trac.rathena.org/changeset/16381/rathena We do have this --> https://github.com/HerculesWS/Hercules/commit/22c75b070526de8b103032f5bf13504af81e0095

 

But the last two, not yet. We would love to just merge things from rAthena but our Source code are a lot different from one another so we have to be careful when we merge from rAthena. Not to mention, Ind and our Dev team is always on a rampage fixing up a lot of things and adding new content.

[Michi 101]

This is the list that I think it's missing in hercules. I have remove unnecessary log that should not be merge. Maybe this will help. This is just a suggestion =)

 

http://trac.rathena.org/changeset/17182/rathena

-Alpha release for eleanor skill (use with caution)
--Implement : MH_TINDER_BREAKER, MH_CBC, MH_EQC, MH_SONIC_CRAW, MH_SILVERVEIN_RUSH, MH_MIDNIGHT_FRENZY
--Fix style_change not giving sphere when eleanor attacking, and auto set to fighting mode when created.
--Add display msg to know in wich mode we are.
--Remove state check not working well with homon since ??
--Upd MH_SUMMON_LEGION to use summon mob declaration rather then real mob, and set them as agressive by default
-Mob doesn't have fixed casttime anymore bugreport:5697
-Fix few typos
--Enforce logs.sql to check if table not existing. (remove fail at import)
--fix bloodylust effect (temp)
--slave now return final master when killing mob

 

http://trac.rathena.org/changeset/17206/rathena

- Fixed chances for inflicting status changes on Spectral Spear (self), Ivory Lance and Pagdayaw
- Fixed Raid to deal damage in a 7x7 area in renewal (bugreport:7381)
- Fixed success chance of Storm Gust's freeze status change in pre-renewal, iROwiki says 150% and feedback from official server players confirmed that it is indeed 150%
- Second phase of the big status resistance update:
* Created a structure to consider status change source (we are still missing the information and use a copy of target instead right now, lighta is working on a solution)
* Entered the fully official formulas of all status changes based on an Aegis leak (since source is not in right now the level difference will always give "0")
* As tick_def2 is never equal to sc_def2, it will not use it by default anymore
* Applied Deep Sleep's kRO balance update, duration can now be reduced by 50ms for each int and each base level, minimum duration is 5000ms
* The final chance for the status change will now consider Aegis accuracy (everything between 0.01% and 0.09% should actually be 0.1%, etc.)

http://trac.rathena.org/changeset/17212/rathena

-Hotfixs for :
--bugreport:7364 null SC_STYLE_CHANGE crashing serv (when eleanor die and try to skill afterward)
--bugreport:7352 skillnotok_hom typo, checking other case.
-Remove unwanted debuginfo from r17211

http://trac.rathena.org/changeset/17213/rathena

-upd homonS skills with Yommy leak infos, thx !
-fix summon_legion multiple spawn exploit and set summon stats.
-fix MH_LIGHT_OF_REGENE being broken since eleanor upd (typo)

http://trac.rathena.org/changeset/17220/rathena

* Added official Homunculus S mutation quest (previous file renamed).
* Added 'checkhomcall' & 'morphembryo' commands and updated 'hommutate' command, as required by the Hom-S quest. (code by Aleos/lighta)
* Modified 'gethominfo' to work for Homunculi in 'rest' state, also needed for the Hom-S quest to run properly.
* Updated spawns for Scaraba Hole (dic_dun) and Dewata (dew_fild, dew_dun).
* Minor update to some item scripts.

http://trac.rathena.org/changeset/17222/rathena

- Implemented the official stun chance of Bash based on an Aegis leak; basically the base chance (5% per level above 5) will get multiplied by BaseLevel/50.0, so on level 50, it will be 1x, on level 75 it will be 1.5x and on level 99 it will be almost 2x (prior reductions), e.g. a level 99 knight using bash 10 will have a 49.5% base success chance to stun with it (if he has learned the quest skill)

http://trac.rathena.org/changeset/17224/rathena

* Added "Play with Baby Cats" to Malangdo quests.
* Updated quest_db with all remaining Malangdo entries.
* Temporariliy added new coordinates to Warlock job quest to match new Morroc map. (tid:80650)
* Fixed some misplaced 'close2' commands in El Dicastes quests (incl. bugreport:7431).
* Minor changes to script_commands.txt.

http://trac.rathena.org/changeset/17234/rathena

* Added "Malangdo Island" to Malangdo quests, and fixed the dialogue in other Malangdo scripts.

http://trac.rathena.org/changeset/17236/rathena

* Adjusted @speed so it is no longer reset when a player's status is recalculated. Log out or use @speed -1 to reset to default. (bugreport:7306)
> Follow up to r17220:
* Added an extra check if a player does not have a homunculus for 'hommutate' and 'morphembryo'

http://trac.rathena.org/changeset/17241/rathena

Updates Reflect Damage to official behavior - bugreport:7393
Fixes Weapon Crush to be an auto-attack skill - bugreport:7422

http://trac.rathena.org/changeset/17244/rathena

Fixes Palm Push Strike to push characters in Safety Wall - bugreport:7500
Ventus - Zephyr (defensive state) no longer nullifies magic damage - bugreport:7506

http://trac.rathena.org/changeset/17260/rathena
-Fix TINDER_BREAKER stuking Eleanor when jump
-Fix combo continuation after MH_MIDNIGHT_FENZY and MH_EQC
-Upd console notice, less ambigious

http://trac.rathena.org/changeset/17262/rathena
Extremity Fist SP Cap raised to work better with renewal stats - bugreport:7455
Expanded Super Novice receives +10 stat bonuses for a 0 death counter - bugreport:7394
Renewal Assassin Cross of Sunset now includes AGI into the formula - bugreport:6604
Berserk job level check works as intended - bugreport:6960

http://trac.rathena.org/changeset/17270/rathena

Initial implementation of Renewal Homunculus stats and growth rates
  -> Note: Formulas were derived from iRO and then modified to roughly match with data growth tables presented by players
  -> Note2: ATK formula is currently being multiplied until renewal attack is implemented because they were too weak with normal formula
Pyroclastic doesn't give insane ATK bonuses anymore - bugreport:7526
Weapon Refine and Forging now get straight bonuses when used by Mechanic - bugreport:7509

http://trac.rathena.org/changeset/17275/rathena

* Implemented Malangdo NPCs "Cat Invest Helper" and "Storekeeper".
* Added official and/or improved dialogue for many Malangdo NPCs.
* Added missing Malangdo Points Merchant.
* Removed reference to nonexistent 'checkpeco' command. (bugreport:7566)

http://trac.rathena.org/changeset/17279/rathena

* Initial implementation of Malangdo Culvert instance and related quests. A huge thanks to Metamorphic for gathering some of the dialogue!
* Updated Renewal mob_db and mob_skill_db with Malangdo entries. (credits: Lemongrass)
* Created a 'force drop' flag (4) for map_addflooritem and applied it appropriately. (credits: lighta, follow-up r17274)
* Fixed KG_KAGEMUSYA active duration. (bugreport:7567)

http://trac.rathena.org/changeset/17283/rathena

* Amplify Magic Power no longer affects Release. (bugreport:7400)
* Thorn Trap cannot be created near another trap, under a target, and has a maximum of 3 active. (bugreport:7488)

http://trac.rathena.org/changeset/17286/rathena
- Fix MH_MIDNIGHT_FRENZY and MH_EQC wrong combo duration (6s => 2s)

http://trac.rathena.org/changeset/17292/rathena
Updated Basilica to finally act more official - Related to bugreport:171
Small restructure of disabling skill checks - Fixes bugreport:7411 and bugreport:7577
Updated 3rd class weight limit bonuses to official (thanks Baalberith) - Fixes bugreport:7019
Some skill tree cleanup as ALL_INCCARRY and ALL_BUYING_STORE aren't necessary anymore
Some small fixes to the MVP Arena script (aleos) - Fixes bugreport:7592

http://trac.rathena.org/changeset/17295/rathena

- Implemented official Bowling Bash with all its special behaviors including the gutter line (bugreport:4209)
* As many servers probably want to remove the gutter line problem, it is configurable; just adjust the bowling_bash_area setting in skill.conf
- Sonic Blow now has a fixed range of 1, even for monsters; a monster can't use this skill if you tank it from farther away (bugreport:3453)

http://trac.rathena.org/changeset/17296/rathena
Fixed Poison Mist to accurately display and damage correct area - Fixes bugreport:7600

http://trac.rathena.org/changeset/17301/rathena

Song/Dance timers cannot be updated by self without Soul Link - Fixes bugreport:7155
Updated Magic Crasher for Renewal - Fixes bugreport:6340
Attempt to fix walking dead by modifying death function sequence - Fixes bugreport:7607 (but blame aleos if it breaks something - he helped me)
Some code cleanup

http://trac.rathena.org/changeset/17307/rathena

Cap reflected damage to max HP of the one reflecting - Fixes bugreport:7375
Minor fix to Reflect Damage timer going over time limit - Fixes bugreport:7511
Fix npc_idle_timer error when SECURE_NPC_TIMEOUT is not enabled (lighta) - Fixes bugreport:7623
Fix freezing issues after being forcefully closed out of an NPC (lighta) - Fixes bugreport:7615
Some fixing up of Crescent Blow

http://trac.rathena.org/changeset/17311/rathena

Re-worked unitwalk script command and updated documentation - Fixes bugreport:7626
Fixed issue with updating area clients when a player is forced to stand - Fixes bugreport:7635
Finished updating Crescent Elbow to official behaviour
Fixed Star Gladiator Miracle not using correct ratio (lighta)
Fixed character position not always updating correctly (thanks Antares) - Concerning bugreport:7492
Cleaned up unit.h comments and some other minor issues

http://trac.rathena.org/changeset/17316/rathena

Per official behavior, Mistress card effect removes all gemstone requirements on all skills EXCEPT Hocus Pocus and Ganbantein

http://trac.rathena.org/changeset/17318/rathena

- Fixed armor refines giving only 0.66 def instead of 0.7 def; please do not "unfix" things just based on info from iROwiki
- Fixed Bowling Bash, Brandish Spear, Grand Darkness and Meteor Assault reducing def during cast; the only skill that does this officially is Grand Cross (bugreport:7582)

http://trac.rathena.org/changeset/17320/rathena

* fix Tetra Vortex triggering cooldown when not enough spheres present bugreport:7598 * fix Tetra Vortex not removing 5th sphere if present after casting * followup to r17316 - Mistress card removes gemstone requirements from Adoramus and Comet

http://trac.rathena.org/changeset/17321/rathena

Updated recovery command with many more options - Suggestion tid:82374
-> Updated documentation on changes
Updated Overbrand to a closer official area behaviour - Fixes bugreport:7651
Fixed status effects not being removed correctly (lighta, Akinari) - Fixes bugreport:7634

http://trac.rathena.org/changeset/17328/rathena

* Added "Cat Gamers" to Malangdo quests. This marks the completion of the Malangdo episode.
* Implemented Port Malaya Kafras, guides, sailors, and Eden teleporter.
* Edited documentation for 'sc_start' and 'addmonsterdrop'/'delmonsterdrop' commands. (follow-up r17326, r17237)
* Updated atcommand documentation and help file.
* Minor organizing of script locations.

http://trac.rathena.org/changeset/17329/rathena

* Fixed poison status reducing health below 25%
* Per official behavior, Knight's Auto Counter skill is based off of player's ASPD for delay

http://trac.rathena.org/changeset/17330/rathena

- Fixed Novice Figure not giving the HP+30 bonus to Novice High and Super Novice
- Updated mob_boss.txt to official
- Fixed an exploit that caused Byorgue to re-summon his slaves every 60000ms rather than every 60000s

http://trac.rathena.org/changeset/17335/rathena

* Added more Port Malaya NPCs, adapted from Masao's conversion.
* Optimized Sage skills quest and cleaned Rogue skills quest.
* Small edit to mapflag documentation - thanks, Lighta!
* Code by Zopokx:
-- Optimized Eden Quests 56-70 (adapted).
-- Moved "Dollshoi" and "Ponka-Hontas" NPCs (Morroc and Payon Solutions) out of Pre-Renewal directory to npc/quests/mage_solution.txt.
-- Added support for Baby Novices in Novice Skills quest.

http://trac.rathena.org/changeset/17336/rathena

- Minor fixes for El Dicastes quest.

http://trac.rathena.org/changeset/17337/rathena

* Implemented HD ore refiners "Mighty Hammer" and "Basta" (hd_refiner). (bugreport:6577)
* Fixed coordinates of "Suhnbi" (advanced_refiner).
* Merged Hercules b17e2b7 (adapted):
-- Implemented official Port Malaya warps.
-- Fixed bug where players could not take the "Ring of the Wise King" and "Finding a Fairy" quests using the Cat Hand Agent warper inside Eden Group Headquarters.
-- Fixed bug where players could not complete the "Guardian of Yggdrasil" quest. (bugreport:6855)

http://trac.rathena.org/changeset/17338/rathena

* Implemented Blessed ore refiner "Blacksmith Dister" and Refine Ticket NPC. Since these were event NPCs, they are disabled by default.
* Updated item_db and item_trade with HD/Blessed ores/boxes and Guarantee Refine Tickets.
* Added remaining Port Malaya generic town NPCs.

http://trac.rathena.org/changeset/17340/rathena
* Fixed a small error in the new refiners - thanks, Joseph!
* Other misc. changes.

http://trac.rathena.org/changeset/17342/rathena

* Removed party size check for Malangdo Culverts, as there is none on official servers.

http://trac.rathena.org/changeset/17343/rathena

Fixed bugreport:7686
- quests_dicastes.txt: Fixed variable.
- quests_13_1.txt: Fixed invalid event label.

http://trac.rathena.org/changeset/17344/rathena

* Optimized Mora Enchants.
* Updated mapflags for some newer maps. (ea:15238)

http://trac.rathena.org/changeset/17346/rathena

Revert countitem2 back to original check method - Fixes bugreport:7695
Update unit_teleport_timer to enforce tid check (lighta) - Attempted fix for bugreport:7696
Fixed small bugs in Mora Enchants script. (follow-up r17344, credits: Lemongrass)

http://trac.rathena.org/changeset/17350/rathena

> Quick fixes:
* Incorrect quest check in Malangdo quests, "Yggdrasil Berry Gathering". (bugreport:7711)
* Typo breaking ammunition in hotkeys. (follow-up r17349, bugreport:7709)

http://trac.rathena.org/changeset/17353/rathena
Added LG_BANISHINGPOINT hitrate increase - Fixes bugreport:7535
Fixed pc.c compile warning when not using Renewal Drop Rate (Lighta) - Fixes bugreport:7704
Some status.c and status.h standardizing (spaces suck)

[KeiKun 8]

^
No idea why commit message is below of it

then you giving the link contains the commit message

 

i was looking to some of what you want

yes Mysterious is still correct, implementing some of what you said to hercules will require re-writing(like porting though not in a new PL)

what i can suggest for you is just to wait and let Ind and the crew to discuss about this
 

[Angelmelody 221]

Offtopic :the eleanor skills were not yet implemented on Hercules 

 

[evilpuncker 503]

indeed we need some of this

[snowflake1963 1]

Has any of these problems with style_change not giving sphere when eleanor attacking?

[evilpuncker 503]

Hi,

 

I think it will be really intersting to follow some rathena update.

 

I have see that lot of npc have been optimized in rathena and we didn't have this on hercules.

There is also the homunculus S that are not complete in hercules.

There is also some skill update that would be nice to have.

 

I will update this topic with svn revision that need to be implement on hercules.

 

http://trac.rathena.org/changeset/16381/rathena

http://trac.rathena.org/changeset/17220/rathena

http://trac.rathena.org/changeset/17270/rathena

 

There is many other things but this is a start.

 

thanks for your great job =)

 

Special thanks to malu and ind for the renewal formula and new battleground. Guys I love you.

 

now you are a core dev

[Michi 101]

I'm working on it but without using rathena work. I will implement official Homunculus S skills. And for other things it's already implemented.

[Dastgir 1246]

Recommending Class_ enums "Class_Normal, Class_Boss, Class_Guardian, Class_All" and RC_All , for item_bonus, so that we dont need to have multiple command for setting all race damage increase by x%

https://github.com/rathena/rathena/commit/dae81222a85f07455bd57276b5eafc6d407f33d0

https://github.com/rathena/rathena/commit/40f70143d44d0209e91a98009751551e0a63e0fe

And

https://github.com/rathena/rathena/commit/32713b9526d774cf780f051289ae93329fcd24d3

https://github.com/rathena/rathena/commit/5e02af25afdd512639b2bc408f5f3fd983160028 (i guess herc dont have this too.)

Edited April 7, 2014 by Dastgir Pojee

[Leecher 1]

I am excited for this to be finished. Since its near to its completion, maybe I'll wait for it. I am tempted to apply the fixes.

[Playtester 18]

Just a Heads-up for Michi.

 

The following changes still need to be merged:

 

 

A

https://github.com/rathena/rathena/commit/b89b66932511e12b5b168e5dfee3f59e5ed02e49

Half of the combo code was already working in Herc, I tried to use Herc's structure so it's easier to merge. However when browsing Herc code I found a few bugs that I fixed at the same time:

 

1. All combos have a hard-coded delay on Aegis, so it won't show up on the Aegis files. By testing I concluded that the canact delay applied is 1000ms - 4*agi - 2*dex whereas the time you can activate a combo is until 1300ms - 4*agi - 2*dex (so effectively you have a 300ms time window to activate them). Even though our old files had different after cast delays specified, my tests on official servers showed that it's same delay for all of them (exactly the same time until I can activate them). The problem is that the current code uses aftercast delay specified in the skill_cast_db and that value was not set for many skills, especially in the renewal database it was missing completely. I solved this by defaulting the aftercast delay of combo skills to 1000ms if not specified otherwise in the skill_cast_db and removing all the delay from the pre-re skill_cast_db. This is still missing on Herc.

 

Also on rAthena there was the bug that skills that automatically activate but do not go via the Autospell code will not set any canact delay so it was possible use MO_CHAINCOMBO right when triple attack activates rather than after it. We have to manually set canact delay in these cases. This probably needs to be fixed on Herc as well but I'm not sure. Needs to be tested.

 

Should be easy to merge, on Herc function is called "skill_delay_fix" instead of "skill_delayfix", otherwise identical.

 

2. Beast Strafing was already fixed on Hercules Renewal, however it was neglected on Pre-Renewal, see this bug report:

http://herc.ws/board/tracker/issue-8417-beast-strafing/

Just need to update pre-re/skill_db.txt to fix it as I posted in the thread already. :-)

 

3. Taekwon combos were already 75% fixed on Hercules. You implemented a new mode "2" of SC_COMBOATTACK which means "set only attack delay but no move delay". I used a similar solution in my commit. However you forgot to forward that variable for TK_COUNTER:

sc_start2(src, src, SC_COMBOATTACK, rate, TK_COUNTER, bl->id,(2000 - 4*sstatus->agi - 2*sstatus->dex));

Just replace this code with sc_start4 as I did in my commit. It's a different function, but the code part is 1:1 identical so it should be easy to merge.

 

4. This is ONLY bugged on Herc: In unit.c, Herc removed SC_COMBOATTACK when moving. However, my tests showed that I could use combo skills even after moving. That means SC_COMBOATTACK should NOT be removed on moving.

 

5. Herc doesn't have the function skill_combo, but you can find this code part:

if (combo) { //Possible to chain	if ( (combo = DIFF_TICK32(sd->ud.canact_tick, tick)) < 50 ) combo = 50;/* less is a waste. */	sc_start2(NULL,src,SC_COMBOATTACK,100,skill_id,bl->id,combo);	clif->combo_delay(src, combo);}

As you can see here, it put minimum delay for combos to 50. But actually a delay below aMotion doesn't make any sense because the client will refuse to send skill requests during aMotion in the first place. The only who benefits from a lower delay is a hacker who can send skill requests manually.

 

6. Monk Spirit should make the 4 Monk Combo skills CHAINCOMBO, COMBOFINISH, TIGERFIST and CHAINCRUSH cost only 2 SP, regardless of original cost. Also easy to merge, code is pretty much the same just search for the line:

req.sp -= req.sp*25/100; //FIXME: Need real data. this is a custom value.

Don't forget to remove MO_TRIPLEATTACK from the case list or else you will make it cost 2 SP instead of 0 SP!

 

The rest of my changes were already working on Hercules, no need to merge. :-)

 

 

B

https://github.com/rathena/rathena/commit/37faf6b9f6271b657a9c1168bd2011f5be43b5e7

Strongly recommend to use my solution for Icewall instead of the current "can't cast on same cell again" implementation.

Reasons are explained here: http://herc.ws/board/tracker/issue-7058-icewall/

 

(Btw you can close this one - http://herc.ws/board/tracker/issue-144-firepillar-and-traps/)

 

 

C

https://github.com/rathena/rathena/commit/902c920b734cdaa0a13650528a6075937edfb95c

Most of this still needs to be merged. Not sure how easy it is to merge.

I recommend at least updating map.c and add the unit_blown_immune function. Those changes are 100% backwards compatible.

My Skid Trap fix should also be easily possible to directly merge (make it knock back away from original position of caster when the trap was placed and make the affected unit unable to walk for 3000ms).

The rest depends a bit on the existing code structure and might require testing renewal traps, but from a quick look, it looks almost identical to rA, so should be easy to merge I think?

 

 

D

https://github.com/rathena/rathena/commit/b6b6b1366a6d30f38bcc895f9215ddee66c5976a

Should be merged, autobonus is also bugged on Herc in exactly the same way.

The other half is already merged. :-)

 

 

E

https://github.com/rathena/rathena/commit/0d8a7c0313ebba3ebc11fe65906759fcc40fc41f

These are also bugged on Herc, but the code is a bit different. However it's not too hard to fix. Basically level 1-5 have duration 30000 and level 6-10 have duration 2000. We originally solved that on rAthena by making the duration divided by 15 for players in the status change defense code. But later it was changed to use Aegis behavior and just define different duration in skill_cast_db.

It is however conflicting with the defense code (divided by 15 TWICE).

Also there is some weird status change resistance code there that shouldn't be there:

sc_def2 = st->vit*25 + st->agi*10 + SCDEF_LVL_CAP(bl, 99) * 20; // Linear Reduction of Rate

That part should be removed. You CAN'T resist buffs.

 

Also note that SC_ARMORCHANGE on rAthena is SC_STONESKIN on Herc. Otherwise it's quite similar.

 

 

Hope this helps, just ask if you have more questions.

[karazu 33]

Recommending Class_ enums "Class_Normal, Class_Boss, Class_Guardian, Class_All" and RC_All , for item_bonus, so that we dont need to have multiple command for setting all race damage increase by x%

https://github.com/rathena/rathena/commit/dae81222a85f07455bd57276b5eafc6d407f33d0

https://github.com/rathena/rathena/commit/40f70143d44d0209e91a98009751551e0a63e0fe

And

https://github.com/rathena/rathena/commit/32713b9526d774cf780f051289ae93329fcd24d3

https://github.com/rathena/rathena/commit/5e02af25afdd512639b2bc408f5f3fd983160028 (i guess herc dont have this too.)

Implement this one please 

[Playtester 18]

Oh and I forgot to mention that Herc still has custom ABRACADABRA rates rather than rates depending on level of skill used.

https://github.com/rathena/rathena/commit/da56e53efd7f10da6f2aa546ee88de93e92c646f

Imo, should have high priority to update as the chance of classchange is more than 10 times higher than officially at the moment.

 

 

And MVP drop should check first item first, then second, then third, instead of random order:

https://github.com/rathena/rathena/commit/5110ddbaf47c358a4a656c32043eb9973b3cd0ab

Edited November 5, 2014 by Playtester

[Masao 13]

Bump, hope all the stuff playtester mentioned will soon be implemented in Herc. since it's really usefull and needed stuff for the running servers out there.

[Playtester 18]

More fixes to merge:

 

1.

https://github.com/rathena/rathena/commit/04a1173f7d4c0e1ffbace05d34d8b60dfd037a94

Plant damage code will be hard to fix, probably better to just implement it yourself. I posted all the test data in the corresponding bugreport thread here:

http://rathena.org/board/tracker/issue-9380-plant-damage/

The skill damage and hit definition can just be merged, though. The fix is still missing that Fire Pillar also should be unable to hit plants, I fixed that in a follow-up (see below).

Found plant code important to fix because I noticed several classes can kill plant mode monsters very easy with certain skills although they shouldn't be able to.

Land Mine fix should be easy to merge (simply didn't make sense that it deals the highest damage and still has AoE like Blast Mine which is much weaker).

Fixed reflect flag - not sure if there's a conflict in Herc as well since it uses different flags.

Sightblaster code improvement is something I got from idAthena, prevents a possible crash fix (even though I have my doubt that sce can be NULL at that point).

 

2.

https://github.com/rathena/rathena/commit/525e8178c27327f000e15ba557c6ed37a371c0b2

Several Waterball improvements. Fix is not perfect, but important as it fixes several critical exploits that were possible with the old version.

Removal of knockback of Crimson Fire Formation (bug report is on Herc forums about it).

Bosses ignoring skill induced walk delay should be added at the same time as the Waterball update (so they don't get stuck for 10 seconds).

The timer interval is probably Herc's own decision. We decided in rAthena that accurate emulation takes priority over performance. In any case since it's just changing a define, each server owner can do it himself (but I still like it if the official behavior is the default).

 

3.

https://github.com/rathena/rathena/commit/e7e8b5454b8093840cb2a9c03903ca08ffeeae4d

Finally implemented Land Protector to behave as on official servers. This was the most-wanted bugfix of players / server owners when I asked around, that's why I took the time to investigate and fix it. All the skills and Storm Gust knockback need to be updated at the same time as they are all related to the Land Protector issue.

There's also a bugreport about it on Herc forums. Merged

 

4.

https://github.com/rathena/rathena/commit/08bf5112a1f12fd5ae1b3715eddfa2918370d20d

Follow up to plant damage -> Fire Pillar should not be able to hit plants (you can hit plants because the AoE of level 6-10 is 5x5 so you can place Fire Pillar two cells next to a plant and then let a monster walk over it).

Also fixed Acid Bomb (the ground skill) interval for renewal, although that still doesn't fix it fully as in renewal it should be ATK+MATK and not just ATK. Well the interval was easy to fix so I did that quickly. Merged

 

5.

https://github.com/rathena/rathena/commit/d9a9a024f6ef47c48679629fa508dcb6793a8dce

Small Magnum Break damage fix. Merged

Edited November 24, 2014 by Playtester

[Playtester 18]

The Land Protector fix was merged so I crossed it out.

 

In meantime I did some more smaller fixes:

 

1.

https://github.com/rathena/rathena/commit/a0bd0168cf0e7fa257f67bd5eae4d2a4721a6807

Same issue is on Herc. Autobonus3 is called in skill_onskillusage, but it's only called in skill_attack by default. There are skills that don't use skill_attack in particular nodamage and ground skills. For nodamage skills it was already implemented to separately call skill_onskillusage, but it also needs to be done for position skills.

 

2.

https://github.com/rathena/rathena/commit/13d1c2dcd93f7a789266b312ec8c420c20a51077

This was mostly correct on Hercules already, except for the bonus from Musical Lessons. Bonus should increase at every even number (2, 4, 6, 8 and 10) instead of every odd number.

 

3.

https://github.com/rathena/rathena/commit/d20ac845d1e2fe90eb0fcbf50365f7f2207234bc

On officials direction of a unit doesn't change when it attacks, so when a knockback depends on direction, it will depend on the last direction walked into even when attacking in the opposite direction. Merged

 

4.

https://github.com/rathena/rathena/commit/0fd7ba72dfea51b037f02ebc77c00d5f7e585a6a

On one hand fixed 1st Transcendent Spirit. On officials it basically works like Marionette Control, it calculates the bonus at cast (which makes stats go to BaseLevel-10 with a maximum of 50). If there are other buffs later it's added on top of the bonus (except for Agi Up and Blessing which cancel the soullink directly). There was a lot wrong with this skill which is all fixed now. :-)

Even more interesting than that is that I fixed several position lag issues. Basically the client will not display complex paths properly. On official servers, monsters won't even start chasing a target when the path to it is too far. If a monster does anyway (as on emulator) the path of the monster will not be displayed properly. There was also an issue that a monster displayed "irregular movement" which causes high position lags when a status changed ended (e.g. Quagmire) which I also fixed. Finally there was also a problem that sometimes I monster stopped chasing but still displayed as "moving" on the client.

When merging, please also merge the follow up fix: https://github.com/rathena/rathena/commit/0359420f422cfdb8bd24dc2623d6235b77123178 Merged

 

5.

https://github.com/rathena/rathena/commit/e6caa9569b62eec5093954a4298ff0d2632cdb53

Seems the skill menu bug is already fixed on Hercules.

The looter behavior is quite wrong on Hercules as much it was on rA, though. Looters should only run to items that are in a linear line of sight (not walk around corners to get an item). Also they will always target the first item that drops (on Herc, it's still closest item). Plus their loot range is only "0" meaning they have to be on the same cell as the loot. It makes quite a difference because it makes them walk around a lot to loot stuff whereas on Herc it's basically just walk to an item and then take everything.

Edited November 24, 2014 by Playtester

[Playtester 18]

Due to my declining health, I probably won't be able to do as many updates on rAthena anymore (but it's pointless if they don't get merged to Hercules anyway), so here are the last two updates I did that should be merged to Hercules if there aren't yet (sorry, no energy to check):

 

1.

https://github.com/rathena/rathena/commit/861112b89b58eeeb875d36b0c59f3e999b5f528d

Official behavior of Gravitational Field and official ranges for Ganbantein and Gravitational Field. This makes the skill quite unique and really interesting. For example how it allows to add autocasts to the formula.

I think some of the minor fixes are not needed on Herc due to different damage code.

 

2.

https://github.com/rathena/rathena/commit/b5fd69b64d6456df04f14930a022f712be460488

Spiritual Bestowment fix. Not sure if it works properly on Herc. It should only consume a sphere if a sphere is actually transferred (so if the target already has 5 you won't lose any) and also should not work on Gunslingers.

 

Maybe once all my fixes are on Herc I come back. =3

[Mystery 594]

Maybe once all my fixes are on Herc I come back. =3

You were really never here o_o. What do you mean you'll come back? xD

[Dastgir 1246]

(but it's pointless if they don't get merged to Hercules anyway)

 

Anyone is welcome to do PR,

I guess PR is relatively accepted/rejected muh more faster.

[Playtester 18]

What do you mean you'll come back? xD

I meant back to RO emulator development.

 

 

Anyone is welcome to do PR,

I'm using SVN so I can't do it myself, but feel free to blatantly use all my commits. I did them all for the players and not for myself. :-)

Edited January 14, 2015 by Playtester

[Nagad 1]

Does Hercules includes this stuff now?

[Dastgir 1246]

If the merge is sensible, you can list it better.

[Dastgir 1246]

Anyone want to list the commits?

[Jezu 25]

Yes please!