-
Content Count
289 -
Joined
-
Last visited
-
Days Won
28
Posts posted by kisuka
-
-
My vote is for Kernel style, since majority of scripts already use this style. Some small tweaks would need to be made still but for the most part, most scripts already are in a form of kernel style.
Once we agree on the style we should figure out the final decision on this max line length thing.
Typically with kernel style, the max length is 80 characters per line.
-
I just wanna say.. please remember that Sirius_White is pretty busy with personal life stuff as well :/ Harmony is still a project of his, but as most of us know, it's hard to juggle projects with personal life. Please don't hound him to release updates. He will when he has time.
-
I remember this xD fun stuff. Reddozen has been creating some really cool things with Gate of the World since Project Janus kinda stopped.
-
Can you explain what you mean when you say it 'highlights' the block of script pan? Cuz I have my own syntax highlighter in Sublime Text 2 specific for scripts, so my blocks are always highlighted if I select one of the braces of that block.
-
- So basically, change K&R to Kernel Style instead? Anyone have any input on this? I'm fine with it. I just want us to decide on a standard.
Kernel : https://www.kernel.org/doc/Documentation/CodingStyle
K&R : http://en.wikipedia.org/wiki/1_true_brace_style#K.26R_style
- I'd vote for 80 characters, for the fact that the limit per NPC message line is 35 characters. Also organizes the script header nicely (we had it at 64 characters previously for the header, so we get a bit more room now, 120 seems overkill for the header.)
- I'm fine with the underscore method for variable names. If it's underscore method there should be no uppercases. Should be all lowercase with _ representing a space between words.
Completely agree with your changes Haru.
-
I like the standards, but maybe this could break that:
announce "this is such a great and big announcement that can maybe be inside of an official script, how will you cut it out?",bc_all;
And only thing I don't like is that I'd prefer to see this on an if-else statement because I feel it's more clear:
if (this) {}else if (that) {}else {}
P.S.: I can't seem to download the alberta text?
else if would indeed look like that using the K&R styling. I'll specify an else-if statement example in the standards.
hmm... that's a good question regarding the long announce command. Perhaps multi-line solution? like...
announce " this is such a great and big announcement that can maybe be inside of an official script, how will you cut it out?",bc_all;
The longest announcement command currently in official is about 217 characters.
The 80-character limit is something should be given lots of feedback about. I only specified 80 characters due to the fact that it fits somewhat nicely in a terminal window, and is an old standard. PHP for example allows for a limit of 120 characters per line. So this rule should be given a limit which everyone agrees is the best 'standard' limit that also fits all commands nicely. Basically the limit would impose that a 'good script' doesnt have an announce command that has more than 200+ characters.
One purposed suggestion could be that the line limit be 255 characters and that message commands be on 1 line up until 255 line limit then terminated. This would organize the scripts better in-game anyways in my opinion as they'd be cut off at the 35 character limits automatically, rather than manually specifying them in the script.
There could also just be no line limit if people agree on this.
-
Since the beginning of scripting in the Athena project, I don't believe, or can remember of, a set of guidelines / standards which have ever been released. Standards are created as a way to develop a style which remains consistent among all script releases.
Due to the lack of standards, most athena scripts are styled depending on the scripter / author's personal preference. This has resulted in a mix of styles, which have become hard to read, and even harder to contribute to in the future (due to ugly script styling).
Because of this, I would like to propose a set of Scripting Standards, to finally get us on track to clean scripts in the Athena Project.
Attached are the standards I have developed, as well as an example script following the standards. Please review them and be sure to let me know what you think.
This is by no means accepted into the community yet, I would like feedback first before this is even considered to be official.
Thank You.
(Files best viewed in : Sublime Text 2 or Notepad++)
-
A sad day for the history of Athena. You will be missed greatly by this community Yommy.
-
Welcome
-
Sorry for the delay. My job has had me overworked for about a month or so now, I should be free'd up after tomorrow and can get back to the Academy scripts.
They are almost finished, a small portion of untranslated text remains (the last part of each job quest), then I just have to convert to AS (Athena Script) and QA it.
The updates I rolled out were pre-reqs for the academy as they have some interesting script commands. The quest log / bubbles will need to be overhauled 1 last time before I roll out the scripts, so expect that as well.
After academy the goal is to knock out the to-do lists we have on our issues section on github.
-
I have no idea how my name get inside
I never apply as a developer, and all things I have done is just promoting eathena/rathena with custom made scripts
though, I admit at some point I did help the developers fixed some script related bugs,
but only by providing a patch, the developer just applied it
if my name is inside, there is more members like
keyworld - suggest freeloop, getargcount()
toastofdoom - suggest bindatcmd and string manipulation script commands
Yhn - I recall him making some official eathena scripts back in 2006 ...
Trancid - he's the one who started wiki scripting guide, we just expanded it later
shazeya and seventh were helped too, they were past admin
and you guys missed mentioning about freya emulator ... though I already see all their names inside
I added you because you've helped contribute greatly to the community for a long time :3 again, this list is a work in-progress. Anyone who made an impact is to be added. It's only fair. Athena would be no where today without the help of the community and those that have given back to the project.
<3
-
You can set the ports to anything you want as long as you don't already have an application using said port. Just up the 2nd char and 2nd map by 1 number on the ports, should be fine. Make sure you keep the login server info the same if u are making it have the same login info.
-
-
Also on our to do list
-
2013.12.23: Episode 15.2 Memory Record (Sakray Server)
Sakray Server
- Episode 15.2
- Update world map
-> Show mobs, npcs and airhsip travel (no real time position).
-> Show new world maps.
Little info:
Maps
New NPCS:
4_f_berrytea
4_f_fruit
4_gc109
4_m_death2
4_m_rekenber
4_m_tatio
4_machine_device
4_scr_mt_robots
4_sys_msg
New Mobs
dr815
gc109
scr_mt_robots
sys_msg
t_w_o
New World Map:
Credits: i xD
Central Laboratory Instance (Episode 15.2)
New UI World Map (Navigation System Integration)
Sakray testing != release, it's testing and tons of changes happen to these things during sakray. I want to keep this list for main server releases only.
-
NPCs of the clan system are not there on the map, how do I add?
We don't have it yet ^^; We are missing most of the stuff from episode 14.1 and onward. This list was made as a way to figure out what all we're missing, and work on getting back on track to matching official like we used to in the glory days.
-
-
Just a random suggestion, update the css to be responsive so the design resizes based on screen size.
-
can we follow iRO novice academy and training bcoz its almost the same in kRO when i watch the video of Zui in you tube
i have some of the script of novice academy in iRO by using packet parser of yommy but still incomplete
I have new izlude + novice academy about 80% finished. Currently on hold as I finish up some work with my job. Looking at a January release.
On a related note, it's almost like kRO. iRO heavily modded it towards the end of the job quests. In kRO: Warp to job test. In iRO: Changes job without need for quest.
-
ummm... these are just javascript files for iRO-Wiki's calculator... they aren't really "Official iRO Scripts" as iRO-Wiki is a fan made and ran website. Not to mention formulas differ on iRO in some aspects.
-
likes
Likes that you like <3
-
This is a work in progress. Parts will be added as they are organized.
This topic will list out the major episode releases of kRO and the updates under them. This is to keep track of what episodes had which updates. This will assist us in making sure we aren't missing anything in Hercules. The dates below are for Main server release, not RE/Sakray testing period.
* Note: Official Hercules Developers and High Council members have permission to add or modify this list.
2002.08.03: Episode 1.0 : Start of the Adventure
2002.12.17: Episode 2.0 : Lutie
2003.02.04: Episode 3.0 : Comodo
2003.05.02: Episode 4.0 : War of Emperium
2003.07.15: Episode 5.0 : Yuno
2003.10.07: Episode 6.0 : Global Project- 2003.10.11 : Amatsu
- 2003.10.11 : Kunlun / Gonryun
- 2003.11.25 : Weddings/Marriage
- 2004.01.13 : Super Novice
2004.01.30: Episode 7.0 : Umbala ~ Village of the Utan Tribe
- 2004.02.02 : 2-1 and 2-2 class in Sakray
2004.02.24: Episode 8.1.1 : Niflheim ~ City of the Dead
2004.12.23: Episode 8.1.2 : Louyang & Jawaii
2004.12.23: Episode 8.2 : Ayothaya
2005.01.18: Episode 8.3 : Payon Remodelling
2005.05.12: Episode 9.0 : Rebirth
2005.09.21: Episode 10.1.1 : The Sign & Geffenia Dungeon
2005.09.22: Episode 10.1.2 : Einbroch
2006.02.24: Episode 10.2 : Lighthalzen
2005.08.16: Episode 10.3 : Noghalt
2006.12.28: Episode 10.4 : Hugel
2007.04.20: Episode 11.1 : Rachel
2007.09.10: Episode 11.2 : Veins
2007.04.10: Episode 11.3 : Nameless Island- 2007.04.10 : Mercenary System
2007.10.17: Episode 12 : Satan Morroc
- 2007.10.17 : Moscovia
- 2007.11.21 : WoE: SE (Schwaltzvald)
- 2007.11.21 : WoE: SE (Arunafeltz)
- 2007.12.05 : World Map System
- 2007.12.10 : Battlegrounds
- 2007.12.12 : Endless Tower & Sealed Shrine
2008.06.25 : Episode 13.1 : Ash Vacuum
- 2008.08.25 : Poring Wars
- 2008.11.19 : Improved Pet System
2008.12.17 : Episode 13.2 : Encounter
- 2008.12.23 : New Pets
- 2009.02.25 : Hidden Slot Enchantment
- 2009.03.11 : Endless Tower Fixes
- 2009.04.08 : New Hairstyles
- 2009.06.17 : Renewal Release (3-1 Jobs)
- 2009.08.19 : Brasilis
- 2009.10.14 : 3-2 Jobs
2009.12.23 : Episode 13.3 : El Dicastes
- 2010.03.17 : Party Recruiting System
- 2010.03.31 : Baby 3rd Jobs
- 2010.05.12 :
- Purchasing Shops.
- Sorcerer Spirit System
2010.06.30 : Episode 14.1 : Bifrost
- Memorial Dungeon, Misty Labyrinth Forest.
- 2010.07.28 : Equipment Synthesis, Costume System.
- 2010.08.18 : Search Vending Shops
- 2010.09.29 : Indonesia Localized Map, Dewata
- 2010.11.24 :
- Cat Hand HQ / Malangdo Island
- Item Mall Icon
- Level 86~99 Eden Group Quests on 2nd Floor
- Floor 6 added to Izlude Dungeon (Only available to Gold Netcafe Users)
- Grave Markers (MVP or major monster dies, it leaves a grave marker that shows the time of death and who killed it. The gravestone will remain until the monster respawns.)
-
New Mounts
- 2010.12.29 : Super Novice Expansion
- 2011.03.09 : Replay System
- 2011.03.30 : Biolabs 4th Floor
- 2011.05.25 : Thanatos Tower Changes.
- 2011.06.29 : (WoE1 Renewal)
- Number of forts reduced from 5 to 4 in WoE1 castles.
- Guild Investment System (Hall of Abyss).
-
New Guild Dungeon
- 2011.08.17 : 7x7 Padding around NPCs.
- 2011.08.31 : (Class Balance + Homunculus S)
- Large number of class balancing improvements.
-
Homunculus S
- 2011.09.28 : Philippines localized map, Port Malaya. [1] [2]
- 2011.11.02 : Kagero and Oboro Job Classes [1] [2]
- 2011.11.16 : New Alberta.
- 2011.11.30 : Eden Quests for levels 100~110.
- 2011.12.07 : Nightmare mode for Pyramid Dungeon.
- 2011.12.14 : Party System improvements.
2011.12.21 : Episode 14.2 : Eclage
- 2011.12.27 : Battlegrounds Queue System
- 2012.02.08 : New Carts for Mechanics & Genetics.
- 2012.02.08 : Guild Creation system to no longer allow blank space(s) in the name.
- 2012.03.21 : Eden Quests for Level 111 ~ 120.
- 2012.03.21 : Falcon Flute
- 2012.03.28 : Navigation System.
- 2012.03.28 : New Izlude + Novice Training Academy + New Character Creation Method (5 copies of Izlude)
- 2012.04.04 : HP Bars added to Monsters.
- 2012.04.18 : Changes to Enchanting on Malangdo
- 2012.04.25 : WoE: Training Edition
- 2012.04.25 : Transcendent quest to waive the cost of transcending.
- 2012.05.30 : Old Glastheim memorial dungeon
- 2012.06.13 : Monster Shadow Size
- 2012.07.11 : Headgear Synthesis Quests
- 2012.07.25 : WoE:TE Mini God Item quest + guild and daily quests in siege areas.
- 2012.08.14 : Job EXP increased from Monsters with lvl 100+.
- 2012.08.22 : Heroes' Trails (Part 1)
- Faceworm Nest, Memorial Dungeon.
-
Sarah's Memory, Memorial Dungeon.
- 2012.08.22 :
- Memorial Dungeon, Wave.
- Added new Eden quests for level 121 ~ 130 range
- Max base level changed from 150 to 160/50.
-
Skill Timers
- 2012.09.19 : Champion Mobs.
- 2012.10.10 : Ranger Falcon changed to Owl.
- 2012.10.17 : Heroes' Trails (Part 2)
- Devil's Tower Memorial Dungeon
- Cursed Knight Memorial Dungeon
-
Geffen Magic Tournament Memorial Dungeon
- 2012.10.31 : Eden Quests for levels 131~140.
- 2012.12.18 : Horror Toy Factory Memorial Dungeon
- 2012.12.18 : Shadow System
2012.12.28 : Episode 14.3 : Decisive Battle (Part 1)
- 2013.02.20 : Equipment Comparison System
- 2013.03.13 : 'Clock Tower Dungeon' Nightmare Mode.
2013.03.20 : Episode 14.3 : Decisive Battle (Part 2)
- 2013.03.20 : Level Increased to 175 / 60.
- 2013.03.20 : New Third Class Skills
- 2013.05.22 : Max Zeny Vending Price = 1 Billion Zeny.
- 2013.06.12 : Bank System
- 2013.06.26 : Clan System (Golden mace Guild, Sword Guild, Crossbow Guild and Rod Guild)
2013.07.03 : Episode 15.1 : Fantasmagorica
- Lots of NPC placement changes.
- 5 New Quests
- Memorial Dungeon, Charleston Factory
- New Items
- 2013.07.31 : Rebellion Class
- 2013.08.02 : Rebellion Weapons
- 2013.08.14 : New Clothing Dyes for Kagerou & Oboro classes.
- 2013.08.21 : Max HP Limits (lvl 99 = 330k, 150 = 660k, 175 = 1.1m)
- 2013.09.25 : Heroes' Trail Part (Part 3)
-
Fenrir and Airship Assault Memorial Dungeons.
- 2013.12.17 : Nightmare Biolabs
2013.12.23 : Episode 15.2 : Memory Record
- 2014.01.08 : New World Map.
- 2014.01.22 : Shop History (Buy/Sell Log)
- 2014.03.12 : Eden Group Market Hall
- 2014.04.16 : Summons & Homunculus S Update
- 2014.08.06 : Monster EXP Increased (Base 75% & Job 100%)
- 2014.08.06 : Monster HP/ATK Adjustment
- 2014.09.16 : WoE TE Items
- 2014.10.07 : Lucky Roulette
- 2014.10.07 : Pet Evolution
- 2014.10.28 : Infinite Space
- 2014.11.05 : Clan System
- 2014.11.11 : RoDex (Revamped Mail System)
2015.02.25 : Episode 16.1 : Banquet of Heroes
- 2015.02.25 : Achievement and Title System Added
- 2015.02.25 : Banquet Preparation
- 2015.02.25 : New Dungeon
- 2015.02.25 : Honor Tokens and New Enchant Item
- 2015.07.01 : Infinite Space Dungeon Improvements
- 2015.10.07 : Item Link System (show your items via PM)
- 2015.10.07 : Eden Group Revamp (missions changed)
- 2015.10.14 : Reputation System
- 2016.01.26 : Styling Shop Interface
2016.03.09 : Episode 16.2 : Terra Gloria
- 2016.05.10 : Rebellion Class Changes
- 2016.08.30 : Card Removal System Update
- 2016.09.06 : Eden Group Changes (100-140)
- 2016.12.07 : Rock Ridge
- 2016.12.13 : Marriage System Update (Doram x Human)
- 2016.12.27 : New Dungeon : Illusion of Moonlight
- 2017.01.03 : Glastheim Changes
- 2017.01.25 : New Dungeon : Illusion of Vampire
- 2017.02.21 : New Dungeon : Illusion of Frozen
- 2017.04.18 : New Dungeon : Illusion of Abyss
- 2017.05.23 : Party System UI Update
- 2017.06.07 : Autotrading / Vending Overhaul
- 2017.06.21 : Equipment Replace System
- 2017.06.21 : Orc Memory Changes
- 2017.06.27 : Monster Racing Revamp
- 2017.09.26 : Moscovia Card Updates
- 2018.03.09 : New Dungeon : Illusion of Teddy Bear
- 2018.05.04 : New Dungeon : Illusion of Luanda
- 2018.06.27 : World Map Improvements
2018.07.18 : Episode 17.1 : Illusion
- 2018.08.09 : Max Level Increased to 185
-
Their names are in there huge == one of the jA devs.we need to say thanks for the persons who developed the Athena. Without Athena, we're nothing.
-
how to checkout only the master branch.
not all branches?
git clone -b master --single-branch https://github.com/HerculesWS/Hercules
Scripting Standards
in Development Discussion
Posted
Agreed. What script do we have with the most indents? Figure that'd be the best thing to test it out on.