Easycore

Open src/map/trade.c, find: // save both player to avoid crash: they always have no advantage/disadvantage between the 2 players if (map->save_settings&1) { chrif->save(sd,0); chrif->save(tsd,0); } Add below: npc->event_doall_id( "OnTradeEvent", sd->bl.id ); npc->event_doall_id( "OnTradeEvent", tsd->bl.id ); Test NPC: - script TradeTest FAKE_NPC,{ OnTradeEvent: mes "Hello, world!"; close; }

1. You're using a npctimer, so there aren't players attached. getmapxy("<variable for map name>", <variable for x>, <variable for y>, <type>{, "<search parameter>"}) 2. You need to specific the search parameter, in this case the monster GID, if you don't specific this, getmapxy will take as PC Character invoked. 3. Also, you've used PC variables (@). 4. Replace .@GID temporal variable for .GID permanent variable (you need to store this). 5. For HP/SP see 'getunitdata'.

A temporary solution for this is replace: hBG_queue2teams .BG_Queue,.BG_Players_Min[$BG_Index],.BG_Players_Max[$BG_Index],.TeamBuildingMode,$@BG_Team1,$@BG_Team2; For: hBG_balance_teams .BG_Queue,.BG_Players_Max[$BG_Index],.TeamBuildingMode,$@BG_Team1,$@BG_Team2; In hBG/bg_common.txt

I was referring to this image: Some fixes and additions in PR: You can try these changes here, until Smoke approve and merge this. Report any errors, note that I'm beginner compared to Smoke.

Happy can convert Source mod to Plugin. Check his paid services here.

1.- This has been fixed in latest commit. 2.- This is related to the .@Rate variable of rewards, see OnValidateScore label. 3.- in hBG_warp "RespawnPoint" map is equal to 0, so console take this as error. 4.- That screenshot was captured for a hide Admin, he wasn't in any BG Team. 5.- GD skills delay is fixed in this Pull Request, waiting for Smoke check and merge this.

About emblem above characters, I tried change Flags in clif_maptypeproperty2 and this is what I got: I honestly don't know how to remove swords icon. Maybe @Smoke or @Dastgir can solved this.

- Fixed Guild Skills cooldown in Battleground. - Added 3 new commands ( @leader, @bgsize and @bgmode ) Details on Pull Request. @Smoke

@Hit` Add maps from "resnametable.txt" to your mapcache. If you don't know how, see this topic. A temporary solution to the skills, is to add this below of "disable_items;" lines in hBG\bg_flavius_ctf.txt: // Disable skill usage atcommand "@addperm disable_skill_usage"; And add this below of "enable_items;" lines: // Enable Skill usage atcommand "@rmvperm disable_skill_usage"; enable_items() and disable_items() only works when a NPC Script is running.

I got the same error, It was solved by compiling with MSVS 2015. I solved this, see this PR.

I fixed this error and made a PR. https://github.com/Smokexyz/HerculesBG/pull/11 I'd like @Smoke could check it. Maybe I'm wrong in something.

I made a command for switch BG Modes. Open hBG\bg_common.txt and copy this before of OnBGStartCommand: Find /* Player Commands */ and copy above: Finally find // Team Building Mode : and copy above: Usage: @bgmode <1-10> #1 - Random Mode #2 - Capture the Flag #3 - Eye of Storm #4 - Triple Inferno #5 - Team DeathMatch #6 - Bossnia #7 - Conquest #8 - Stone Control #9 - Domination #10 - Rush

Try to make a Pull Request. Flag is ok, monster have state.immunity, but this state doesn't do anything. It's neccesary to add a Post-Hook like this: http://upaste.me/96ab2190644336d95#LC209 I'd like do it, but I have poor knowledge about src/plugin, and this seems serious. EDIT: I finally decided to try fix it and I did a Pull Request with the changes. https://github.com/Smokexyz/HerculesBG/pull/10

I compiled in MSVS 2015 and It finally works.

Yep, I extracted from here.

What error? Post the message here. I'm compiling with latest herc and its all good. I posted previously: Hello, could you please pull the latest commit from the repository and try again? I pulled to latest commit, also I tried to compile in a new emulator folder (Updated to latest commit)

What error? Post the message here. I'm compiling with latest herc and its all good. I posted previously:

Any solution for compile error/warning in latest Herc?

1>------ Operación Compilar iniciada: proyecto: plugin-sample, configuración: Debug Win32 ------ 1> hBG.c 1>..\src\plugins\hBG.c(1071): warning C4018: '<' : does not match signed/unsigned 1>..\src\plugins\hBG.c(2049): warning C4018: '<' : does not match signed/unsigned 1>..\src\plugins\hBG.c(2050): warning C4018: '<' : does not match signed/unsigned 1>..\src\plugins\hBG.c(2523): warning C4018: '>=' : does not match signed/unsigned 1>..\src\plugins\hBG.c(2581): warning C4018: '<' : does not match signed/unsigned 1>..\src\plugins\hBG.c(2587): warning C4018: '<' : does not match signed/unsigned 1>..\src\plugins\hBG.c(2593): error C2143: error de sintaxis : need ';' in front of 'type' 1>..\src\plugins\hBG.c(2594): error C2065: 'i' : undeclared identifier 1>..\src\plugins\hBG.c(2595): error C2065: 'i' : undeclared identifier 1>..\src\plugins\hBG.c(2614): error C2143: error de sintaxis : need ';' in front of 'type' 1>..\src\plugins\hBG.c(2615): error C2143: error de sintaxis : need ';' in front of 'type' 1>..\src\plugins\hBG.c(2617): error C2065: 'i' : undeclared identifier 1>..\src\plugins\hBG.c(2618): error C2065: 'i' : undeclared identifier 1>..\src\plugins\hBG.c(2621): error C2065: 'pos' : undeclared identifier 1>..\src\plugins\hBG.c(2621): error C2065: 'i' : undeclared identifier 1>..\src\plugins\hBG.c(2623): error C2065: 'qm' : undeclared identifier 1>..\src\plugins\hBG.c(2623): error C2065: 'pos' : undeclared identifier 1>..\src\plugins\hBG.c(2623): warning C4047: '=' : 'int' Is different in the levels of indirect addressing of 'hBG_queue_member *' 1>..\src\plugins\hBG.c(2623): warning C4047: '==' : 'int' Is different in the levels of indirect addressing of 'void *' 1>..\src\plugins\hBG.c(2623): error C2223: el operando izquierdo de '->sd' debe señalar a struct/union 1>..\src\plugins\hBG.c(2717): warning C4018: '<' : does not match signed/unsigned 1>..\src\plugins\hBG.c(3722): warning C4018: '<' : does not match signed/unsigned 1>..\src\plugins\hBG.c(3724): warning C4018: '<' : does not match signed/unsigned 1>..\src\plugins\hBG.c(3862): warning C4018: '<' : does not match signed/unsigned ========== Compilar: 0 correctos, 1 incorrectos, 0 actualizados, 0 omitidos ========== Problem compiling in latest Herc.

Packets were added in 2016-10-05a I undestand. Thank you for all the contribution you make in Hercules.

From what client start this feature?

Enable Custom Job diff doesn't work in latest clients (After Doram/Summoner implementation). The client exe doesn't open, will you update this? PS: I'm using "2015-11-04aRagexe"

bonus2 bSkillAtk,NPC_EARTHQUAKE,n;

Hello Herc community, Not long ago, I started to create paid skills, so I decided to create a Christmas-themed skill: Happy Christmas!! [ALL_XMAS] Max Lv: 2 Type: No damage/Target SP/Cast/Delay: 0 Description: Change clothes to xmas attire, if the target is in xmas attire, target will return to normal clothes. If you use the skill on Lv 2, "We Wish Song" will reproduce. [Preview]: Manual of Installation & configuration are adjunted to .zip. Regards~ ALL_XMAS by Easycore.zip